* [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM
@ 2023-04-29 14:07 Himanshu Bhavani
2023-04-30 10:13 ` Francesco Dolcini
2023-04-30 12:07 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Himanshu Bhavani @ 2023-04-29 14:07 UTC (permalink / raw)
To: robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
marex@denx.de, festevam@denx.de, frieder.schrempf@kontron.de,
marcel.ziswiler@toradex.com, max.krummenacher@toradex.com,
stefan.wahren@i2se.com, matthias.schiffer@tq-group.com,
denys.drozdov@toradex.com, leoyang.li@nxp.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
From 8756e66b7fba0a5063c6011983eb876456504ede Mon Sep 17 00:00:00 2001
From: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
Date: Sat, 29 Apr 2023 19:32:27 +0530
Subject: [PATCH] Add an entry in imx8mm boards for Emtop SOM-IMX8MM
Added an entry to the list of imx8mm boards denoting the Emtop SOM-IMX8MM
Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 442ce8f4d675..61f3beabb1d0 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -902,6 +902,7 @@ properties:
- toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules
- variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-MX8MM module
- prt,prt8mm # i.MX8MM Protonic PRT8MM Board
+ - fsl,imx8mm-emtop # i.MX8MM Emtop SOM
- const: fsl,imx8mm
- description: Engicam i.Core MX8M Mini SoM based boards
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM
2023-04-29 14:07 [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM Himanshu Bhavani
@ 2023-04-30 10:13 ` Francesco Dolcini
2023-04-30 12:07 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Francesco Dolcini @ 2023-04-30 10:13 UTC (permalink / raw)
To: Himanshu Bhavani
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, marex@denx.de, festevam@denx.de,
frieder.schrempf@kontron.de, marcel.ziswiler@toradex.com,
max.krummenacher@toradex.com, stefan.wahren@i2se.com,
matthias.schiffer@tq-group.com, denys.drozdov@toradex.com,
leoyang.li@nxp.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
On Sat, Apr 29, 2023 at 02:07:51PM +0000, Himanshu Bhavani wrote:
> >From 8756e66b7fba0a5063c6011983eb876456504ede Mon Sep 17 00:00:00 2001
> From: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
> Date: Sat, 29 Apr 2023 19:32:27 +0530
> Subject: [PATCH] Add an entry in imx8mm boards for Emtop SOM-IMX8MM
These looks just broken
> Added an entry to the list of imx8mm boards denoting the Emtop SOM-IMX8MM
>
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..61f3beabb1d0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -902,6 +902,7 @@ properties:
> - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules
> - variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-MX8MM module
> - prt,prt8mm # i.MX8MM Protonic PRT8MM Board
> + - fsl,imx8mm-emtop # i.MX8MM Emtop SOM
Wrong vendor? fsl is freescale AKA nxp, and this board is supposed to be
emtop.
Francesco
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM
2023-04-29 14:07 [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM Himanshu Bhavani
2023-04-30 10:13 ` Francesco Dolcini
@ 2023-04-30 12:07 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-30 12:07 UTC (permalink / raw)
To: Himanshu Bhavani, robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
marex@denx.de, festevam@denx.de, frieder.schrempf@kontron.de,
marcel.ziswiler@toradex.com, max.krummenacher@toradex.com,
stefan.wahren@i2se.com, matthias.schiffer@tq-group.com,
denys.drozdov@toradex.com, leoyang.li@nxp.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
On 29/04/2023 16:07, Himanshu Bhavani wrote:
> From 8756e66b7fba0a5063c6011983eb876456504ede Mon Sep 17 00:00:00 2001
> From: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
> Date: Sat, 29 Apr 2023 19:32:27 +0530
> Subject: [PATCH] Add an entry in imx8mm boards for Emtop SOM-IMX8MM
Please fix your patch format.
Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).
>
> Added an entry to the list of imx8mm boards denoting the Emtop SOM-IMX8MM
>
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..61f3beabb1d0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -902,6 +902,7 @@ properties:
> - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules
> - variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-MX8MM module
> - prt,prt8mm # i.MX8MM Protonic PRT8MM Board
> + - fsl,imx8mm-emtop # i.MX8MM Emtop SOM
Messed order, incorrect vendor prefix. Also board name looks actually
missing.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-30 12:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-29 14:07 [PATCH] yaml: Add an entry in imx8mm boards for Emtop SOM-IMX8MM Himanshu Bhavani
2023-04-30 10:13 ` Francesco Dolcini
2023-04-30 12:07 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).