From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F72DC77B72 for ; Thu, 20 Apr 2023 15:47:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232496AbjDTPry (ORCPT ); Thu, 20 Apr 2023 11:47:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232420AbjDTPrw (ORCPT ); Thu, 20 Apr 2023 11:47:52 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B7FAE51 for ; Thu, 20 Apr 2023 08:47:51 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id c9so7520668ejz.1 for ; Thu, 20 Apr 2023 08:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682005669; x=1684597669; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ii0rJDmD6wGcfR9R86o46jWR7Sx2THT0mFJ55bpx/lc=; b=XK4cAxcm9V+tmT5sYaMjsisB8fWSfvuQ3Whf7RuncKhI7VhoZ4bCjDetHGvfTfIm5f TvT4iDeOzqgdC7mdtXMmOezBUtCgt6BrOOlodawLenZ6trC1ZceJ6OfZV9CV5NpBxRXx k3+pXE/yBt55rJ7IGr13BDleUvH2P3i8F4cIhwVd30YHPkfVKjEIFZIj39cl8zk+9AVx XvhwAiQr9lz0VL+itTJCDEoEofnBo2a7IfNvV/DD6vNAodHU9yIR4vyU7Gldv8cCwxdm aRH8ewKOrL/gfzSc7kCFKR3paTDTKNOG2/Hwho1K/uFh38sH3Lv7q1roYKsx54I3RTP0 r5sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682005669; x=1684597669; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ii0rJDmD6wGcfR9R86o46jWR7Sx2THT0mFJ55bpx/lc=; b=g8Y+WqKprD1pg7gWkYy0jvYRS2ypMXq6e2z0hnwrerYnIfhCTPG1AUW4p/lbjb7xR0 qe/ncu1bTaaGWMC7TuZ8+Dzipu90hYQGYUbucqIPUQKt44tNtHKlhXqgLrVpYEMeha/q pZ6d5pvg6Hx6lGnHvqUMYfFtau606vNaO/5RVvVRS02XiDRkXughh+KJyqIaN7k8U53S Um8biQKkSiG/HJqfvNb4xMPFzqK0wRvY8As8A0wmMH5oOw8zeWg4de31HObyNnYoT070 yt/dkSt+AP/xSGMlRJc7PgIJ04qoF7aFsUD3e5chiXqVZJg8Kz4kg0loryrwonVNyTGb F3Jw== X-Gm-Message-State: AAQBX9fjwRDnM54X0Ek6j5TkyAZxYgYB+lXheVU291RgNFkeT1N0Yqr0 iztz7BF8fv6JMLCbeMF2WyKlIw== X-Google-Smtp-Source: AKy350bigdojBVAu1yf8DpxqzPZ+1OFcdgyfRolFxaaBBS3Mmcpps74+3jkoTtBj2wvJL7j/Sn3gIQ== X-Received: by 2002:a17:906:7215:b0:94f:61b2:c990 with SMTP id m21-20020a170906721500b0094f61b2c990mr2092604ejk.25.1682005669571; Thu, 20 Apr 2023 08:47:49 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:bcb8:77e6:8f45:4771? ([2a02:810d:15c0:828:bcb8:77e6:8f45:4771]) by smtp.gmail.com with ESMTPSA id a8-20020a1709063e8800b0094e4684e5c0sm867274ejj.25.2023.04.20.08.47.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 08:47:49 -0700 (PDT) Message-ID: Date: Thu, 20 Apr 2023 17:47:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/4] dt-bindings: net: can: Make interrupt attributes optional for MCAN Content-Language: en-US To: Marc Kleine-Budde , Judith Mendez Cc: Chandrasekar Ramakrishnan , Wolfgang Grandegger , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Schuyler Patton , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Oliver Hartkopp , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org References: <20230419223323.20384-1-jm@ti.com> <20230419223323.20384-3-jm@ti.com> <20230420-zoom-demystify-c31d6bf25295-mkl@pengutronix.de> From: Krzysztof Kozlowski In-Reply-To: <20230420-zoom-demystify-c31d6bf25295-mkl@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/04/2023 12:01, Marc Kleine-Budde wrote: > On 19.04.2023 17:33:21, Judith Mendez wrote: >> For MCAN, remove interrupt and interrupt names from the required >> section. >> >> On AM62x SoC, MCANs on MCU domain do not have hardware interrupt >> routed to A53 Linux, instead they will use software interrupt >> by hrtimer. Make interrupt attributes optional in MCAN node >> by removing from required section. >> >> Signed-off-by: Judith Mendez > > This series basically adds polling support to the driver, which is > needed due to HW limitations. > > The proposed logic in the driver is to use polling if > platform_get_irq_byname() fails (due to whatever reason) use polling > with a hard-coded interval. > > In the kernel I've found the following properties that describe the > polling interval: > > bindings/input/input.yaml: > > | poll-interval: > | description: Poll interval time in milliseconds. > | $ref: /schemas/types.yaml#/definitions/uint32 > > > bindings/thermal/thermal-zones.yaml: > > | polling-delay: > | $ref: /schemas/types.yaml#/definitions/uint32 > | description: > | The maximum number of milliseconds to wait between polls when > | checking this thermal zone. Setting this to 0 disables the polling > | timers setup by the thermal framework and assumes that the thermal > | sensors in this zone support interrupts. > > bindings/regulator/dlg,da9121.yaml > > | dlg,irq-polling-delay-passive-ms: > | minimum: 1000 > | maximum: 10000 > | description: | > | Specify the polling period, measured in milliseconds, between interrupt status > | update checks. Range 1000-10000 ms. > > From my point of view the poll-interval from the input subsystem looks > good. Any objections to use it to specify the polling interval for > IRQ-less devices, too? Better to skip it, if delay can be figured out by driver based on something else (e.g. clocks). Best regards, Krzysztof