From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.mainlining.org (mail.mainlining.org [5.75.144.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F7B01EB5E6; Fri, 2 May 2025 19:04:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.75.144.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746212694; cv=none; b=ETn/vh4T20dnHZ+dm+M7xWR/j65YzQMdLw9TRJLh7uckIJMLDv60h6x4TIOI43yMRYWowtLDDePBGL4Y4bQkesS3LorkDSIIT5duiGPCSQ3ePq7y3Cc3u2uh+vPfDs+ylmH4aEoF2VA5s28JePZrqoQ8auOB1fFDtabaEGGxjk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746212694; c=relaxed/simple; bh=p7XIGW72I/91fLazyIlExCv1uQr/qO433Ug1xE3MvsU=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=C8PQEPUk7xvW2zcKJXpvEC9TymtQg1kcizbU0eAi84WE+zorQTO1MEdP22BUSYZ0p9BOSIKITbSTvBqBomX5dW3iBwFVQtERcxK0cx+vNVF5pCtLvv0wFcpTc7AwFPh1VIfq5yPVKBdOOKniJNBPe+hMU9XTktRJeo8DdgL3TsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mainlining.org; spf=pass smtp.mailfrom=mainlining.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=p4qqZM6h; arc=none smtp.client-ip=5.75.144.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mainlining.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mainlining.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="p4qqZM6h" Received: from localhost (web.docker-mailserver_default [172.18.0.2]) by mail.mainlining.org (Postfix) with ESMTPSA id 71034BBAC4; Fri, 2 May 2025 19:04:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mainlining.org; s=psm; t=1746212684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qM7bXBHe1bXroHuK8JaLfF5A62uJE4FV4UFgd1YY7Z4=; b=p4qqZM6hk7CsMYNc6A9L8oCFEPGgrrln3MTHLjBn5mo9Gn59CYx++5icdw48Q0QaIFEBOq PmTfTckQgiXuEWVWwLo99fCwoVmRNDeIx0TqYfT9zyvxGX16hiZXip562t8NQkXAHCA0O3 03CWY4qHkYXKWd4x10AY+TpFjqHG0VsG9hdaPPXMGSb7scb0Ee4rJ/Ak3K7bEI8T6lF00Q JJvqN9tl6F71Y5bP0EDfK7VFuYiu1b3pewx94S9+gPV4wARKwvMyGT1QQbmZLDijA3D9+s i4GEwXZMRHF/3sdmaQIGlB9Dd9tw5/gKjIFeCYZc3M8gpnhMQObe7f3HJOyzOQ== Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 02 May 2025 21:04:44 +0200 From: barnabas.czeman@mainlining.org To: Konrad Dybcio Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , =?UTF-8?Q?Otto_Pfl=C3=BCger?= , Linus Walleij , Lee Jones , Joerg Roedel , Will Deacon , Robin Murphy , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Baryshkov , Adam Skladowski , Sireesh Kodali , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, Dang Huynh Subject: Re: [PATCH v5 3/5] arm64: dts: qcom: Add initial support for MSM8937 In-Reply-To: <656da4e9-b609-43f4-9afd-006698a2c7d6@oss.qualcomm.com> References: <20250421-msm8937-v5-0-bf9879ef14d9@mainlining.org> <20250421-msm8937-v5-3-bf9879ef14d9@mainlining.org> <2e3d94a4-d9e1-429e-9f65-d004c80180e5@oss.qualcomm.com> <790a0b7537e0b82b70bc4b32612ecee6@mainlining.org> <70635d75-03f9-49ea-8098-57cb144fda94@oss.qualcomm.com> <5ccb39f9393b44761127717096a38a46@mainlining.org> <68e2c0ee-d5e2-40fd-9ca0-262ed3270628@oss.qualcomm.com> <31559417a92d1e1ff17d0f3add9a1ba0@mainlining.org> <656da4e9-b609-43f4-9afd-006698a2c7d6@oss.qualcomm.com> Message-ID: X-Sender: barnabas.czeman@mainlining.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025-04-25 23:02, Konrad Dybcio wrote: > On 4/25/25 10:22 PM, barnabas.czeman@mainlining.org wrote: >> On 2025-04-25 21:26, Konrad Dybcio wrote: >>> On 4/25/25 5:13 PM, barnabas.czeman@mainlining.org wrote: >>>> On 2025-04-25 11:57, Konrad Dybcio wrote: >>>>> On 4/23/25 4:46 PM, barnabas.czeman@mainlining.org wrote: >>>>>> On 2025-04-23 16:03, Konrad Dybcio wrote: >>>>>>> On 4/21/25 10:18 PM, Barnabás Czémán wrote: >>>>>>>> From: Dang Huynh >>>>>>>> >>>>>>>> Add initial support for MSM8937 SoC. >>>>>>>> >>>>>>>> Signed-off-by: Dang Huynh >>>>>>>> Co-developed-by: Barnabás Czémán >>>>>>>> >>>>>>>> Signed-off-by: Barnabás Czémán >>>>>>>> --- >>>>> >>>>> [...] >>>>> >>>>>>>> +            gpu_opp_table: opp-table { >>>>>>>> +                compatible = "operating-points-v2"; >>>>>>>> + >>>>>>>> +                opp-19200000 { >>>>>>>> +                    opp-hz = /bits/ 64 <19200000>; >>>>>>>> +                    opp-supported-hw = <0xff>; >>>>>>> >>>>>>> The comment from the previous revision still stands >>>>>> If i remove opp-supported-hw i will got -22 EINVAL messages and >>>>>> the opp will be not fine. >>>>> >>>>> Right, I have a series pending to improve this situation a bit.. >>>>> >>>>> In the meantime, you should be able to define the nvmem cell and >>>>> fill in meaningful values for this platform >>>> As I wrote in the previous revision there is no nvmem for GPU on >>>> msm8937 only on msm8940. >>> >>> This seems not to be the case >>> >>> https://github.com/penglezos/android_kernel_xiaomi_msm8953/blob/pie/arch/arm/boot/dts/qcom/msm8937.dtsi#L2046-L2191 >>> >> These are on msm-4.9 was moved to msm8940.dtsi >> https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/msm8937-gpu.dtsi#L162 >> https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/msm8940.dtsi#L600 >> 475 MHz and 500 MHz is for msm8940 at least based on 4.9 > > I'll try to get a more conclusive answer internally Any information? I am thinking about define nvmem cells based on 3.18 > > Konrad