From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21C64158DCF; Mon, 30 Mar 2026 09:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774864076; cv=none; b=jNPFgAaei//i8BQlX1OgLJN1DcG4qYcX6YX6NnTdCBZvqcc4wHguRz72nW4GerksuU9ZKxbsKPE0AKQBDIvQxTDwdvNk4zpaLbNJx/ppICvF73MyyEhsnz6me6dvqQtAWrv0qjh6uCgFheN/BGI0PXhO6nIzpUE51VnqhHBAXHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774864076; c=relaxed/simple; bh=hmH/oEBaf5x0MhGOjXg8OVLdrIBQa3C3PfA5l9X07Dg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vEK6edrrApqM3djJQMDCr7gg/WB0NsqC/n4a2ujRnDt8u0PD5qW6mgLMo4EdKC4dgIv/e5i5P8iaYKCsRNCBjiKFm7ZJSk89I/cGWJoTWENZKOtfBWMD3zYVZNNjqPCO6cOOvdcS460rSnLAKO1hOWSzQbFPif0Wy6vZb42/JGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OfAA7BBF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OfAA7BBF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0E8CC4CEF7; Mon, 30 Mar 2026 09:47:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774864076; bh=hmH/oEBaf5x0MhGOjXg8OVLdrIBQa3C3PfA5l9X07Dg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OfAA7BBFrpATgYP6Eg5xG9CeGdcT70kEKTzIXueJNc7i3d6qpTMu07b/EM6+EDl4q oATftnhUHkkOisWQFv6GrSI4UJi+SP/D1icd+b1Ot8gKvDYXjA5wQNNPFCh7u12Kh+ EnzMaWhDJ8v+CvdFfkDrKar/L25REAH9y7xQDgj044jSyj3nG3MqiUmIItbVnmqbP2 hTGwyHeG8HeT6e0ysTsJDOGw3V0YAu0XmMvFEe3S75PWMkwHS70PzXNUSccReRPh07 hR5LkiZWq00E5LA2JlJ/btSe+zXbJW6vJM/o/t0YuNa2asJIutSyOSRNbOiM58VwCn jxwOwdEY6jJTQ== Message-ID: Date: Mon, 30 Mar 2026 11:47:50 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Add monaco-evk-ac-sku support To: Umang Chheda Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260328-monaco-evk-ac-sku-v1-0-79d166fa5571@oss.qualcomm.com> <20260328-monaco-evk-ac-sku-v1-1-79d166fa5571@oss.qualcomm.com> <20260329-accelerated-pigeon-of-joy-c6c903@quoll> <7f5bfeb8-7d91-419b-981d-1f0f568f01d2@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 30/03/2026 11:36, Umang Chheda wrote: > Hello Krzysztof, > > On 3/30/2026 12:24 PM, Krzysztof Kozlowski wrote: >> On 30/03/2026 08:50, Umang Chheda wrote: >>> Hello Krzysztof, >>> >>> On 3/29/2026 3:22 PM, Krzysztof Kozlowski wrote: >>>> On Sat, Mar 28, 2026 at 05:11:17PM +0530, Umang Chheda wrote: >>>>> Introduce new bindings for the monaco-evk-ac-sku, >>>>> an IoT board based on the QCS8300-AC variant SoC. >>>> Please wrap commit message according to Linux coding style / submission >>>> process (neither too early nor over the limit): >>>> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 >>> >>> >>> Ack >>> >>>> >>>>> Signed-off-by: Umang Chheda >>>>> --- >>>>> Documentation/devicetree/bindings/arm/qcom.yaml | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >>>>> index ca880c105f3b..07053cc2ac1c 100644 >>>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >>>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >>>>> @@ -918,6 +918,7 @@ properties: >>>>> - enum: >>>>> - arduino,monza >>>>> - qcom,monaco-evk >>>>> + - qcom,monaco-evk-ac-sku >>>> Why adding name 'sku' to the compatible? What's the meaning here? >>> >>> >>> Monaco SoC has 2 variants  - monaco-aa and monaco-ac -- "monaco-evk" board uses monaco-aa variant of SoC and this new >> >> so ac? or ac-sku? Decide. >> >>> introduced board uses the monaco-ac variant SoC. Hence added the compatible as "monaco-evk-ac-sku" to differentiate it from >>> monaco-evk board. >> >> Wrap your emails. > > Ack >> >> "ac" differentiates. Why do you need to say that a variant is a >> "-variant"? >> > > The intent for using "-sku" here was to match the existing upstream > practice where boards that are otherwise identical but differ in H/W > configuration (SoC variant, storage etc) are represented as separate SKUs. > > For Example: > - sc7180-trogdor-*-sku.dtsi > - sc7280-herobrine-*-sku.dtsi > - mt8183-kukui-jacuzzi-*-sku.dts We talk about compatible, why any of DTS names matter? You don't understand the meaning of sku. It makes no sense without the number/ID. It's like you called it "-revision"... Best regards, Krzysztof