From: "'Kishon Vijay Abraham I' via linux-sunxi" <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 1/8] dt-bindings: phy: sun4i-usb-phy: Add property descriptions for H3
Date: Tue, 8 Aug 2017 17:46:33 +0530 [thread overview]
Message-ID: <c7dfc4e8-7a4e-e57d-e1e8-16f0a56cd505@ti.com> (raw)
In-Reply-To: <20170803081411.22389-2-wens-jdAy2FN1RRM@public.gmane.org>
On Thursday 03 August 2017 01:44 PM, Chen-Yu Tsai wrote:
> The Allwinner H3 SoC has 4 USB PHYs, so it needs four sets of pmu
> regions, clocks, resets, and optional vbus properties. These were
> not described when the H3 compatible string was added.
>
> Fixes: 626a630e003c ("phy-sun4i-usb: Add support for the host usb-phys
> found on the H3 SoC")
> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Rob, can you give your Acked-by for this patch?
Thanks
Kishon
> ---
> Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt
> index 005bc22938ff..893dd01dfe64 100644
> --- a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt
> @@ -17,18 +17,21 @@ Required properties:
> * "phy_ctrl"
> * "pmu0" for H3, V3s and A64
> * "pmu1"
> - * "pmu2" for sun4i, sun6i or sun7i
> + * "pmu2" for sun4i, sun6i, sun7i or sun8i-h3
> + * "pmu3" for sun8i-h3
> - #phy-cells : from the generic phy bindings, must be 1
> - clocks : phandle + clock specifier for the phy clocks
> - clock-names :
> * "usb_phy" for sun4i, sun5i or sun7i
> * "usb0_phy", "usb1_phy" and "usb2_phy" for sun6i
> * "usb0_phy", "usb1_phy" for sun8i
> + * "usb0_phy", "usb1_phy", "usb2_phy" and "usb3_phy" for sun8i-h3
> - resets : a list of phandle + reset specifier pairs
> - reset-names :
> * "usb0_reset"
> * "usb1_reset"
> - * "usb2_reset" for sun4i, sun6i or sun7i
> + * "usb2_reset" for sun4i, sun6i, sun7i or sun8i-h3
> + * "usb3_reset" for sun8i-h3
>
> Optional properties:
> - usb0_id_det-gpios : gpio phandle for reading the otg id pin value
> @@ -37,6 +40,7 @@ Optional properties:
> - usb0_vbus-supply : regulator phandle for controller usb0 vbus
> - usb1_vbus-supply : regulator phandle for controller usb1 vbus
> - usb2_vbus-supply : regulator phandle for controller usb2 vbus
> +- usb3_vbus-supply : regulator phandle for controller usb3 vbus
>
> Example:
> usbphy: phy@0x01c13400 {
>
next prev parent reply other threads:[~2017-08-08 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 8:14 [PATCH 0/8] ARM: sun8i: a83t: Add USB host support Chen-Yu Tsai
[not found] ` <20170803081411.22389-1-wens-jdAy2FN1RRM@public.gmane.org>
2017-08-03 8:14 ` [PATCH 1/8] dt-bindings: phy: sun4i-usb-phy: Add property descriptions for H3 Chen-Yu Tsai
[not found] ` <20170803081411.22389-2-wens-jdAy2FN1RRM@public.gmane.org>
2017-08-08 12:16 ` 'Kishon Vijay Abraham I' via linux-sunxi [this message]
2017-08-10 17:08 ` Rob Herring
2017-08-17 17:05 ` Chen-Yu Tsai
[not found] ` <CAGb2v65mKdQC40ASsmeWqCxnDWV4mmf9QFo5-t7spX9RRJBdbg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-18 10:53 ` 'Kishon Vijay Abraham I' via linux-sunxi
[not found] ` <7a1889e0-6733-3f7d-4b34-b08e8bf3e2b5-l0cyMroinI0@public.gmane.org>
2017-08-19 2:34 ` Chen-Yu Tsai
2017-08-03 8:14 ` [PATCH 2/8] dt-bindings: phy: sun4i-usb-phy: Add compatible string for A83T Chen-Yu Tsai
[not found] ` <20170803081411.22389-3-wens-jdAy2FN1RRM@public.gmane.org>
2017-08-10 17:09 ` Rob Herring
2017-08-03 8:14 ` [PATCH 3/8] phy: sun4i-usb: Support secondary clock for HSIC PHY Chen-Yu Tsai
2017-08-03 8:14 ` [PATCH 4/8] phy: sun4i-usb: Support A83T USB PHYs Chen-Yu Tsai
2017-08-03 8:14 ` [PATCH 5/8] ARM: sun8i: a83t: Add USB PHY and host device nodes Chen-Yu Tsai
2017-08-03 8:14 ` [PATCH 6/8] ARM: sun8i: a83t: Add device node for USB OTG controller Chen-Yu Tsai
2017-08-03 8:14 ` [PATCH 7/8] ARM: sun8i: a83t: cubietruck-plus: Enable onboard USB peripherals Chen-Yu Tsai
2017-08-03 8:14 ` [PATCH 8/8] ARM: sun8i: a83t: h8homlet-v2: Enable USB ports Chen-Yu Tsai
2017-08-19 2:41 ` [PATCH 0/8] ARM: sun8i: a83t: Add USB host support Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7dfc4e8-7a4e-e57d-e1e8-16f0a56cd505@ti.com \
--to=linux-sunxi-/jypxa39uh5tlh3mbocffw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).