Re: [PATCH v3 00/11] ARM: Add support for MediaTek MT6572 SoC

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 01/07/25 17:30, Rob Herring ha scritto:
> On Tue, Jul 1, 2025 at 10:27 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>>
>>
>> On Tue, 01 Jul 2025 09:06:54 +0300, Max Shevchenko wrote:
>>> This series of patches adds support for the MT6572 SoC and
>>> the JTY D101 tablet and Lenovo A369i smartphone based on it.
>>>
>>> Signed-off-by: Max Shevchenko <wctrl@proton.me>
>>> ---
>>> Changes in v3:
>>> - Remove the compatible property from the SoC devicetree
>>> - Link to v2: https://lore.kernel.org/r/20250626-mt6572-v2-0-f7f842196986@proton.me
>>>
>>> Changes in v2:
>>> - Drop the status property for the board devicetrees
>>> - Add an soc node for the MT6572 and reorder the nodes and properties
>>> - Change the commit title to a more descriptive one
>>> - Change the cover title to the correct one
>>> - Link to v1: https://lore.kernel.org/r/20250620-mt6572-v1-0-e2d47820f042@proton.me
>>>
>>> ---
>>> Max Shevchenko (11):
>>>        dt-bindings: serial: mediatek,uart: add MT6572
>>>        dt-bindings: interrupt-controller: mediatek,mt6577-sysirq: add MT6572
>>>        dt-bindings: timer: mediatek: add MT6572
>>>        dt-bindings: watchdog: mediatek,mtk-wdt: add MT6572
>>>        dt-bindings: vendor-prefixes: add JTY
>>>        dt-bindings: arm: mediatek: add boards based on the MT6572 SoC
>>>        ARM: mediatek: add board_dt_compat entry for the MT6572 SoC
>>>        ARM: mediatek: add MT6572 smp bring up code
>>>        ARM: dts: mediatek: add basic support for MT6572 SoC
>>>        ARM: dts: mediatek: add basic support for JTY D101 board
>>>        ARM: dts: mediatek: add basic support for Lenovo A369i board
>>>
>>>   .../devicetree/bindings/arm/mediatek.yaml          |   5 +
>>>   .../mediatek,mt6577-sysirq.yaml                    |   1 +
>>>   .../devicetree/bindings/serial/mediatek,uart.yaml  |   1 +
>>>   .../devicetree/bindings/timer/mediatek,timer.yaml  |   1 +
>>>   .../devicetree/bindings/vendor-prefixes.yaml       |   2 +
>>>   .../bindings/watchdog/mediatek,mtk-wdt.yaml        |   1 +
>>>   arch/arm/boot/dts/mediatek/Makefile                |   2 +
>>>   arch/arm/boot/dts/mediatek/mt6572-jty-d101.dts     |  61 ++++++++++++
>>>   arch/arm/boot/dts/mediatek/mt6572-lenovo-a369i.dts |  56 +++++++++++
>>>   arch/arm/boot/dts/mediatek/mt6572.dtsi             | 108 +++++++++++++++++++++
>>>   arch/arm/mach-mediatek/Kconfig                     |   4 +
>>>   arch/arm/mach-mediatek/mediatek.c                  |   1 +
>>>   arch/arm/mach-mediatek/platsmp.c                   |   7 ++
>>>   13 files changed, 250 insertions(+)
>>> ---
>>> base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
>>> change-id: 20250619-mt6572-ef78a3d45168
>>>
>>> Best regards,
>>> --
>>> Max Shevchenko <wctrl@proton.me>
>>>
>>>
>>>
>>
>>
>> My bot found new DTB warnings on the .dts files added or changed in this
>> series.
>>
>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>> are fixed by another series. Ultimately, it is up to the platform
>> maintainer whether these warnings are acceptable or not. No need to reply
>> unless the platform maintainer has comments.
>>
>> If you already ran DT checks and didn't see these error(s), then
>> make sure dt-schema is up to date:
>>
>>    pip3 install dtschema --upgrade
>>
>>
>> This patch series was applied (using b4) to base:
>>   Base: using specified base-commit 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
>>
>> If this is not the correct base, please add 'base-commit' tag
>> (or use b4 which does this automatically)
>>
>> New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/mediatek/' for 20250701-mt6572-v3-0-8937cfa33f95@proton.me:
>>
>> arch/arm/boot/dts/mediatek/mt6572-lenovo-a369i.dtb: / (lenovo,a369i): memory: False schema does not allow {'device_type': ['memory'], 'reg': [[2147483648, 536870912]]}
>>          from schema $id: http://devicetree.org/schemas/root-node.yaml#
>> arch/arm/boot/dts/mediatek/mt6572-jty-d101.dtb: / (jty,d101): memory: False schema does not allow {'device_type': ['memory'], 'reg': [[2147483648, 1073741824]]}
>>          from schema $id: http://devicetree.org/schemas/root-node.yaml#
> 
> 'memory' node without a unit-address has long been deprecated. Please
> don't add more cases.
> 

Agreed.

Cheers,
Angelo