devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Brian Masney <masneyb-1iNe0GrtECGEi8DpZVb4nw@public.gmane.org>
Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <Mark.Rutland-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH 2/4] staging: iio: isl29018: document device tree bindings
Date: Sun, 9 Oct 2016 09:48:14 +0100	[thread overview]
Message-ID: <c7fe672e-3776-a738-91a2-249f7948d606@kernel.org> (raw)
In-Reply-To: <1475801317-29449-2-git-send-email-masneyb-1iNe0GrtECGEi8DpZVb4nw@public.gmane.org>

On 07/10/16 01:48, Brian Masney wrote:
> Fix the following warnings from checkpatch:
> 
> WARNING: DT compatible string "isil,isl29018" appears un-documented --
> check ./Documentation/devicetree/bindings/
> WARNING: DT compatible string "isil,isl29023" appears un-documented --
> check ./Documentation/devicetree/bindings/
> WARNING: DT compatible string "isil,isl29035" appears un-documented --
> check ./Documentation/devicetree/bindings/
> 
> Signed-off-by: Brian Masney <masneyb-1iNe0GrtECGEi8DpZVb4nw@public.gmane.org>
Device tree patches should always be cc'd to the device tree list and
maintainers. (done above).

As this is very simple I'm happy to take it without an Ack from
them (though one would always be welcome and can be added for
a week or so as I'm not pushing this out in a non rebasing tree yet).

Applied to the togreg branch of iio.git - pushed out as testing for
the autobuilders to play with it.

Mark and Rob, just noticed we are down to just the two of you.
Good luck guys and hope you find more assistance soon if you
want it.

Thanks,

Jonathan
> ---
>  .../devicetree/bindings/iio/light/isl29018.txt     | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/isl29018.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> new file mode 100644
> index 0000000..7e53524
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> @@ -0,0 +1,28 @@
> +* ISL 29018/29023/29035 I2C ALS, Proximity, and Infrared sensor
> +
> +Required properties:
> +
> +  - compatible: Should be one of
> +		"isil,isl29018"
> +		"isil,isl29023"
> +		"isil,isl29035"
> +  - reg: the I2C address of the device
> +
> +Optional properties:
> +
> +  - interrupt-parent: should be the phandle for the interrupt controller
> +  - interrupts: the sole interrupt generated by the device
> +
> +  Refer to interrupt-controller/interrupts.txt for generic interrupt client
> +  node bindings.
> +
> +  - vcc-supply: phandle to the regulator that provides power to the sensor.
> +
> +Example:
> +
> +isl29018@44 {
> +	compatible = "isil,isl29018";
> +	reg = <0x44>;
> +	interrupt-parent = <&gpio>;
> +	interrupts = <TEGRA_GPIO(Z, 2) IRQ_TYPE_LEVEL_HIGH>;
> +};
> 

           reply	other threads:[~2016-10-09  8:48 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1475801317-29449-2-git-send-email-masneyb-1iNe0GrtECGEi8DpZVb4nw@public.gmane.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7fe672e-3776-a738-91a2-249f7948d606@kernel.org \
    --to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=Mark.Rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=masneyb-1iNe0GrtECGEi8DpZVb4nw@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).