From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E36E823DD for ; Mon, 10 Jun 2024 15:01:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718031662; cv=none; b=VLUtORn3Bg38AYPmIQ2jYKsCgZkrJcLiDOlch/7PlZPS/McS0Jphf7IgY8gdydYp64upNZiqTM/pbcOEqnLUOkWV1SbkuiuGiwg4BubyB8RY88suqYsG8be1aGc/4WhXeOYtNvWOo5WxvE+hqmb3+eNt/L5Cv3E75VQnM5xR+RU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718031662; c=relaxed/simple; bh=D5KYx4UV0BPcphBF/q1eXrI7Cy6QB56NSIYd+Nl3uDA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JHKkLWvYcn1joWM0EF/xmbluRjwt5x8wlAPFeRf1IyobbaStpMw+ZdyzxSLpB+vq0Vf8nFqAk3/ovP2yNuDKseEX4yh2C4MYHm2n7o23PsmZGDgK2sHzuwrdM3RQVsXgYoaPStoBLkj+py3FtqyzI60JIJbOW7Th1cBQV6zkg2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=m+K3epd/; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m+K3epd/" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a6f0dc80ab9so247583566b.2 for ; Mon, 10 Jun 2024 08:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718031659; x=1718636459; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=r1plcsllFAfR72DMNf9dBiFZimQ3jkBHlFjNsM9boX0=; b=m+K3epd/a71oro4k5NZC2PoiJdAZyvCkac3leWQnai3x8p6zV7UXCfb8jrwS+2CPM5 Gji+CiRmIFGpTZFcf9E2VKK0w84I23m2tvygFgx6u1vnKOr/iMF3p/CwIfXmczAUnaNj QHkzT8oNHCvpvnmMHtJgFklEv/1XujDsHS3HrxbNKevgRuSuSRqaBqFjqHzQHk8wUlhd 1HBS2PtEvu8tP4JpYMqw0JjPeNo3nrPbAjxzYVWeiXcjVLa2GdZrCTgc1ugkZGlms3lm GAXvk2O1s1G29hOOZ65LDy2zBu3IWwvadfjhJw1jyUJmWaWXYuIwf1klWXMiEfuz8RCK CZWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718031659; x=1718636459; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r1plcsllFAfR72DMNf9dBiFZimQ3jkBHlFjNsM9boX0=; b=as+oVIt+/oL7Sa6T1FP7fJhMdwGsPb0234LvMUDepjCvffQiehJAHHC3MSkG5g5w2S MLy9s+F640SnEW0twsF4DzNTo4Np1vn0Poag5P4d6s3zkBUNUbVX5nvYzwzZC/PKiCEg 0PlIz1RP97okE4V3z1jnpp5akwQ3MLpbvgfBJucJdEdTFfGyRREmq0ixDDQlmtsK02MC GgolDJU7EvNKFWF7RZaXamA+xEkMGVeYXyJLiLufZbJQ1kbxjq8ROSLN1r1EHPX5dxNt KHZz6WHlGuUhpo4jxF2k+TDVEMnmWivM5jEh4GG6U3giQA8WLhs5xa/O8KMc/P8VKcqo Rvzw== X-Forwarded-Encrypted: i=1; AJvYcCULvlSO9iOOJU80YHZ1D6dlMrz2Wcn+z5lYXrdgc1UelmAQSeUx/Hbqh8z0Ao9QDQ7Wdm4ODZrPamTXBYW08p9WLSuz7J9BOxuvGA== X-Gm-Message-State: AOJu0YwEdDipnPDOPquWcvyLR00B9ds6mTHQdDeFS3fqTSkmQnBC7lzP y8d9VvuXuQl6rp+3HBCPMpEgSWuORCy4AQxaNJkhgvztpoaKhMcE48DEEAmHGOs= X-Google-Smtp-Source: AGHT+IGS4N0kEO/Hpqa8SDN6T//sm93JIQ7t/nyb8hA/8RdebhYZcjZDId60nW41KUAmTMZihs4X0g== X-Received: by 2002:a17:907:2d89:b0:a6f:d1d:75f4 with SMTP id a640c23a62f3a-a6f0d1d76b4mr399269666b.55.1718031658768; Mon, 10 Jun 2024 08:00:58 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f116dc32fsm272802866b.26.2024.06.10.08.00.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jun 2024 08:00:58 -0700 (PDT) Message-ID: Date: Mon, 10 Jun 2024 17:00:55 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/2] power: pwrseq: add a driver for the PMU module on the QCom WCN chipsets To: Bartosz Golaszewski Cc: Marcel Holtmann , Luiz Augusto von Dentz , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kalle Valo , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Catalin Marinas , Will Deacon , Bjorn Helgaas , Saravana Kannan , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , Marek Szyprowski , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , Abel Vesa , Manivannan Sadhasivam , Lukas Wunner , Dmitry Baryshkov , Amit Pundir , Xilin Wu , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski , Caleb Connolly References: <20240605123850.24857-1-brgl@bgdev.pl> <20240605123850.24857-3-brgl@bgdev.pl> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/06/2024 16:55, Bartosz Golaszewski wrote: > On Mon, Jun 10, 2024 at 4:54 PM Krzysztof Kozlowski > wrote: >> >> On 05/06/2024 14:38, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> This adds the power sequencing driver for the PMU modules present on the >>> Qualcomm WCN Bluetooth and Wifi chipsets. It uses the pwrseq subsystem >>> and knows how to match the sequencer to the consumer device by verifying >>> the relevant properties and DT layout. Using this driver will allow the >>> BT and WLAN drivers to respect the required delays between enabling the >>> two modules. >> >> ... >> >>> + >>> +static const struct of_device_id pwrseq_qcom_wcn_of_match[] = { >>> + { >>> + .compatible = "qcom,qca6390-pmu", >>> + .data = &pwrseq_qca6390_of_data, >> >> Bindings *must* be part of this patchset. I missed the moment this was >> split into such chunks. >> >> Best regards, >> Krzysztof >> > > The bindings are already in next via Mark Brown's tree. OK, I checked linux-next from a day before Mark merged it. Cover letter should mention it, because it is a bit unusual (and would save you reviewer's question). Best regards, Krzysztof