From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sameer Pujar <spujar@nvidia.com>,
broonie@kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, perex@perex.cz,
tiwai@suse.com, kuninori.morimoto.gx@renesas.com
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Add sample format conversion
Date: Thu, 28 Jul 2022 14:22:37 +0200 [thread overview]
Message-ID: <c801afa4-a40d-9363-1ebd-9e8e30c21df5@linaro.org> (raw)
In-Reply-To: <1658931983-31647-2-git-send-email-spujar@nvidia.com>
On 27/07/2022 16:26, Sameer Pujar wrote:
> Presently "convert-channels" and "convert-rate" DT bindings are available
> for channel and rate fixups respectively.
>
> Similarly add "convert-sample-format" binding to fixup DAI sample format
> as well. This is added to simple-card and audio-graph based sound cards.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> .../devicetree/bindings/sound/audio-graph-port.yaml | 21 +++++++++++++++++++++
> .../devicetree/bindings/sound/audio-graph.yaml | 11 +++++++++++
> .../devicetree/bindings/sound/simple-card.yaml | 15 +++++++++++++++
> 3 files changed, 47 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> index 5c36867..d7491038 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> @@ -24,6 +24,17 @@ properties:
> convert-channels:
> description: CPU to Codec rate channels.
> $ref: /schemas/types.yaml#/definitions/uint32
Missing blank line.
> + convert-sample-format:
> + description: CPU to Codec sample format.
> + Value Format
> + 0 S8
> + 2 S16_LE
> + 6 S24_LE
> + 10 S32_LE
> + 32 S24_3LE
Why some random set of integers? Just use string, must more descriptive
and you do not embed programming model to DT... unless there is some
reason for this approach?
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [0, 2, 6, 10, 32]
> +
> patternProperties:
> "^endpoint(@[0-9a-f]+)?":
> $ref: /schemas/graph.yaml#/$defs/endpoint-base
> @@ -70,6 +81,16 @@ patternProperties:
> convert-channels:
> description: CPU to Codec rate channels.
> $ref: /schemas/types.yaml#/definitions/uint32
Ditto
> + convert-sample-format:
> + description: CPU to Codec sample format.
> + Value Format
> + 0 S8
> + 2 S16_LE
> + 6 S24_LE
> + 10 S32_LE
> + 32 S24_3LE
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [0, 2, 6, 10, 32]
Ditto
>
> dai-tdm-slot-width-map:
> description: Mapping of sample widths to slot widths. For hardware
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph.yaml b/Documentation/devicetree/bindings/sound/audio-graph.yaml
> index 4b46794..df8a994 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph.yaml
> @@ -32,6 +32,17 @@ properties:
> convert-channels:
> description: CPU to Codec rate channels.
> $ref: /schemas/types.yaml#/definitions/uint32
Ditto
> + convert-sample-format:
> + description: CPU to Codec sample format.
> + Value Format
> + 0 S8
> + 2 S16_LE
> + 6 S24_LE
> + 10 S32_LE
> + 32 S24_3LE
Ditto
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [0, 2, 6, 10, 32]
> +
> pa-gpios:
> maxItems: 1
> hp-det-gpio:
> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
> index b261d49..6decd73 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
> @@ -77,6 +77,17 @@ definitions:
> description: CPU to Codec rate channels.
> $ref: /schemas/types.yaml#/definitions/uint32
>
> + convert-sample-format:
> + description: CPU to Codec sample format.
> + Value Format
> + 0 S8
> + 2 S16_LE
> + 6 S24_LE
> + 10 S32_LE
> + 32 S24_3LE
> + $ref: /schemas/types.yaml#/definitions/uint32
Wait, you now put the same property in four different places. Don't you
have something which could be shared?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-28 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 14:26 [PATCH 0/2] DT binding for sample format conversion Sameer Pujar
2022-07-27 14:26 ` [PATCH 1/2] ASoC: dt-bindings: Add " Sameer Pujar
2022-07-28 12:22 ` Krzysztof Kozlowski [this message]
2022-07-29 4:11 ` Sameer Pujar
2022-08-02 7:29 ` Krzysztof Kozlowski
2022-07-27 14:26 ` [PATCH 2/2] ASoC: simple-card-utils: Fixup DAI sample format Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c801afa4-a40d-9363-1ebd-9e8e30c21df5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).