From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6FDC7EE23 for ; Mon, 8 May 2023 10:25:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234570AbjEHKZe (ORCPT ); Mon, 8 May 2023 06:25:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234550AbjEHKZM (ORCPT ); Mon, 8 May 2023 06:25:12 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7951C3AA37 for ; Mon, 8 May 2023 03:24:40 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4f14ec4efb0so2753123e87.2 for ; Mon, 08 May 2023 03:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683541479; x=1686133479; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a5b1axjYU7Z/HNBec4s202rAT9q9NaOrWGm5FGLB+aw=; b=k59HEF9KgCyRMJijY/SXi9N5BvmCqLx8yvuPRnMUFWGKgZotfMQN/DOwvVfSGCYF6S szXjAmKkkgfE1PXwZPhFEOADyX+f+B8MayikFS6sAJ33PG8PP4H6IcvIOwpTtxwJjziW UyBhX1qWMQLaA6CtAgsiXAMl6KLgTQm+WQWFrLVi5QxbnQMk2eTlgQsU8TReNNvUUWfv R8efMG2+yLahW79xSbl4Yh2MV1asVHQr1fm9CLUMjiLPsMawkKDYwnB+2KgyOBD6SWYq rrMAbGT5CB37GRHYEGbJHD16LeyjN0vPwbbyBA6t8G2HXcM+GeHUEKmxBik/hsoNFLAQ 8M1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683541479; x=1686133479; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a5b1axjYU7Z/HNBec4s202rAT9q9NaOrWGm5FGLB+aw=; b=lCvCXaIRnPRdYYA4UrEIOK4dijd6w1ae6iphSxzrAZyt/9H51QW/vzqbvHN7sAjHfm f5CtU+Pm1dFqzun5Yax5LsbN31ypt1ILnUSZ7O0Me8wv7IN/WQkACenjOJFWjUihHihu QRk2gJ6fcIixezjVBtetYvDZrz+PUKTJsimHzPyCgSkfAxjHIb3kkGnvog5CKuKI2DwJ 5lF/QkXVJf0pcl/UmJRd9DcrcE2zabcUvjkTty/vI/HKlzJgqmQrmyZS4u3tuoroDNb7 Fgh64GQaCYDnfowwq86rmS+IGi2Jv8VxU/6haACtJjj3whaa/JlSuVSe+cqJwXUzfYNW DkMg== X-Gm-Message-State: AC+VfDx0s31wLIYGgpjgyh+E1s5fH7xhuNAuIYJa8uVhEtReSMBAdi6y pCQtcLBaMSj7LaePd9PmKZhC4w== X-Google-Smtp-Source: ACHHUZ6QzaiyYn3670VJ6ShRWtlutGRBQcW/dmwm/vOzt1VCah6EWHn7rTSuj+AKFTcnAmhna1lsfQ== X-Received: by 2002:ac2:4831:0:b0:4ef:fed9:8eed with SMTP id 17-20020ac24831000000b004effed98eedmr2554217lft.30.1683541478740; Mon, 08 May 2023 03:24:38 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id b3-20020ac25623000000b004edd490cf77sm1248895lff.275.2023.05.08.03.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 03:24:38 -0700 (PDT) Message-ID: Date: Mon, 8 May 2023 13:24:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU Content-Language: en-GB To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski Cc: Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20230507190735.2333145-1-dmitry.baryshkov@linaro.org> <20230507190735.2333145-2-dmitry.baryshkov@linaro.org> <8cdecc51-2a42-4b82-9eb3-2ab77860c5d4@linaro.org> From: Dmitry Baryshkov In-Reply-To: <8cdecc51-2a42-4b82-9eb3-2ab77860c5d4@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/05/2023 11:30, Konrad Dybcio wrote: > > > On 7.05.2023 21:07, Dmitry Baryshkov wrote: >> To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be >> enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards. >> >> Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support") >> Signed-off-by: Dmitry Baryshkov >> --- > Uhh.. this clock should be managed by RPM with: > > type = MEM > id = 2 > > just like it's defined for 8994 today. > > Could you try adding it in rpmcc and confirming? There is an RPM_SMD_OCMEMGX_CLK clk already, it is a bus clock for the ocmemnoc. > > Konrad >> arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi >> index 834ad95515b1..fb661c1bd3d5 100644 >> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi >> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi >> @@ -2104,8 +2104,9 @@ gpu: adreno@fdb00000 { >> >> clocks = <&mmcc OXILI_GFX3D_CLK>, >> <&mmcc OXILICX_AHB_CLK>, >> + <&mmcc OXILI_OCMEMGX_CLK>, >> <&mmcc OXILICX_AXI_CLK>; >> - clock-names = "core", "iface", "mem_iface"; >> + clock-names = "core", "iface", "mem", "mem_iface"; >> >> sram = <&gmu_sram>; >> power-domains = <&mmcc OXILICX_GDSC>; -- With best wishes Dmitry