From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m15572.qiye.163.com (mail-m15572.qiye.163.com [101.71.155.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787802AE8E; Wed, 16 Jul 2025 01:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752631013; cv=none; b=TbFzbBR0x/RAzzNlR5lIHOkwJlGGjO7W1mVSKuR/rXHNSnw/WxiP7lbSkyy3Ex0dEE2KgXZAlveA2p6+5lt0QRX1SH/VgR6q4dxlSaTf/MY1lhYBGCGPtQwtUCkrH30Ly5J0ktd5TIzOR+CYlIFY9UqrepbgRpuXvdgOk9fsooQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752631013; c=relaxed/simple; bh=e9lUDbvdgYncphaWPprUaZQ6Mg/HpQCIuNBWvPgCjzY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jx/6cYSORDcDltEjq0SBRsIz0n+gLv++Fl/j+eiarJC3h6MkaFlNm3n9El2kvONdopZsx6ibgGsfwVt6FEPOxp1Zt0YnfLzLLWJcFcyoxMaiOjV72sRiY6xTmzyZW91+5sX84ocEdIRthNp8L0KwJoba8S68NzCcva7Eeuk2z0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=W0jW9R03; arc=none smtp.client-ip=101.71.155.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="W0jW9R03" Received: from [127.0.0.1] (gy-adaptive-ssl-proxy-4-entmail-virt151.gy.ntes [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 1c22589b7; Wed, 16 Jul 2025 09:56:28 +0800 (GMT+08:00) Message-ID: Date: Wed, 16 Jul 2025 09:56:27 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] phy: rockchip: phy-rockchip-typec: Add support for Type-C TCPM To: Dmitry Baryshkov , Chaoyi Chen Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Greg Kroah-Hartman , Dragan Simic , Johan Jonker , Diederik de Haas , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org References: <20250715112456.101-1-kernel@airkyi.com> <20250715112456.101-4-kernel@airkyi.com> From: Chaoyi Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQkgYH1ZMGk9MGh0fHhlJH0xWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSUhCS0 NVSktLVUpCWQY+ X-HM-Tid: 0a9810f28ea703abkunm90ac2de114329c6 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Pkk6PAw6TzE0CQkqHyMaKTwO FCMwFBxVSlVKTE5JTUhLQkJDTExNVTMWGhIXVRgTGhQCElUYEx4VOwkUGBBWGBMSCwhVGBQWRVlX WRILWUFZTkNVSUlVTFVKSk9ZV1kIAVlBSUNNTDcG DKIM-Signature:a=rsa-sha256; b=W0jW9R03pDXvYvm3Rcj4D/OVXpsMGGUD4uR1EzjGrfUvJ1jREzszZ3UvHu9fA4hJSWutBZqokl4p7J5EL4BskBgoitkLIFthMM+EJ1eWoL5y4pjR+pSdm4P3can6FI5v2Cx7gxWVhXUR4sdLwXNQPCr29lZXHdhlnt5R7jcGTaA=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=jn0hRWbIM6rr6NocmrIeQ0wNYnfckKljpY3FeBK/+iY=; h=date:mime-version:subject:message-id:from; Hi Dmitry, On 2025/7/15 20:05, Dmitry Baryshkov wrote: > On Tue, Jul 15, 2025 at 07:24:54PM +0800, Chaoyi Chen wrote: >> From: Chaoyi Chen >> >> This patch add support for Type-C Port Controller Manager. >> The extcon device should still be supported. >> >> Signed-off-by: Chaoyi Chen >> --- >> drivers/phy/rockchip/phy-rockchip-typec.c | 335 ++++++++++++++++++++-- >> 1 file changed, 319 insertions(+), 16 deletions(-) > Please keep TCPM implementation under drivers/usb/typec/tcpm/ . Create > an aux device and write an aux driver for the TCPM part. Sorry, the commit messages may not be described accurately enough. This patch adds mux/switch operations to the PHY driver to improve communication with the TCPM framework. Since this PHY is a combo USB/DP PHY, it requires configuration changes to the PHY lanes based on the USB-C  plug orientation (CC logic), similar to the existing extcon mechanism implementation. Of course, the original extcon functionality will remain fully compatible.