Re: [PATCH v2 6/6] arm64: dts: rockchip: add px30-pp1516 base dtsi and board variants

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Heiko,

On 5/13/25 5:02 PM, Heiko Stuebner wrote:

[...]

> +	rk809: pmic@20 {
> +		compatible = "rockchip,rk809";
> +		reg = <0x20>;
> +		#clock-cells = <0>;
> +		clock-output-names = "xin32k";
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pmic_int>;
> +		wakeup-source;
> +		system-power-controller;
> +

Please order alphabetically here.

[...]

> +&pinctrl {
> +	camera {
> +		accel_int: accel-int {
> +			rockchip,pins = <2 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +

The accelerometer is not in the camera module like some of our other 
products, but on the PCBA directly, so I would put it in a different 
section in the pinctrl node.

Can you have it this way too:

rockchip,pins =
         <2 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>;

so it is consistent with the other ones?

[...]

> +	panel {
> +		dsp_rst: dsp-rst {
> +			rockchip,pins =
> +				<0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;

Same remark as for Cobra, I assume we want a pull down here, to keep in 
reset until the driver probe drives the pin to orchestrate the reset?

With all the above changed:

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin