From: <Conor.Dooley@microchip.com>
To: <Nagasuresh.Relli@microchip.com>, <broonie@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<Conor.Dooley@microchip.com>
Cc: <linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] spi: dt-binding: add Microchip CoreQSPI compatible
Date: Tue, 2 Aug 2022 09:12:41 +0000 [thread overview]
Message-ID: <c855b6db-361a-23b7-baa8-a8a447baa284@microchip.com> (raw)
In-Reply-To: <20220802070518.855951-2-nagasuresh.relli@microchip.com>
On 02/08/2022 08:05, Naga Sureshkumar Relli wrote:
> Add compatible string for Microchip CoreQSPI controller.
>
> Signed-off-by: Naga Sureshkumar Relli <nagasuresh.relli@microchip.com>
> ---
> .../devicetree/bindings/spi/microchip,mpfs-spi.yaml | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index 7326c0a28d16..8d252eb8c460 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -14,9 +14,15 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - microchip,mpfs-spi
> - - microchip,mpfs-qspi
> + oneOf:
> + - description: Microchip's Polarfire SoC QSPI controller.
As per Krzk on v1, the descriptions should be dropped.
https://lore.kernel.org/linux-spi/6d36b192-9e63-ec13-5583-22b81c99c18b@linaro.org/
> + items:
> + - const: microchip,mpfs-qspi
> + - const: microchip,coreqspi-rtl-v2
> + - description: Microchip's fabric based QSPI IP core
> + const: microchip,coreqspi-rtl-v2
> + - description: Microchip's Polarfire SoC SPI controller.
> + const: microchip,mpfs-spi
>
> reg:
> maxItems: 1
next prev parent reply other threads:[~2022-08-02 9:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 7:05 [PATCH v2 0/3] Add support for Microchip QSPI controller Naga Sureshkumar Relli
2022-08-02 7:05 ` [PATCH v2 1/3] spi: dt-binding: add Microchip CoreQSPI compatible Naga Sureshkumar Relli
2022-08-02 9:12 ` Conor.Dooley [this message]
2022-08-02 10:25 ` Krzysztof Kozlowski
2022-08-02 12:10 ` naga sureshkumar
2022-08-02 7:05 ` [PATCH v2 2/3] spi: microchip-core-qspi: Add support for microchip fpga qspi controllers Naga Sureshkumar Relli
2022-08-02 9:31 ` Conor.Dooley
2022-08-02 10:25 ` Krzysztof Kozlowski
2022-08-02 12:25 ` naga sureshkumar
2022-08-02 7:05 ` [PATCH v2 3/3] MAINTAINERS: add qspi to Polarfire SoC entry Naga Sureshkumar Relli
2022-08-02 9:13 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c855b6db-361a-23b7-baa8-a8a447baa284@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Nagasuresh.Relli@microchip.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).