From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
- <patches@opensource.cirrus.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: wlf,wm8994: Convert to dtschema
Date: Wed, 8 Feb 2023 20:37:22 +0100 [thread overview]
Message-ID: <c876f40a-2db5-eb50-9706-3147671ec4c5@linaro.org> (raw)
In-Reply-To: <Y+PlUtAmbl5TJq6z@sirena.org.uk>
On 08/02/2023 19:09, Mark Brown wrote:
>
>>> Are you *sure* they are grounded and not supplied from the LDOs?
>
>> That's what I have on schematics (attached), if I got it right.
>
> You'll notice that they've got decoupling caps on rather than being
> grounded - there's an internal connection to the LDO output so if the
> LDOs are in use that's all that's required, while if the LDOs are not in
> use for some reason then an external supply is connected there.
Yes, indeed, not grounded. I'll rephrase the commit. I also found few
other differences needed:
1. AVDD2 should be always required,
2. LDO2VDD exists on WM8994.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-08 19:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 17:25 [PATCH] ASoC: dt-bindings: wlf,wm8994: Convert to dtschema Krzysztof Kozlowski
2023-02-08 17:39 ` Mark Brown
2023-02-08 17:50 ` Krzysztof Kozlowski
2023-02-08 18:09 ` Mark Brown
2023-02-08 19:37 ` Krzysztof Kozlowski [this message]
2023-02-08 19:58 ` Mark Brown
2023-02-08 17:57 ` Krzysztof Kozlowski
2023-02-08 18:46 ` Rob Herring
2023-02-08 19:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c876f40a-2db5-eb50-9706-3147671ec4c5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).