* [PATCH v3] dt-bindings: opp: Allow multi-worded OPP entry names
@ 2021-10-24 21:57 Dmitry Osipenko
2021-10-25 5:49 ` Viresh Kumar
2021-10-27 21:19 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Osipenko @ 2021-10-24 21:57 UTC (permalink / raw)
To: Viresh Kumar, Stephen Boyd, Nishanth Menon, Rob Herring,
David Heidelberg, Thierry Reding, Jonathan Hunter
Cc: linux-kernel, linux-pm, devicetree, linux-tegra
Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP
tables use multi-word names where first part is freq and second voltage
because different hardware versions use different voltages for the same
freqs. Allow OPP entry to have multi-worded name separated by hyphen.
This silences DT checker warnings about wrong naming scheme.
Reviewed-by: David Heidelberg <david@ixit.cz>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
Changelog:
v3: - Viresh Kumar suggested that we shouldn't support postfix variant.
I dropped variant with postfix naming scheme and multi-wording
support of table names.
v2: - In addition to a multi-wording support, support of the postfix
*-opp-table naming scheme is added to the updated pattern.
Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
index ae3ae4d39843..f79343960539 100644
--- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
+++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
@@ -33,7 +33,7 @@ properties:
type: boolean
patternProperties:
- '^opp-?[0-9]+$':
+ '^opp(-[0-9]+)*$':
type: object
description:
One or more OPP nodes describing voltage-current-frequency combinations.
--
2.33.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3] dt-bindings: opp: Allow multi-worded OPP entry names
2021-10-24 21:57 [PATCH v3] dt-bindings: opp: Allow multi-worded OPP entry names Dmitry Osipenko
@ 2021-10-25 5:49 ` Viresh Kumar
2021-10-27 21:19 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2021-10-25 5:49 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Viresh Kumar, Stephen Boyd, Nishanth Menon, Rob Herring,
David Heidelberg, Thierry Reding, Jonathan Hunter, linux-kernel,
linux-pm, devicetree, linux-tegra
On 25-10-21, 00:57, Dmitry Osipenko wrote:
> Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP
> tables use multi-word names where first part is freq and second voltage
> because different hardware versions use different voltages for the same
> freqs. Allow OPP entry to have multi-worded name separated by hyphen.
> This silences DT checker warnings about wrong naming scheme.
>
> Reviewed-by: David Heidelberg <david@ixit.cz>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>
> Changelog:
>
> v3: - Viresh Kumar suggested that we shouldn't support postfix variant.
> I dropped variant with postfix naming scheme and multi-wording
> support of table names.
>
> v2: - In addition to a multi-wording support, support of the postfix
> *-opp-table naming scheme is added to the updated pattern.
>
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index ae3ae4d39843..f79343960539 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -33,7 +33,7 @@ properties:
> type: boolean
>
> patternProperties:
> - '^opp-?[0-9]+$':
> + '^opp(-[0-9]+)*$':
> type: object
> description:
> One or more OPP nodes describing voltage-current-frequency combinations.
LGTM, will apply once Rob Acks it.
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] dt-bindings: opp: Allow multi-worded OPP entry names
2021-10-24 21:57 [PATCH v3] dt-bindings: opp: Allow multi-worded OPP entry names Dmitry Osipenko
2021-10-25 5:49 ` Viresh Kumar
@ 2021-10-27 21:19 ` Rob Herring
2021-10-28 21:12 ` Dmitry Osipenko
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2021-10-27 21:19 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Viresh Kumar, Stephen Boyd, Nishanth Menon, David Heidelberg,
Thierry Reding, Jonathan Hunter, linux-kernel, linux-pm,
devicetree, linux-tegra
On Mon, Oct 25, 2021 at 12:57:18AM +0300, Dmitry Osipenko wrote:
> Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP
> tables use multi-word names where first part is freq and second voltage
> because different hardware versions use different voltages for the same
> freqs. Allow OPP entry to have multi-worded name separated by hyphen.
> This silences DT checker warnings about wrong naming scheme.
>
> Reviewed-by: David Heidelberg <david@ixit.cz>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>
> Changelog:
>
> v3: - Viresh Kumar suggested that we shouldn't support postfix variant.
> I dropped variant with postfix naming scheme and multi-wording
> support of table names.
>
> v2: - In addition to a multi-wording support, support of the postfix
> *-opp-table naming scheme is added to the updated pattern.
>
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index ae3ae4d39843..f79343960539 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -33,7 +33,7 @@ properties:
> type: boolean
>
> patternProperties:
> - '^opp-?[0-9]+$':
> + '^opp(-[0-9]+)*$':
This drops support for cases like 'opp1' which there are a ton of. It
should be '^opp(-?[0-9]+)*$' if we want to keep that support.
I'd love to be stricter, but trying to find a balance.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] dt-bindings: opp: Allow multi-worded OPP entry names
2021-10-27 21:19 ` Rob Herring
@ 2021-10-28 21:12 ` Dmitry Osipenko
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Osipenko @ 2021-10-28 21:12 UTC (permalink / raw)
To: Rob Herring
Cc: Viresh Kumar, Stephen Boyd, Nishanth Menon, David Heidelberg,
Thierry Reding, Jonathan Hunter, linux-kernel, linux-pm,
devicetree, linux-tegra
28.10.2021 00:19, Rob Herring пишет:
> On Mon, Oct 25, 2021 at 12:57:18AM +0300, Dmitry Osipenko wrote:
>> Not all OPP entries fit into a single word. In particular NVIDIA Tegra OPP
>> tables use multi-word names where first part is freq and second voltage
>> because different hardware versions use different voltages for the same
>> freqs. Allow OPP entry to have multi-worded name separated by hyphen.
>> This silences DT checker warnings about wrong naming scheme.
>>
>> Reviewed-by: David Heidelberg <david@ixit.cz>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>
>> Changelog:
>>
>> v3: - Viresh Kumar suggested that we shouldn't support postfix variant.
>> I dropped variant with postfix naming scheme and multi-wording
>> support of table names.
>>
>> v2: - In addition to a multi-wording support, support of the postfix
>> *-opp-table naming scheme is added to the updated pattern.
>>
>> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> index ae3ae4d39843..f79343960539 100644
>> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>> @@ -33,7 +33,7 @@ properties:
>> type: boolean
>>
>> patternProperties:
>> - '^opp-?[0-9]+$':
>> + '^opp(-[0-9]+)*$':
>
> This drops support for cases like 'opp1' which there are a ton of. It
> should be '^opp(-?[0-9]+)*$' if we want to keep that support.
>
> I'd love to be stricter, but trying to find a balance.
Good catch, let me make v4.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-28 21:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-24 21:57 [PATCH v3] dt-bindings: opp: Allow multi-worded OPP entry names Dmitry Osipenko
2021-10-25 5:49 ` Viresh Kumar
2021-10-27 21:19 ` Rob Herring
2021-10-28 21:12 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).