From: Christophe ROULLIER <christophe.roullier@foss.st.com>
To: Ben Wolsieffer <ben.wolsieffer@hefring.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Richard Cochran <richardcochran@gmail.com>,
Jose Abreu <joabreu@synopsys.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 08/12] net: ethernet: stmmac: stm32: support the phy-supply regulator binding
Date: Thu, 5 Oct 2023 13:27:18 +0200 [thread overview]
Message-ID: <c8804fbe-46e7-2771-e503-4e786df2f97c@foss.st.com> (raw)
In-Reply-To: <ZRWfhk0aEDwytGv5@dell-precision-5540>
On 9/28/23 17:45, Ben Wolsieffer wrote:
> Hello,
>
> On Thu, Sep 28, 2023 at 05:15:08PM +0200, Christophe Roullier wrote:
>> From: Christophe Roullier <christophe.roullier@st.com>
>>
>> Configure the phy regulator if defined by the "phy-supply" DT phandle.
>>
>> Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com>
>> ---
>> .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 51 ++++++++++++++++++-
>> 1 file changed, 50 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
>> index 72dda71850d75..31e3abd2caeaa 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
> ... snip ...
>> static int stm32mp1_suspend(struct stm32_dwmac *dwmac)
>> @@ -455,12 +496,20 @@ static int stm32mp1_suspend(struct stm32_dwmac *dwmac)
>> if (dwmac->enable_eth_ck)
>> clk_disable_unprepare(dwmac->clk_eth_ck);
>>
>> + /* Keep the PHY up if we use Wake-on-Lan. */
>> + if (!device_may_wakeup(dwmac->dev))
>> + phy_power_on(dwmac, false);
>> +
>> return ret;
>> }
>>
>> static void stm32mp1_resume(struct stm32_dwmac *dwmac)
>> {
>> clk_disable_unprepare(dwmac->clk_ethstp);
>> +
>> + /* The PHY was up for Wake-on-Lan. */
>> + if (!device_may_wakeup(dwmac->dev))
>> + phy_power_on(dwmac, true);
>> }
>>
>> static int stm32mcu_suspend(struct stm32_dwmac *dwmac)
> Why only turn off the regulator in suspend on the STM32MP1 and not STM32
> MCUs? It seems like this could just go in stm32_dwmac_suspend/resume().
>
> Selfishly, I have a use case for this on an STM32F746 platform, so I
> would like to see support for it and would test an updated version.
>
Hi,
I'm working on MPU boards, I do not have MCU board, so feel free to
contribute on MCU part ;-)
Thanks
Christophe
>> --
>> 2.25.1
>>
> Thanks, Ben
next prev parent reply other threads:[~2023-10-05 14:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 15:15 [PATCH v3 00/12] Series to deliver Ethernets for STM32MP13 Christophe Roullier
2023-09-28 15:15 ` [PATCH v3 01/12] dt-bindings: net: add STM32MP13 compatible in documentation for stm32 Christophe Roullier
2023-09-28 20:39 ` Conor Dooley
2023-09-30 15:46 ` Krzysztof Kozlowski
2023-09-28 15:15 ` [PATCH v3 02/12] dt-bindings: net: add new property st,ext-phyclk " Christophe Roullier
2023-09-28 17:17 ` Conor Dooley
2023-10-05 9:03 ` Christophe ROULLIER
2023-10-06 9:30 ` Conor Dooley
2023-09-28 15:15 ` [PATCH v3 03/12] dt-bindings: net: add phy-supply property " Christophe Roullier
2023-09-28 17:14 ` Conor Dooley
2023-09-28 15:15 ` [PATCH v3 04/12] net: ethernet: stmmac: rework glue to simplify management for next stm32 Christophe Roullier
2023-09-28 15:15 ` [PATCH v3 05/12] net: ethernet: stmmac: add management of stm32mp13 for stm32 Christophe Roullier
2023-09-28 15:15 ` [PATCH v3 06/12] net: ethernet: stmmac: stm32: update config management for phy wo cristal Christophe Roullier
2023-09-28 15:15 ` [PATCH v3 07/12] net: ethernet: stm32: clean the way to manage wol irqwake Christophe Roullier
2023-09-28 15:15 ` [PATCH v3 08/12] net: ethernet: stmmac: stm32: support the phy-supply regulator binding Christophe Roullier
2023-09-28 15:45 ` Ben Wolsieffer
2023-10-05 11:27 ` Christophe ROULLIER [this message]
2023-10-06 11:53 ` Alexandre TORGUE
2023-09-28 15:15 ` [PATCH v3 09/12] ARM: dts: stm32: add ethernet1 and ethernet2 support on stm32mp13 Christophe Roullier
2023-09-28 15:15 ` [PATCH v3 10/12] ARM: dts: stm32: add ethernet1/2 RMII pins for STM32MP13F-DK board Christophe Roullier
2023-09-28 15:15 ` [PATCH v3 11/12] ARM: dts: stm32: add ethernet1 and ethernet2 for STM32MP135F-DK board Christophe Roullier
2023-09-28 15:15 ` [PATCH v3 12/12] ARM: multi_v7_defconfig: Add MCP23S08 pinctrl support Christophe Roullier
2023-09-28 18:00 ` [PATCH v3 00/12] Series to deliver Ethernets for STM32MP13 Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8804fbe-46e7-2771-e503-4e786df2f97c@foss.st.com \
--to=christophe.roullier@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=ben.wolsieffer@hefring.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).