From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C075A18734A for ; Mon, 17 Jun 2024 07:16:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718608594; cv=none; b=QS92+Mpdaa4RjI1Obz8IEufHoq5NT20lrBU3L71N1VzOS6jux6Hjus3Sm9XeWqefADeWfZbQX8jDXKzdX3cxZ0JmHnRapRDecntt7Z8tiKuJ5jyRQsrHvQ/ICff8GAcs8U7tDIyHZ6c3e8HHIEBzT7q1YKam+5Wks0MJTxQHRSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718608594; c=relaxed/simple; bh=bPW+cY98TVGEQ8oYbU5+kTB5r2TuPe/4Gj4MB1VB0zg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EPuHbc98XJuEA4Ca2roJ5sIyiaL7U7ALQV1TPKjgdX0FF3ygDT36dyI7UgE/Hgx7kiCcsRGTpzjU5gLf/A58FZYp+75QiRac8KHVH9vyUsF7VgMLvo7Eb+CZhOlSrZw6y2TUYroM2VZepiye9wfUo5lRV90Xlz7xexo22U3Qw60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=qInNYKXm; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="qInNYKXm" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2ebeefb9a7fso55613681fa.0 for ; Mon, 17 Jun 2024 00:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1718608590; x=1719213390; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gOtB6hLjDe2q1k9n9j8GrerUfufcZavMvVvl5T64NeQ=; b=qInNYKXmUySA4K0m8LtV38DyPSDUkYGLMqol4vqFb88MpFuep57Wy6s59OmVGIrTJK K6ljKXYq2ZtceNnnHBcN1lgR6BIjpZMuCpRI3W+oFZaLgZOj/DYjeVi+eOdafjp8lm+H mJMT2fQYtf9mJu+eReVr2PB4a90f/7cmvkQG4i1VnVv82OJLTpUHtEKG7bkyMfhfe0Dv aAacgr4Z40cyPpMrZHtXAFVIHBdURY+hGJCyqd89W4ql4MssiQfh6pJLSzq4rq2Dr0YL lOJ03rVV111VVij1AP3I4MKBpTV3IG0cg8EiXimG8nzQ9RypILkNWUyRT/bPmdrUbn8W 1ldA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718608590; x=1719213390; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gOtB6hLjDe2q1k9n9j8GrerUfufcZavMvVvl5T64NeQ=; b=Yh0Nzv+tLsbuqaV+Mg9dzSh1iAZHS0o0XnHn9m9Mf82kqgkd6ZdHInND8YaywfPu8a 8BN42bD5ZlehFAuCuwkzCLQ3d1dWYjoVcz+1C92AjCSbVih4H03/mveIShb+7QU6yny1 uqmilpHxDJm26rjCq7M4uuUTQKo+FDv3wQKNrG+pFFtgZ0klXDZ2m4l0fBJEJykIs9pd Eq/kAXjT8yPOpUL3qaNGk4pwNHSVmkEJAgLn+S9Gr4oc3mZt1GjqI0WSa85QZcp/mVX+ C7hg0kPO5XFkaqCzt1jJBlLzxA3uf6SCJoVWo97uSrzdD0KhXYyP57QV/Kt72pb0zMps GY1Q== X-Forwarded-Encrypted: i=1; AJvYcCXmarLiWiUZIelQWKb/+wADI1sKnVaPRIsrgpAsHJmpZC88w3gxEHi0+8kZKsPJ4nnwh5hZzE7B2Dor3QlwBV2Mh7ZIo9f5V5HrjQ== X-Gm-Message-State: AOJu0Yy/5OtJv9YgR8I9otVGchS0jeI+YziK97MqeIINY3t3ryo/bOAw 3Kc0owhREPSRWdXqG07pH3stV+UJdqjZloldLs85YDOLJRe1xtGMpoEsiGdkqNw= X-Google-Smtp-Source: AGHT+IHlanuvFDHlcHk0QHuwXweE3e5izwPD+BY+hJiW1cVcoATK8SU76Wd3c4dYNArqQvVGdfRmkA== X-Received: by 2002:a2e:a0d0:0:b0:2ec:30cd:fd7a with SMTP id 38308e7fff4ca-2ec30cdfe89mr4497991fa.49.1718608589940; Mon, 17 Jun 2024 00:16:29 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-360750acf32sm11244173f8f.49.2024.06.17.00.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 00:16:29 -0700 (PDT) Message-ID: Date: Mon, 17 Jun 2024 10:16:22 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/12] dt-bindings: mfd: renesas,rzg3s-vbattb: Document VBATTB Content-Language: en-US To: Krzysztof Kozlowski , geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, alexandre.belloni@bootlin.com, magnus.damm@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea References: <20240614071932.1014067-1-claudiu.beznea.uj@bp.renesas.com> <20240614071932.1014067-4-claudiu.beznea.uj@bp.renesas.com> <936beb9a-2701-476c-8f5a-4b6b06d4f87d@kernel.org> From: claudiu beznea In-Reply-To: <936beb9a-2701-476c-8f5a-4b6b06d4f87d@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16.06.2024 10:38, Krzysztof Kozlowski wrote: > On 14/06/2024 09:19, Claudiu wrote: >> From: Claudiu Beznea > >> + >> +maintainers: >> + - Claudiu Beznea >> + >> +properties: >> + compatible: >> + items: >> + - const: renesas,rzg3s-vbattb >> + - const: syscon >> + - const: simple-mfd > > No, mfd does no look good. That's not a simple device anymore and you > claim here child does not need vbat bclk, power domains and resets? That > would be a big surprise, although technically possible. I wasn't sure how this MFD will be received by the Renesas maintainers so I kept it simple for this version. In theory the VBAT clk, power domain and resets are specific to VBAT module itself but, indeed, the child cannot work w/o these. > > Please clarify: which of parent resources are needed for children? VBAT clock, power domain are needed. Reset, too. In the current implementation the reset is deasserted though parent by calling the syscon_node_to_regmap(np->parent) in the clock driver. > > ... > >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + vbattb: vbattb@1005c000 { >> + compatible = "renesas,rzg3s-vbattb", "syscon", "simple-mfd"; >> + reg = <0x1005c000 0x1000>; >> + ranges = <0 0 0x1005c000 0 0x1000>; >> + interrupts = ; >> + interrupt-names = "tampdi"; >> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>; >> + clock-names = "bclk"; >> + power-domains = <&cpg>; >> + resets = <&cpg R9A08G045_VBAT_BRESETN>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + status = "disabled"; > > Drop Could you please clarify this? Would you want me to drop the full node (same for clock-controller node)? Can you point me an example that you are thinking about? Thank you, Claudiu Beznea > >> + >> + vbattclk: clock-controller@1c { >> + compatible = "renesas,rzg3s-vbattb-clk"; >> + reg = <0 0x1c 0 0x10>; >> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb_xtal>; >> + clock-names = "bclk", "vbattb_xtal"; >> + #clock-cells = <0>; >> + power-domains = <&cpg>; >> + status = "disabled"; > > Drop > >> + }; >> + }; >> + >> +... > > Best regards, > Krzysztof >