From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCEEAC433FE for ; Sat, 29 Oct 2022 22:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229682AbiJ2WHq (ORCPT ); Sat, 29 Oct 2022 18:07:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbiJ2WHo (ORCPT ); Sat, 29 Oct 2022 18:07:44 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EEE633845 for ; Sat, 29 Oct 2022 15:07:43 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id u11so12515562ljk.6 for ; Sat, 29 Oct 2022 15:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kH0QVpvpb7zwsERmRHshEbzMpFPeVcyeSJAaIxfPmeA=; b=knwXWXI35Z9QHYg/HnqH+NOaEsQ5qMooSHtXrI7QvPMaaQpqlQjkHkKtAVsUzOdF6a lzY0X4nhgD7dwm2bVd+DbOB2m3bBWI0NJ+g6TCgNqdBHkCOCt8eVTrv3sWjAIsvVpgOB grO3Ebm7UpPd1BQLIxiZQKCGfhcouUyWdwRKVYyaVahrS5H+cxCZjFgqRoO2gVRmCE9x pjIcztC2FaUpAyIg6J+QqUeAcOwwcdwfU3UnlQKIhWtg0+Wfr0SXtqCytqJWel+ENGXW hqSov814BZCkfEMrZ51GiQTde/ASWWydCPCDu8ZfHP5BRj1F/mTdw1Y9Rq2+5qnm/DKJ O6NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kH0QVpvpb7zwsERmRHshEbzMpFPeVcyeSJAaIxfPmeA=; b=shh1dPgk06z2tbZIh7iEQbs1DPuzTl2UCNF590arLDFvfUfaaOjARUUyyp23xmpDXS BvK/WtKXBEBoIR1K+jI64N1gPa420sBir36vSk+gH3I/iMWmoJyJG1zEwxjr6e3C20bs qzZvV9aJpkkN5UqzGTn62NpOponU0eUKi3AN/IGJyYbjdQtzFqjTE0afaJRxg+/m4OjV GtzDAUf7sBd/xxBr8qQGi3Q+lNizNiBGNFZ0GyO9ynG04CKwI1CSreR3fXTP6kxq28kz Fo6fVBaGaymE35GYET5kU6ylcfvNAH9IUEebM3r3MStUfTQcG8hju40qQ6GoXd57bTit c7WQ== X-Gm-Message-State: ACrzQf0/sqGwzwODMEYWCmp5doZT92v2vCw5FHIbk6/Emxi3r2WvAjba P4vwensd3N7O7kJitTIr1Ns8vA== X-Google-Smtp-Source: AMsMyM4Kim3IsWLAeRiaNmbOWMXPNztIz3EePZlhHCUOgoJB2enCeOLO/ytox+A3fQBULaeUOHQbzA== X-Received: by 2002:a2e:a601:0:b0:26c:4149:251a with SMTP id v1-20020a2ea601000000b0026c4149251amr2283442ljp.348.1667081262018; Sat, 29 Oct 2022 15:07:42 -0700 (PDT) Received: from [10.27.10.248] ([195.165.23.90]) by smtp.gmail.com with ESMTPSA id h12-20020a2ea48c000000b00277041268absm435049lji.78.2022.10.29.15.07.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Oct 2022 15:07:41 -0700 (PDT) Message-ID: Date: Sun, 30 Oct 2022 01:07:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v2 01/12] dt-bindings: iio: qcom: adc7-pm8350: Allow specifying SID for channels Content-Language: en-GB To: Manivannan Sadhasivam , andersson@kernel.org Cc: konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org, quic_jprakash@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org References: <20221029051449.30678-1-manivannan.sadhasivam@linaro.org> <20221029051449.30678-2-manivannan.sadhasivam@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20221029051449.30678-2-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/10/2022 08:14, Manivannan Sadhasivam wrote: > As per the new ADC7 architecture used by the Qualcomm PMICs, each PMIC > has the static Slave ID (SID) assigned by default. The primary PMIC > PMK8350 is responsible for collecting the temperature/voltage data from > the slave PMICs and exposing them via it's registers. > > For getting the measurements from the slave PMICs, PMK8350 uses the > channel ID encoded with the SID of the relevant PMIC. So far, the > dt-binding for the slave PMIC PM8350 assumed that there will be only > one PM8350 in a system. So it harcoded SID 1 with channel IDs. > > But this got changed in platforms such as Lenovo X13s where there are a > couple of PM8350 PMICs available. So to address multiple PM8350s, change > the binding to accept the SID specified by the user and use it for > encoding the channel ID. > > It should be noted that, even though the SID is static it is not > globally unique. Only the primary PMIC has the unique SID id 0. > > Signed-off-by: Manivannan Sadhasivam > --- > .../bindings/thermal/qcom-spmi-adc-tm5.yaml | 6 +- > .../dt-bindings/iio/qcom,spmi-adc7-pm8350.h | 90 +++++++++---------- > 2 files changed, 46 insertions(+), 50 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry