devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Magnus Damm <damm@opensource.se>, linux-renesas-soc@vger.kernel.org
Cc: robh@kernel.org, geert+renesas@glider.be,
	devicetree@vger.kernel.org, conor+dt@kernel.org,
	linux-kernel@vger.kernel.org, wsa+renesas@sang-engineering.com,
	sergei.shtylyov@gmail.com, p.zabel@pengutronix.de
Subject: Re: [PATCH v2 1/4] dt-bindings: memory-controllers: renesas,rpc-if: Add RZ/A1 and RZ/A2 compat strings
Date: Sat, 12 Jul 2025 18:45:56 +0200	[thread overview]
Message-ID: <c8a16b30-569a-4266-9e2c-86be348afa86@kernel.org> (raw)
In-Reply-To: <175232756792.19062.3922882730162396395.sendpatchset@1.0.0.127.in-addr.arpa>

On 12/07/2025 15:39, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add RZ/A1 and RZ/A2 compat strings for the renesas rpc-if device.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  Changes since v1:
>  - Moved RZ/A to top of RZ
> 
>  Applies to next-20250710
> 
>  Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> --- 0001/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> +++ work/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml	2025-07-11 04:50:41.505855241 +0900
> @@ -50,6 +50,11 @@ properties:
>  
>        - items:
>            - enum:
> +	      - renesas,r7s72100-rpc-if       # RZ/A1H
> +	      - renesas,r7s9210-rpc-if        # RZ/A2M

Still not tested.

You got extensive guideline from me last time. You just replied (in
private!) that you are not going to install dtschema and test it.

Fine if you send correct code.

Not fine if you write buggy code. And this is obviously the case here as
easily visible in the diff above - borken indentation.

Please read carefully previous instructions.

Best regards,
Krzysztof

  reply	other threads:[~2025-07-12 16:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-12 13:39 [PATCH v2 0/4] Add RZ/A1 and RZ/A2 support to the rpc-if driver Magnus Damm
2025-07-12 13:39 ` [PATCH v2 1/4] dt-bindings: memory-controllers: renesas,rpc-if: Add RZ/A1 and RZ/A2 compat strings Magnus Damm
2025-07-12 16:45   ` Krzysztof Kozlowski [this message]
2025-07-12 19:06   ` Rob Herring (Arm)
2025-07-12 13:39 ` [PATCH v2 2/4] ARM: dts: renesas: r7s72100: add rpc-if nodes Magnus Damm
2025-07-12 13:39 ` [PATCH v2 3/4] ARM: dts: renesas: r7s9210: add rpc-if node Magnus Damm
2025-07-12 13:39 ` [PATCH v2 3/4] memory: renesas-rpc-if: Add RZ/A1 and RZ/A2 support Magnus Damm
2025-07-12 16:48   ` Krzysztof Kozlowski
2025-07-30 13:24   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8a16b30-569a-4266-9e2c-86be348afa86@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=damm@opensource.se \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sergei.shtylyov@gmail.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).