From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>,
Johan Hovold <johan@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
quic_wcheng@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_ppratap@quicinc.com,
quic_jackp@quicinc.com
Subject: Re: [PATCH 1/6] dt-bindings: usb: dwc3: Clean up hs_phy_irq in bindings
Date: Wed, 29 Nov 2023 10:28:25 +0100 [thread overview]
Message-ID: <c8a28c72-5c0a-4a67-a4c9-e46a5716cda4@linaro.org> (raw)
In-Reply-To: <6d7527bf-8c1a-49b5-a0cf-99a92098c971@quicinc.com>
On 28/11/2023 12:32, Krishna Kurapati PSSNV wrote:
>
>>
>> So back to my initial proposal, with a slight modification moving
>> pwr_event first (e.g. as it is not a wakeup interrupt):
>>
>> qusb2-:
>>
>> - const: pwr_event
>> - const: qusb2_phy
>> - const: ss_phy_irq (optional)
>>
>> qusb2:
>>
>> - const: pwr_event
>> - const: hs_phy_irq
>> - const: qusb2_phy
>> - const: ss_phy_irq (optional)
>>
>> femto-:
>> - const: pwr_event
>> - const: dp_hs_phy_irq
>> - const: dm_hs_phy_irq
>> - const: ss_phy_irq (optional)
>>
>> femto:
>> - const: pwr_event
>> - const: hs_phy_irq
>> - const: dp_hs_phy_irq
>> - const: dm_hs_phy_irq
>> - const: ss_phy_irq (optional)
I did not follow entire thread and I do not know whether you change the
order in existing bindings, but just in case: the entries in existing
bindings cannot change the order. That's a strict ABI requirement
recently also discussed with Bjorn, because we want to have stable DTB
for laptop platforms. If my comment is not relevant, then please ignore.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-29 9:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 19:13 [PATCH 1/6] dt-bindings: usb: dwc3: Clean up hs_phy_irq in bindings Krishna Kurapati
2023-11-22 20:25 ` Marijn Suijten
2023-11-23 7:41 ` Krzysztof Kozlowski
2023-11-23 7:44 ` Krishna Kurapati PSSNV
2023-11-23 7:50 ` Krzysztof Kozlowski
2023-11-23 7:57 ` Krishna Kurapati PSSNV
2023-11-23 14:10 ` Johan Hovold
2023-11-24 12:02 ` Krishna Kurapati PSSNV
2023-11-24 13:46 ` Johan Hovold
2023-11-24 17:39 ` Krishna Kurapati PSSNV
2023-11-28 10:21 ` Johan Hovold
2023-11-28 10:32 ` Krishna Kurapati PSSNV
2023-11-28 10:57 ` Johan Hovold
2023-11-28 11:32 ` Krishna Kurapati PSSNV
2023-11-29 9:28 ` Krzysztof Kozlowski [this message]
2023-11-29 10:16 ` Johan Hovold
2023-11-29 10:50 ` Krishna Kurapati PSSNV
2023-11-30 8:08 ` Krzysztof Kozlowski
2023-11-30 8:16 ` Krzysztof Kozlowski
2023-11-30 8:34 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8a28c72-5c0a-4a67-a4c9-e46a5716cda4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).