From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a1-smtp.messagingengine.com (fout-a1-smtp.messagingengine.com [103.168.172.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C4A042048; Mon, 10 Mar 2025 09:30:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.144 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599060; cv=none; b=aVK1O0xsfNHGwWTn8Nv9THKydiUHkZwtf3JLd/B5y5PJm3fgOVQ2cpxmVNP+2YRYtkXHYA2GR0ZfxYONQH1pf4pAjp95Gh/OPK/CwtZUPgtftRt2rsb+bHtGpvdbAqCJdnXHtWOznde0UNI9MpqY8N80Zh2xHhqgaAixkHdApT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741599060; c=relaxed/simple; bh=lRi5W35xGNH5dHBw89pU7IiFn3gC5KvO6PdSIKkNM34=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=QzxdDch1p0yWnVUTAL7wyOQ2MI9TDFD3R8mRJYvOMAx17T40C3yo5Oim+TG1V+kXXjrmlmus9f0B3K27HnYDOodSflL/N0BDv5HHf6a6rLBMiYnRozMSPYJ1qFduYVhHeeLpNAm+5yNb6pRtpgBES3at6NDKIcJRovlVLioEWfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=testtoast.com; spf=pass smtp.mailfrom=testtoast.com; dkim=pass (2048-bit key) header.d=testtoast.com header.i=@testtoast.com header.b=crOe3gB2; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=u0EkRWlI; arc=none smtp.client-ip=103.168.172.144 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=testtoast.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=testtoast.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=testtoast.com header.i=@testtoast.com header.b="crOe3gB2"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="u0EkRWlI" Received: from phl-compute-13.internal (phl-compute-13.phl.internal [10.202.2.53]) by mailfout.phl.internal (Postfix) with ESMTP id 1D02C1382D1A; Mon, 10 Mar 2025 05:30:58 -0400 (EDT) Received: from phl-imap-07 ([10.202.2.97]) by phl-compute-13.internal (MEProxy); Mon, 10 Mar 2025 05:30:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=testtoast.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1741599058; x=1741685458; bh=TlfIZxwEH199yoeoqgqRaK5o2m1xiByl +CXP110BFB0=; b=crOe3gB2m9g9LoW1nZ9xJ4JRKWSvgMKPhyNVaRc6CqiYaLoA 3U0pyvo9RVmrTPbjo4c/bdDRKkY5vVhKod+VE4309QlgDDHp59sRVK3mkj2vxiGd Y3huigyNK2yXlM4VG/znms3jSLiah/7SCNG2BNLE3tUu3xmOKg8N0mQOsnFgFmB0 ALAP7tti1+xqy8hx4+G/Pc6QblscqXMVsOkboANEqGyS0TTFxChdeluSwazoNLXr HpQ7Wn7D2O7qjpHw8ul/4hh8mhRS793lDgwzUjxPA1siH74LoROmOf64Oihrtw37 7EGJAoMm7VtYpBqelniC3TuvpZbUdRDYZDMHnA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1741599058; x= 1741685458; bh=TlfIZxwEH199yoeoqgqRaK5o2m1xiByl+CXP110BFB0=; b=u 0EkRWlI+dB79gh3+6iouR+oWqISL8XTriiMRFPHBOE5yd+eWRSn1rNKC4EkGZ+LE 3tH4Jd+tiWbs/jVEauBT8EQmRkfUzzclWhw+2cjDkpyBKv0fXzXxqgcI97Imyiyb FIzutPS72ft7kiH0QqYvsT4Vq+sCPjprAYEhVoW9DUtLlzP8VC3Fqbt46dZbw8Oj zxQ8ZJaBVN1MPx8eCBRS7O3CG1ma0lfqeA7p1kaIkZVCRhhTyLzBaGlt3nB4Nnc0 YaWP9m7ZbWbsYX5DRaTK3lq6ksdletNNL/5cZ9YO64JxaCjv9HOnSQErHp8s48eE BUt110looaBeZ0mrc3n3Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduudekleelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertder tddtnecuhfhrohhmpedftfihrghnucghrghlkhhlihhnfdcuoehrhigrnhesthgvshhtth horghsthdrtghomheqnecuggftrfgrthhtvghrnhepjefhueekjeejgfduvdffheevveej hfdtuddthfduuddvveefjeffgfdvleefuefgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomheprhihrghnsehtvghsthhtohgrshhtrdgtohhmpdhn sggprhgtphhtthhopedvgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprghnug hrvgdrphhriiihfigrrhgrsegrrhhmrdgtohhmpdhrtghpthhtohepmhhtuhhrqhhuvght thgvsegsrgihlhhisghrvgdrtghomhdprhgtphhtthhopeifvghnshestghsihgvrdhorh hgpdhrtghpthhtohepuggrnhhivghlsehffhiflhhlrdgthhdprhgtphhtthhopegrihhr lhhivggusehgmhgrihhlrdgtohhmpdhrtghpthhtohepjhgvrhhnvghjrdhskhhrrggsvg gtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepkhhikhhutghhrghnleeksehgmhgrihhl rdgtohhmpdhrtghpthhtohepmhgrtghrohgrlhhphhgrkedvsehgmhgrihhlrdgtohhmpd hrtghpthhtohepshhimhhonhhsrdhphhhilhhiphhpvgesghhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: idc0145fc:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 76AABBA006F; Mon, 10 Mar 2025 05:30:57 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Mon, 10 Mar 2025 22:30:36 +1300 From: "Ryan Walklin" To: "Andre Przywara" Cc: "Maxime Ripard" , "Chen-Yu Tsai" , "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Daniel Vetter" , "Jernej Skrabec" , "Samuel Holland" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Michael Turquette" , "Stephen Boyd" , "Chris Morgan" , "Hironori KIKUCHI" , "Philippe Simons" , "Dmitry Baryshkov" , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, "Conor Dooley" Message-Id: In-Reply-To: <20250224175642.170c124e@donnerap.manchester.arm.com> References: <20250216183710.8443-3-ryan@testtoast.com> <20250216183710.8443-23-ryan@testtoast.com> <20250224175642.170c124e@donnerap.manchester.arm.com> Subject: Re: [PATCH v7 22/27] dt-bindings: allwinner: add H616 DE33 mixer binding Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, 25 Feb 2025, at 6:56 AM, Andre Przywara wrote: Apologies Andre, I came to review your comments on the TCON series and realised I had missed responding to this comment before sending v8. >> + - allwinner,sun50i-h616-de33-mixer-0 >> >> reg: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 3 > > What are those three regions? I wonder if we should have reg-names here, > to fix the order, and to document them on the way? This would be the top, display and mixer groups for the DE333, and mixer for DE3 and earlier. Can certainly add in names for these. Is there any example elsewhere in the bindings to look at? >> @@ -61,6 +63,23 @@ properties: >> required: >> - port@1 >> >> +allOf: >> + - if: >> + properties: >> + compatible: >> + enum: >> + - allwinner,sun50i-h616-de33-mixer-0 >> + >> + then: >> + properties: >> + reg: >> + maxItems: 3 > > Should we override minItems here as well? I guess any driver would need > all three region to work? This seems sensible, as you say it would always be 3 groups for the DE33. Regards, Ryan