From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60B2B565108 for ; Wed, 14 Oct 2026 17:16:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791998195; cv=none; b=IZzKGPOGlpkDcrnz3FnfgpZB0tVVxjKTDDKhpVi5/EGWDF4al1hfcqwJ/boqX8tc80dT+78X4fsBc5LR+olhHg23M6tc0WE/7GFJsRIYWZqlIf/GpjbaIP4yyv3ug/eUW2q7HYoIu4Q0DirfB8a7yV4FB5mijnqEZPy8nHnmnDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791998195; c=relaxed/simple; bh=NtivolCQ1nJosxUI9F7OWFpX9s9PxlP7yMWcyfGE/8U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ms9WdH1QQipHA9ducIiw3HofcagZq8BUhbCcm0yj9msRbXy/U07JXkR3GvOXvSrbop5xGloKp1Bb/kWlP8uv7Kg8FFlh7SLnJSb9HxKDvYqbQ8GezQuSZaOFZ452dNDFLEA0pi33wABW60sE+GCFJeUYcaAy/6/xvtWfK8dlRVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R26knpqw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qlb5Q3Xa; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R26knpqw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qlb5Q3Xa" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69EFpaDf1672215 for ; Wed, 14 Oct 2026 17:16:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7SbRzAQqOqMGFrGen933aIJTTXXFDtSgDohs9rQuHzc=; b=R26knpqw1ZB66+aI TqCgaSoGNuEN0u6AeVx+S3yB2Pexc+EhmlDjA0flx3pzmD+gKmQKYY/kMm0mqZmH aJNVMVVNqaJAcJv2TvH3qeg0GQixhbcaf0oBmUz9G6WNByRlHRPFrFtXhrx30FnQ vwafSFqHqMBodongiS1JL64lTb3vD9+07fenxT42P3Xn2+yM0itCNahcfR0dSGXh bUofyG0b6iH2btQzMobU5KFwm0PbWxcBPCiapTU74jn4238vbI8gQrn5FdxLs1dS upbL8QQYpg2L7grtH+epf4ghq9FHkAGS2DUN4VggHvTbnwEIDFk1JYQUxsSbVz7R wzMv+w== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hacrh8b3j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Oct 2026 17:16:31 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-359b81ad4e8so1802354eec.0 for ; Wed, 14 Oct 2026 10:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791998191; x=1792602991; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7SbRzAQqOqMGFrGen933aIJTTXXFDtSgDohs9rQuHzc=; b=Qlb5Q3Xa8/DWZwcNLMBTqOasnqolO5ZKIWnVRJeqPbCZfagqniVhMCrPEM6jToguVa qR+QOtrit8r68N1cd9jQhrk8ZDa/+/UBVm2Vr8s7VaHEJ1kGDgWo/4y3PZtM6/Q8o/t9 l7npmkiXPY7xec3H2NH3NIrtPc1lechC6hDaC4avUn47KtBpqK2O6qQIvIsyW7lF/bXE 2de0tupBQD9sA6Ek+smGV9MxY+iM9l3ttiUQ45cJKop/p9ln9b0yqBGIXpMY3pOiniNC YbVhQevIgc3zil8tTCP08o9rJRSLC22cwRt4tpr/wD28YQwkQdqFFc0sk4Uf1fMCFe4d o5oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791998191; x=1792602991; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7SbRzAQqOqMGFrGen933aIJTTXXFDtSgDohs9rQuHzc=; b=E++sbu5o66+PCmqKXqOVoccgUrmbml5cTKyC9hYNsTQvf/fVNWrPqVtCmgVhMqa+8A 0B88VkqwkUrIa5lOll+L6P0lEzn82mE+jNc7xZLFmuhLjnFE4IYcchxpVvx45QZNcQWm g3pM8F3SMktvQtGKjyAWyPMSI+wTs01PeWJrSsSOr/KRf07DsFm+VzvB/zR9GicR4dXj LtsWYJc7Y9D3ffTk2gI9jACg5USw6Ihe0tjLBcSI90ltMvLQ575pLvmuDrVWxuThz/4p kO1610xEsaRRuv3rCM+1mptNoJxOPk/C0yFMHy/1+3GuLvl5Lsxh1ZkOqRFPomK4uA5j lwsA== X-Forwarded-Encrypted: i=1; AKwUvBxTb5X8L87V3V8GVAHh/K5dvRZ2qRLs3DJaD4zQFJ2z/CaN+E8w6JldDNa7sz40DH63N05jKUXFJGY3@vger.kernel.org X-Gm-Message-State: AFq9FYIyRcFwH43a8KIWN3CkDfReYYi8OZHcbLiUZGVhr8byRqFStrB7 l+nyprO9UVmelTPd1xZ1PhKLlhrtK0OwOuu8kwqLLGMEofvo16ei6uAkwbpkRzaFn1JN+w0gTb8 umQUzKpz5yfcih32vO+XovHN8v5wuINhl5whe2mm+etC5Ms5U9N+qcKGy6R3I65bn X-Gm-Gg: AYBFou29dUa4InfQjmAq4Dog1WNTqo7XbUxCfv94ys1+KyDilsSu/5xp+DNyqJbdpwa /1vu7dXsnf1+GQGNPvtRqoTP0qnWSXB+/wSe2Nm2b/7RpTGDH5e9yIOIeQLlaJcTIk9lf06IBnm T3d/JMqW49532atfE6X/G47silRsXAa3uDfJZFNUiNUS0sP8fwD1R/ZtMhOzWSOcx+G/2HMq6nS XzgLuxj89OVrdltM4TykKULG/ACUl/cMtWbzqPRlEVOfuUxjikkWTmayIf4n4gzUgWgoRjI7xqV PrHC0ymfzcmelUJUx4KshCCupwi3AO6rzfKEMWhK1jHKjwEZka/RzmPbZYriKks0lS88p5dJPyr pmL3XaXf5qEdtCMf/Z9gRgd+NrRh5Sw1y+AEE6NM= X-Received: by 2002:a05:7022:b9c:b0:144:fb42:52 with SMTP id a92af1059eb24-16a61d5bd24mr35223587c88.28.1791998190425; Wed, 14 Oct 2026 10:16:30 -0700 (PDT) X-Received: by 2002:a05:7022:b9c:b0:144:fb42:52 with SMTP id a92af1059eb24-16a61d5bd24mr35223517c88.28.1791998189644; Wed, 14 Oct 2026 10:16:29 -0700 (PDT) Received: from [192.168.1.5] ([223.230.101.206]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-17dc865cbffsm11282540c88.6.2026.10.14.10.16.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 10:16:29 -0700 (PDT) Message-ID: Date: Wed, 14 Oct 2026 22:46:21 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/7] ASoC: dt-bindings: ti,pcm1681: Document the optional SCK clock To: Krzysztof Kozlowski Cc: Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Shawn Guo , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20261009-nord-asoc-driver-support-v3-v3-0-0c1897f21ccf@oss.qualcomm.com> <20261009-nord-asoc-driver-support-v3-v3-1-0c1897f21ccf@oss.qualcomm.com> <20261013-supportive-imported-spider-c6e28d@quoll> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <20261013-supportive-imported-spider-c6e28d@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: UrGij9rNAwGnr7MVG7_yH_4KTkiSzoQw X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE0MDA2OCBTYWx0ZWRfX35/QI6AeUJT4 6mCEdf+8CUphRNUVtsHXPj9kIvvCsd5hTz/eR9yMydEhpDiFWaFldOZRd8CBl4U4OI+jhFYQhWC cOtn8Fg9uRp8WX+0ELAzGtBp0ecOH20= X-Proofpoint-GUID: UrGij9rNAwGnr7MVG7_yH_4KTkiSzoQw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE0MDA2OCBTYWx0ZWRfX6Adu0NXcr00U XeeGFUo8cDBNk0mdPwp1tRqKEbz9yxVtDFr9yse3eQ9p4aDUFWmWwIKcxdOt5eQAT6OlW+Zq5NB eUHRLcQ/GBStrTBd2G7KDtTaZMWuK8jowfVLowWXo2JCRdoSaF3wBXEVyTUGtJpmVjqxNnOE6ub /3vvLX7wgsf1Nr58p2cAdVh/keIYQGfHAcJtdgp+USTX3uuf2fkTZbbZWSC10PpTi/VyaPGPurB bNfDy+sIQ0H0UCPq35lH6bqQYxmF5suClHKFMWXf9ZBuw5XqbO61MMNJa/FhVjt1gxEV2a1q9lO HotrkD9BUocl294RZ1Po+aJOHQodaI8aIvbAhStYaBFHDiH5yI27ghQjfK3Hk6mDwBdOduq01GZ 9JehHapUdOYeiLdQQgplVEgpulAk6U73N5JfoZrD4m/Ffae7K4X4olqchnDOljiQlM2NisSZK1D Wwz8ozJyDaYR/eRO9fg== X-Authority-Analysis: v=2.4 cv=SYZi5fRu c=1 sm=1 tr=0 ts=6acfb8ef cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=89gBhgtN2V0NwPD6rb2Hew==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=UYrAC0ybtJ6TP4zHPckA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 phishscore=0 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610140068 On 10/13/2026 12:31 PM, Krzysztof Kozlowski wrote: > On Fri, Oct 09, 2026 at 06:42:47PM +0530, Mohammad Rafi Shaik wrote: >> The PCM1681 can use an external system clock supplied on the SCK input >> pin. Platforms that provide this clock need a way to describe the clock >> connection in Device Tree. >> >> Document the optional 'clocks' and 'clock-names' properties and define >> the clock name as "sck" to represent the external system clock source. >> >> This allows boards using an externally supplied SCK clock to accurately >> describe the hardware configuration. >> >> Reviewed-by: Shawn Guo >> Signed-off-by: Mohammad Rafi Shaik >> --- >> Documentation/devicetree/bindings/sound/ti,pcm1681.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml b/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml >> index 1f0e6787a..1b3803518 100644 >> --- a/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml >> +++ b/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml >> @@ -21,6 +21,13 @@ properties: >> reg: >> maxItems: 1 >> >> + clocks: >> + maxItems: 1 >> + description: System clock (SCK) >> + >> + clock-names: >> + const: sck > > Drop the names. If they are needed for any reason, then use the same > name other device uses already, so scki. Ack, Yes, the clock name is required as it represents the system clock. I’ll use scki, consistent with the other implementations. Best Regards, Rafi. > > Best regards, > Krzysztof >