devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] imx6q related DT binding fixes
@ 2023-10-12  8:00 Alexander Stein
  2023-10-12  8:00 ` [PATCH v2 1/3] dt-bindings: imx-thermal: Add #thermal-sensor-cells property Alexander Stein
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Alexander Stein @ 2023-10-12  8:00 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Rafael J . Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
	Shawn Guo, Sascha Hauer, Fabio Estevam, Thomas Gleixner
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team, netdev,
	devicetree, linux-pm, linux-arm-kernel

Hi everyone,

while working on i.MX6Q based board (arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dts)
I noticed several warnings on dtbs_check.
I'm also not sure whether thse patches warrent a Fixes tag, so I only added that
for patch 3. All of these patches are independent and can be picked up
individually.

Patches already merged:
* 0268e1ae25949 ("dt-bindings: trivial-devices: Remove national,lm75")
* 57db57ae15a97 ("dt-bindings: display: fsl,imx6-hdmi: Change to 'unevaluatedProperties: false'")
  which deprecates v1 patch 3

Changes in v2:
* Fix example for imx-thermal.yaml
* Collected R-b & A-b
* Dropped v1 patch 6 for now as it is contoversial

Best regards,
Alexander

Alexander Stein (3):
  dt-bindings: imx-thermal: Add #thermal-sensor-cells property
  dt-bindings: net: microchip: Allow nvmem-cell usage
  dt-bindings: timer: add imx7d compatible

 .../devicetree/bindings/net/microchip,lan95xx.yaml         | 2 ++
 Documentation/devicetree/bindings/thermal/imx-thermal.yaml | 7 +++++++
 Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml    | 4 +++-
 3 files changed, 12 insertions(+), 1 deletion(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/3] dt-bindings: imx-thermal: Add #thermal-sensor-cells property
  2023-10-12  8:00 [PATCH v2 0/3] imx6q related DT binding fixes Alexander Stein
@ 2023-10-12  8:00 ` Alexander Stein
  2023-10-12  8:00 ` [PATCH v2 2/3] dt-bindings: net: microchip: Allow nvmem-cell usage Alexander Stein
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2023-10-12  8:00 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Rafael J . Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
	Shawn Guo, Sascha Hauer, Fabio Estevam, Thomas Gleixner
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team, netdev,
	devicetree, linux-pm, linux-arm-kernel, Conor Dooley

This property is defined in thermal-sensor.yaml. Reference this file and
constraint '#thermal-sensor-cells' to 0 for imx-thermal.
Fixes the warning:
arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: tempmon:
 '#thermal-sensor-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
 From schema: Documentation/devicetree/bindings/thermal/imx-thermal.yaml

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
 Documentation/devicetree/bindings/thermal/imx-thermal.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/imx-thermal.yaml b/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
index 3aecea77869f0..808d987bd8d1a 100644
--- a/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
@@ -60,6 +60,9 @@ properties:
   clocks:
     maxItems: 1
 
+  "#thermal-sensor-cells":
+    const: 0
+
 required:
   - compatible
   - interrupts
@@ -67,6 +70,9 @@ required:
   - nvmem-cells
   - nvmem-cell-names
 
+allOf:
+  - $ref: thermal-sensor.yaml#
+
 additionalProperties: false
 
 examples:
@@ -104,5 +110,6 @@ examples:
              nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
              nvmem-cell-names = "calib", "temp_grade";
              clocks = <&clks IMX6SX_CLK_PLL3_USB_OTG>;
+             #thermal-sensor-cells = <0>;
         };
     };
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/3] dt-bindings: net: microchip: Allow nvmem-cell usage
  2023-10-12  8:00 [PATCH v2 0/3] imx6q related DT binding fixes Alexander Stein
  2023-10-12  8:00 ` [PATCH v2 1/3] dt-bindings: imx-thermal: Add #thermal-sensor-cells property Alexander Stein
@ 2023-10-12  8:00 ` Alexander Stein
  2023-10-12  8:00 ` [PATCH v2 3/3] dt-bindings: timer: add imx7d compatible Alexander Stein
  2023-10-12 15:34 ` [PATCH v2 0/3] imx6q related DT binding fixes Daniel Lezcano
  3 siblings, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2023-10-12  8:00 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Rafael J . Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
	Shawn Guo, Sascha Hauer, Fabio Estevam, Thomas Gleixner
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team, netdev,
	devicetree, linux-pm, linux-arm-kernel, Conor Dooley, Rob Herring

MAC address can be provided by a nvmem-cell, thus allow referencing a
source for the address. Fixes the warning:
arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: ethernet@1: 'nvmem-cell-names',
 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
 From schema: Documentation/devicetree/bindings/net/microchip,lan95xx.yaml

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
index 77c9bbf987e15..accff93d38f80 100644
--- a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
+++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
@@ -44,6 +44,8 @@ properties:
 
   local-mac-address: true
   mac-address: true
+  nvmem-cells: true
+  nvmem-cell-names: true
 
 required:
   - compatible
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 3/3] dt-bindings: timer: add imx7d compatible
  2023-10-12  8:00 [PATCH v2 0/3] imx6q related DT binding fixes Alexander Stein
  2023-10-12  8:00 ` [PATCH v2 1/3] dt-bindings: imx-thermal: Add #thermal-sensor-cells property Alexander Stein
  2023-10-12  8:00 ` [PATCH v2 2/3] dt-bindings: net: microchip: Allow nvmem-cell usage Alexander Stein
@ 2023-10-12  8:00 ` Alexander Stein
  2023-10-12 15:34 ` [PATCH v2 0/3] imx6q related DT binding fixes Daniel Lezcano
  3 siblings, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2023-10-12  8:00 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Rafael J . Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
	Shawn Guo, Sascha Hauer, Fabio Estevam, Thomas Gleixner
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team, netdev,
	devicetree, linux-pm, linux-arm-kernel, Conor Dooley, Rob Herring

Currently the dtbs_check for imx6ul generates warnings like this:

['fsl,imx7d-gpt', 'fsl,imx6sx-gpt'] is too long

The driver has no special handling for fsl,imx7d-gpt, so fsl,imx6sx-gpt is
used. Therefore make imx7d GPT compatible to the imx6sx one to fix the
warning.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
index dbe1267af06a6..c5d3be8c1d682 100644
--- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
+++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
@@ -36,7 +36,9 @@ properties:
               - fsl,imxrt1170-gpt
           - const: fsl,imx6dl-gpt
       - items:
-          - const: fsl,imx6ul-gpt
+          - enum:
+              - fsl,imx6ul-gpt
+              - fsl,imx7d-gpt
           - const: fsl,imx6sx-gpt
 
   reg:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 0/3] imx6q related DT binding fixes
  2023-10-12  8:00 [PATCH v2 0/3] imx6q related DT binding fixes Alexander Stein
                   ` (2 preceding siblings ...)
  2023-10-12  8:00 ` [PATCH v2 3/3] dt-bindings: timer: add imx7d compatible Alexander Stein
@ 2023-10-12 15:34 ` Daniel Lezcano
  3 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2023-10-12 15:34 UTC (permalink / raw)
  To: Alexander Stein, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Rafael J . Wysocki, Zhang Rui, Lukasz Luba, Shawn Guo,
	Sascha Hauer, Fabio Estevam, Thomas Gleixner
  Cc: Pengutronix Kernel Team, NXP Linux Team, netdev, devicetree,
	linux-pm, linux-arm-kernel

On 12/10/2023 10:00, Alexander Stein wrote:
> Hi everyone,
> 
> while working on i.MX6Q based board (arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dts)
> I noticed several warnings on dtbs_check.
> I'm also not sure whether thse patches warrent a Fixes tag, so I only added that
> for patch 3. All of these patches are independent and can be picked up
> individually.
> 
> Patches already merged:
> * 0268e1ae25949 ("dt-bindings: trivial-devices: Remove national,lm75")
> * 57db57ae15a97 ("dt-bindings: display: fsl,imx6-hdmi: Change to 'unevaluatedProperties: false'")
>    which deprecates v1 patch 3

Applied, thanks


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-10-12 15:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-12  8:00 [PATCH v2 0/3] imx6q related DT binding fixes Alexander Stein
2023-10-12  8:00 ` [PATCH v2 1/3] dt-bindings: imx-thermal: Add #thermal-sensor-cells property Alexander Stein
2023-10-12  8:00 ` [PATCH v2 2/3] dt-bindings: net: microchip: Allow nvmem-cell usage Alexander Stein
2023-10-12  8:00 ` [PATCH v2 3/3] dt-bindings: timer: add imx7d compatible Alexander Stein
2023-10-12 15:34 ` [PATCH v2 0/3] imx6q related DT binding fixes Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).