From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eddie James Subject: Re: [PATCH v3 1/8] dt-bindings: soc: Add Aspeed XDMA engine binding documentation Date: Thu, 27 Jun 2019 14:19:47 -0500 Message-ID: References: <1559153408-31190-1-git-send-email-eajames@linux.ibm.com> <1559153408-31190-2-git-send-email-eajames@linux.ibm.com> <58b74556-cbf0-4da2-9392-4c4ac40ad760@www.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <58b74556-cbf0-4da2-9392-4c4ac40ad760@www.fastmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Andrew Jeffery , linux-aspeed@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Rob Herring , mark.rutland@arm.com, devicetree@vger.kernel.org, Joel Stanley List-Id: devicetree@vger.kernel.org On 5/30/19 12:30 AM, Andrew Jeffery wrote: > > On Thu, 30 May 2019, at 03:40, Eddie James wrote: >> Document the bindings. >> >> Signed-off-by: Eddie James >> --- >> .../devicetree/bindings/soc/aspeed/xdma.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/aspeed/xdma.txt >> >> diff --git a/Documentation/devicetree/bindings/soc/aspeed/xdma.txt >> b/Documentation/devicetree/bindings/soc/aspeed/xdma.txt >> new file mode 100644 >> index 0000000..85e82ea >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/aspeed/xdma.txt >> @@ -0,0 +1,23 @@ >> +* Device tree bindings for the Aspeed XDMA Engine >> + >> +The XDMA Engine embedded in the AST2500 SOC can perform automatic DMA >> +operations over PCI between the AST2500 (acting as a BMC) and a host >> processor. >> + >> +Required properties: >> + >> + - compatible "aspeed,ast2500-xdma" >> + - reg contains the offset and length of the memory region >> + assigned to the XDMA registers >> + - resets reset specifier for the syscon reset associated with >> + the XDMA engine >> + - interrupts the interrupt associated with the XDMA engine on this >> + platform > The indentation is quite distracting. If you rev the series can you fix it? I think the diff is throwing it off; it all lines up when applied. Thanks, Eddie > > Otherwise, > > Reviewed-by: Andrew Jeffery > >> + >> +Example: >> + >> + xdma@1e6e7000 { >> + compatible = "aspeed,ast2500-xdma"; >> + reg = <0x1e6e7000 0x100>; >> + resets = <&syscon ASPEED_RESET_XDMA>; >> + interrupts = <6>; >> + }; >> -- >> 1.8.3.1 >> >>