From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E49C43334 for ; Mon, 11 Jul 2022 11:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231433AbiGKL0y (ORCPT ); Mon, 11 Jul 2022 07:26:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231277AbiGKL0M (ORCPT ); Mon, 11 Jul 2022 07:26:12 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32B5C3DF04 for ; Mon, 11 Jul 2022 04:02:35 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id e28so4470684lfj.4 for ; Mon, 11 Jul 2022 04:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=MeyCZN/nvsiRNNCAAR15uWNXyKxL+fyysaeRMmXtoJA=; b=D4OVU2SdZDl1a2Jmvol1Su2acwSKKhbqYZKZn6/Qc8eT2iND/KO9t9DapzIOJtxYXe Me3ljHAhTzWcyA62SHeecPkZ9BDGif3nIQh/4L6wxXSsOfYRKcaerfZkctH+lPcPcaXR 9nwslGSNuJR55nrpcs0QsF89vgcW8SmISLwf7h2vLLq4lkAVjwTUIVYO0/uBy/LsND6c fUnyCOa9fgewXhbnW8EdRaMnWofxJvAWbnpmaDz4VV5KTLCEbsVuj6MgdDHsj0ja4Cm4 7iMTtMjKPL9Xg15Ww0kzLHvpVQi9YC6P0O0itH4F7zJK4x/PaxvCYROPFLopO6UyHl1u Htcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MeyCZN/nvsiRNNCAAR15uWNXyKxL+fyysaeRMmXtoJA=; b=AXp8ey3ypKI3WFA0cF3kLsGZH5sTGqcw/ugs15MsnTFmFsePeZWoQ94ZWrzaKAWX6J l7+w9mhIyID3gmqfHbWsGJ0xwEifymwIlZ5FkttCCfzbXzrboK83BoC7btph3wERraR/ tKnsmdoqWNYlJCcWNGLQ0XEFDZy+iaXQ48YOEZJhoAX6ctBGBBZZMQww+PDoAfiPDwZf RdnBJ2zP6o13h4tz0gs9qZ/xCKy8MJkaNBxjrYLRFVAp9+BmEL34aMrugTFX1A5UNH6C /i5+0iE1I5PPT+7hCnuzFAq9ZUX7XFAcmtJrThZedAvFJ2i+V3zX6qG2NwI9bchGfTgb z8aQ== X-Gm-Message-State: AJIora+1/LdHNauauv3RsZAQ6o2i6SG0Ek3DqW56Avj3pBDTwHIL2wER 2UleDEQevcfvL9TiaX3hNDv78g== X-Google-Smtp-Source: AGRyM1vhnNj6aFdiTr/noru4YDiDuSvAcJcPUSJPfEwIMQ9AAASbaicPsvFT+S0lPieRGdaNAEiPLw== X-Received: by 2002:a05:6512:3b20:b0:47f:8ca1:bd7 with SMTP id f32-20020a0565123b2000b0047f8ca10bd7mr10686215lfv.105.1657537353492; Mon, 11 Jul 2022 04:02:33 -0700 (PDT) Received: from [10.0.0.8] (fwa5cab-55.bb.online.no. [88.92.171.55]) by smtp.gmail.com with ESMTPSA id u10-20020ac258ca000000b00478a311d399sm1489609lfo.0.2022.07.11.04.02.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 04:02:32 -0700 (PDT) Message-ID: Date: Mon, 11 Jul 2022 13:02:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188 Content-Language: en-US To: Johnson Wang , ulf.hansson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220707054710.1396-1-johnson.wang@mediatek.com> <41e17a56-5cb0-8e90-c7ae-a7a56de986d0@linaro.org> <3216ec92952c7d722feaeb76986e0a6a54340646.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <3216ec92952c7d722feaeb76986e0a6a54340646.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/07/2022 09:30, Johnson Wang wrote: > On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote: >> On 07/07/2022 07:47, Johnson Wang wrote: >>> This commit adds dt-binding documentation of mmc for MediaTek >>> MT8188 SoC >>> platform. >>> >>> Signed-off-by: Johnson Wang >>> --- >>> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> index 2a2e9fa8c188..3fbf33ad4f7c 100644 >>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> @@ -32,6 +32,9 @@ properties: >>> - items: >>> - const: mediatek,mt8186-mmc >>> - const: mediatek,mt8183-mmc >>> + - items: >>> + - const: mediatek,mt8188-mmc >> >> You duplicate quite a lot. Use enum. >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > > Thanks for you suggestion. > > I will use 'enum' to place this compatible strings. > > Just like this: > - items: > - enum: > - mediatek,mt8186-mmc > - mediatek,mt8188-mmc > - mediatek,mt8192-mmc > - mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > > Moreover, it seems that missing an "items:" between oneOf and enum in > the compatible property. > Is my understanding wrong? I did not propose to remove items, so where are they missing? Not sure what you are asking about... Best regards, Krzysztof