From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker
Date: Tue, 27 Dec 2022 12:22:17 +0100 [thread overview]
Message-ID: <c8f9d608-6fa6-48d0-5dc9-3daba9d96d66@linaro.org> (raw)
In-Reply-To: <20221224154255.43499-5-krzysztof.kozlowski@linaro.org>
On 24.12.2022 16:42, Krzysztof Kozlowski wrote:
> Node names should be generic so use consistently speaker-amp for CS35L41
> speaker amplifier.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> index 09a31f707639..25c3e02f224b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> @@ -454,7 +454,7 @@ &i2c2 {
> status = "okay";
> clock-frequency = <1000000>;
>
> - cs35l41_l: cs35l41@40 {
> + cs35l41_l: speaker-amp@40 {
> compatible = "cirrus,cs35l41";
> reg = <0x40>;
> interrupt-parent = <&tlmm>;
> @@ -469,7 +469,7 @@ cs35l41_l: cs35l41@40 {
> #sound-dai-cells = <1>;
> };
>
> - cs35l41_r: cs35l41@41 {
> + cs35l41_r: speaker-amp@41 {
> compatible = "cirrus,cs35l41";
> reg = <0x41>;
> interrupt-parent = <&tlmm>;
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> index 1f2d660f8f86..4862fd69413e 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> @@ -461,7 +461,7 @@ &i2c11 {
> status = "okay";
> clock-frequency = <1000000>;
>
> - cs35l41_l: cs35l41@40 {
> + cs35l41_l: speaker-amp@40 {
> compatible = "cirrus,cs35l41";
> reg = <0x40>;
> interrupt-parent = <&tlmm>;
> @@ -476,7 +476,7 @@ cs35l41_l: cs35l41@40 {
> #sound-dai-cells = <1>;
> };
>
> - cs35l41_r: cs35l41@41 {
> + cs35l41_r: speaker-amp@41 {
> compatible = "cirrus,cs35l41";
> reg = <0x41>;
> interrupt-parent = <&tlmm>;
next prev parent reply other threads:[~2022-12-27 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 15:42 [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Krzysztof Kozlowski
2022-12-24 15:42 ` [PATCH 2/5] arm64: dts: qcom: sm6125: re-order USB2 phy clocks Krzysztof Kozlowski
2022-12-25 22:16 ` Marijn Suijten
2022-12-24 15:42 ` [PATCH 3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro Krzysztof Kozlowski
2022-12-27 11:21 ` Konrad Dybcio
2022-12-24 15:42 ` [PATCH 4/5] arm64: dts: qcom: sm8450: re-order GCC clocks Krzysztof Kozlowski
2022-12-27 11:21 ` Konrad Dybcio
2022-12-24 15:42 ` [PATCH 5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker Krzysztof Kozlowski
2022-12-27 11:22 ` Konrad Dybcio [this message]
2022-12-27 11:22 ` [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Konrad Dybcio
2022-12-29 17:23 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8f9d608-6fa6-48d0-5dc9-3daba9d96d66@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).