From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1799CC432C3 for ; Fri, 15 Nov 2019 01:51:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9EE2206D5 for ; Fri, 15 Nov 2019 01:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbfKOBvy (ORCPT ); Thu, 14 Nov 2019 20:51:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:56488 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726956AbfKOBvy (ORCPT ); Thu, 14 Nov 2019 20:51:54 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 80276B1C0; Fri, 15 Nov 2019 01:51:52 +0000 (UTC) Subject: Re: [PATCH 5/7] ARM: dts: rtd1195: Introduce r-bus To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , LAKML , linux-realtek-soc@lists.infradead.org References: <20191111030434.29977-1-afaerber@suse.de> <20191111030434.29977-6-afaerber@suse.de> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: Date: Fri, 15 Nov 2019 02:51:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am 15.11.19 um 02:34 schrieb Rob Herring: >> diff --git a/arch/arm/boot/dts/rtd1195.dtsi b/arch/arm/boot/dts/rtd1195.dtsi >> index a8cc2d23e7ef..3439647ecf97 100644 >> --- a/arch/arm/boot/dts/rtd1195.dtsi >> +++ b/arch/arm/boot/dts/rtd1195.dtsi >> @@ -92,28 +92,36 @@ >> <0x18100000 0x18100000 0x01000000>, >> <0x40000000 0x40000000 0xc0000000>; >> >> - wdt: watchdog@18007680 { >> - compatible = "realtek,rtd1295-watchdog"; >> - reg = <0x18007680 0x100>; >> - clocks = <&osc27M>; >> - }; >> - >> - uart0: serial@18007800 { >> - compatible = "snps,dw-apb-uart"; >> - reg = <0x18007800 0x400>; >> - reg-shift = <2>; >> - reg-io-width = <4>; >> - clock-frequency = <27000000>; >> - status = "disabled"; >> - }; >> - >> - uart1: serial@1801b200 { >> - compatible = "snps,dw-apb-uart"; >> - reg = <0x1801b200 0x100>; >> - reg-shift = <2>; >> - reg-io-width = <4>; >> - clock-frequency = <27000000>; >> - status = "disabled"; >> + rbus: r-bus@18000000 { > > Following node names should be generic: bus@... Fixed for all four SoCs. That seems inconsistent with specific pci@... & usb@... (both from OF), but I see now the Amlogic-specific buses that I was inspired by do use bus@..., too. Thanks, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)