From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 456BE5A4C4 for ; Thu, 28 Mar 2024 17:09:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711645796; cv=none; b=ZaEYOYOzsFHYXKWaIOdZsxrfkIt1Xp2jPltftRIaJ0TuzHN2bFVP0Mzh1bX2VVy/boI+Uu8mlaVQ6Fbz9rXEfAffnZ7Fow+n/Sr9PO2MK27EKF3eaiAAghLpgVbOKu19qxPN0yb8pb5+dJ3j4eRMAgRHYHglbCs6eKmITlmigZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711645796; c=relaxed/simple; bh=4aGtlYQa6LOd2OEmaA7FHOw6SQYqs0vT1Qz4Tis7MSs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lIqit4bkXDjXBsHyZt/nFM6sLQ2lF/1lOc0al0nQzt9usAn1BCYLMRSnn80tMeT5lYCp311tiTHIQXmdUtpxuLg3ZRLAZEZTWPd80G/F+Oqmgln02uS6iLqOUMAEnR6f5vEslSlzK19bNsMwIZnQjDDMXnXOdv4s4zrUsNt0IgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr; spf=pass smtp.mailfrom=freebox.fr; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b=VPUpwU4I; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=freebox.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b="VPUpwU4I" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-414a2679222so7481855e9.1 for ; Thu, 28 Mar 2024 10:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebox-fr.20230601.gappssmtp.com; s=20230601; t=1711645788; x=1712250588; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y8/g+cHkPSXhHlEKcSVfgwp5KAJjPgctuVitEMx931o=; b=VPUpwU4I2a1Do4aFNdRh5a63esOYYUo4RY9x2pYYPz0rW0e0OePa96Ae1Fn+87NzjE C70CVl2i3EgQlrlInY47WgkAJNMeBu9PYH0d6IRYF/pBo8KJ/YLE/ZIuF3ydE1aDqn46 REZrGLZO0LqVbzxWiO0Pi2B1Fb06baU0NjlaTHLt6xvO+HVaPDzXjTii0BplnmJ3XSR+ t/yuKlbMZlk/k+Bsjy4k0vsGMT4S7vI3y28hkTWErDO5CCUWPzYKiOaAjHFvzoOPXQ7B noU0k252QBDvakeYGRscsgJck2ZVUzksxYRu7MpoM5hj307Lrw+T97Z6i+1HPdbkM3Nw FeqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711645788; x=1712250588; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y8/g+cHkPSXhHlEKcSVfgwp5KAJjPgctuVitEMx931o=; b=bXdjubpAxesKd9nZupUlbm8CKD73VDJ+Rq1H7a7hJ5Q9EYzR3HIIa7ssmqv7I0sxWT Pg3oEsUldT0+6qQFF9o0v1PagvpJXbZMYlbXnUpFmVta2uq6IbjNEe8cjwosiQ4j/7mo 6WJT4HoJVyKTgJFObtlB4ZlIRNUh5Nv/+Uefg7ZYDcbz1TfXW2gA+MqTlvo9snuTr7nB WfLDWoGoMQ/K1sGO/yv3x2QZ7SOZV3JWqHFsolJBc6Z5hGwfmnTyrmY9IANGqN9pCpnW VUJyKsdSq3kPf1m744obGpsiK0dwAuo2KIsZ1zRI8LvGuSYTkZCarbNRkXsUIdB1Y2mf yHLA== X-Forwarded-Encrypted: i=1; AJvYcCXFaRa8wpHzAU5IiIhImA3zQWl3lgtZwlKoF6A3/tYrd3dlWmCAGQ2wz8rSYMp1/doe5vud0utxPwqmGSDlk66OboYDqF9Y8i0pSQ== X-Gm-Message-State: AOJu0YzHq+CRF+/K/DHOzHF7A+2MbP9tc8fTF/c8UqVWT2ruSrCw9Kiq 75otkPmvktp+g06yovHCdK8JsYSPw/lcHE45JVuY2a+hu+o/ItREy77q+753VYM= X-Google-Smtp-Source: AGHT+IHOl+8pLp638KlWCuohcoJcoPfMOHatFiZG43JVDO7VUY/xCGKW1oVbaGfCkvHbEXNELOF7jw== X-Received: by 2002:a05:600c:3ba6:b0:415:43f2:332b with SMTP id n38-20020a05600c3ba600b0041543f2332bmr2148445wms.2.1711645788367; Thu, 28 Mar 2024 10:09:48 -0700 (PDT) Received: from [192.168.108.81] (freebox.vlq16.iliad.fr. [213.36.7.13]) by smtp.gmail.com with ESMTPSA id o10-20020a05600c510a00b004148a5e3188sm5997405wms.25.2024.03.28.10.09.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 10:09:47 -0700 (PDT) Message-ID: Date: Thu, 28 Mar 2024 18:09:47 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop Content-Language: en-US To: Kalle Valo , Jeff Johnson , Dmitry Baryshkov Cc: ath10k , wireless , DT , Pierre-Hugues Husson , Arnaud Vrac , Jami Kettunen , Jeffrey Hugo , Bjorn Andersson , Konrad Dybcio References: <14daa98e-7fd3-4ebb-87bb-5d2c1fba679f@freebox.fr> <871q8wk7o3.fsf@kernel.org> <3392f356-7b19-483d-b9f8-3bd84068fa52@freebox.fr> <87wmqoilzf.fsf@kernel.org> <87cyse8j9m.fsf@kernel.org> <6d4b1381-c121-4cda-a8c9-9ccac56bd447@freebox.fr> <87plw87nsc.fsf@kernel.org> <0816f7bb-3c97-4b90-8e19-191552ea6e26@freebox.fr> <87h6hk7aee.fsf@kernel.org> <243a97b7-c298-4307-9f06-8b3a7c3e24fd@freebox.fr> <9293793d-00e8-42ce-87b2-05abc3b49387@freebox.fr> <4b7bf7cc-ede6-4c2a-983c-da4c8c09c5d1@quicinc.com> From: Marc Gonzalez In-Reply-To: <4b7bf7cc-ede6-4c2a-983c-da4c8c09c5d1@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/03/2024 21:21, Jeff Johnson wrote: > On 3/26/2024 10:51 AM, Dmitry Baryshkov wrote: > >> On Tue, 26 Mar 2024 at 19:45, Marc Gonzalez wrote: >>> >>> [ It has been pointed out to me that the previous message was unclear. ] >>> [ Below is my 2nd attempt at a clearer message. ] >>> >>> Problem: firmware-5.bin has not been parsed yet when we have to handle >>> the ATH10K_QMI_EVENT_SERVER_ARRIVE case, so we can't rely on feature bits >>> to work around the lack of MSA_READY indicator. >> >> Then, I'd say, we have to resort to the DT property, unless Kalle or >> Jeff have other proposals. > > Another option is to follow the downstream driver model and only expect this > based upon static configuration within the driver. > > Downstream driver has: > if (priv->device_id == ADRASTEA_DEVICE_ID) { > ret = wlfw_msa_mem_info_send_sync_msg(priv); > ret = wlfw_msa_ready_send_sync_msg(priv); > } > > https://git.codelinaro.org/clo/la/platform/vendor/qcom-opensource/wlan/platform/-/blob/wlan-platform.lnx.1.0.r4-rel/icnss2/main.c?ref_type=heads#L968 > > The downstream MSA logic (including some other code that populates MSA-related > fields in the QMI messages) is only invoked for ADRASTEA_DEVICE_ID. > > We could introduce a new hw_params parameter to have the same semantics. > > But I'm OK with the DT option as well. > > Kalle? I'll send a v2 series with the DT option + setting the quirk flag for all msm8998 devices. I'll include msm8998 board maintainers for feedback. Regards