From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS] Date: Tue, 10 Sep 2019 12:44:03 -0700 Message-ID: References: <20190910084707.18380-1-sakari.ailus@linux.intel.com> <20190910084707.18380-2-sakari.ailus@linux.intel.com> <20190910071837.2e9110f8@oasis.local.home> <61a2b2ab4693535850306f396aac2a328e1d5a21.camel@perches.com> <20190910142621.0bec208d@oasis.local.home> <20190910150303.5a0d3904@oasis.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190910150303.5a0d3904@oasis.local.home> Sender: linux-kernel-owner@vger.kernel.org To: Steven Rostedt Cc: Sakari Ailus , Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, Andy Shevchenko , linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Heikki Krogerus , Arnaldo Carvalho de Melo , Tzvetomir Stoyanov , linux-trace-devel@vger.kernel.org, Jiri Olsa , Namhyung Kim List-Id: devicetree@vger.kernel.org On Tue, 2019-09-10 at 15:03 -0400, Steven Rostedt wrote: > On Tue, 10 Sep 2019 11:42:06 -0700 [] > > btw: > > > > Is there kernel version information available in > > trace output files? > > Not really. This is just a library that parses the trace event formats, > there's not kernel versions passed in, but we do use variations in > formats and such to determine what is supported. > > > If so, it might be reasonable to change the tooling > > there instead. > > > > Actually, I think we could just look to see if "%pfw" is used and fall > to that, otherwise consider it an older kernel and do it the original > way. Well, if you think that works, OK great. But could that work? How would an individual trace record know if another trace record used %pfw? Perhaps not reusing %pf, marking it reserved for a period of years, and using another unused prefix %p like %pnfw may be simpler.