From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80E39202C31; Wed, 7 May 2025 09:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746611808; cv=none; b=ggYPCcH897+ovF/2skZ5MhXC0NeX0jGNDceKljv2OnCP/nBEz+8uihiHyNEW7qzzBalcDmYvd7V9uAY4SXC03N3ozr9A9yP6kR/mWFaObbIkJedgt0wRvkD8msvp6mHP7pZmBQv3GWcU+ZTsngAm1JyGmMcbvrMfHWO3CZZqLcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746611808; c=relaxed/simple; bh=0MgyHT40Kzwm56PZc1QIu5bnfmCzRdNV6JD2WgXp0VQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=niD5QTA8DpVfortyR1fLMm40VsHgTgBwO8NxgIExXqmQP+T4lEUhed61Qj16SBOZN5y6a/b5HmxtJOAOT13qLeGY7rocW+Xl28X7odGy9va6WlPIuoDUgX/upxDOWkYCQL3Z76ckSOU8icqiaxuFSTRCUCpbulptLV4giWUnf2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=JMe13eXE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="JMe13eXE" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5471H8o6021660; Wed, 7 May 2025 09:56:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= i3WjVEP76mf0rqTTBuk0vFXV+/2ZlGwZiVlYgOnFqxA=; b=JMe13eXEg2+Y46NC KoMLRzOMY8Ja4LHmwpF2M/9yWvze3sx1kTIaGboAoKB+QUS93YOL1fvXIBZrWVI/ hDr5ywtIBXI5TomzdiUzpMhZaaezHt23mDWqB0DqvPBSylGfN6xYZBU/tl1N7QWb bwectKQ2O0Ddkqq2KWp57vS4Obtf1svihx5MZ8ASd7ituMK3y2UXI8E3cSMnc4fK tFBEIC8j9fuuLd2xj7w323+jZv2fmwBl0EgNvrN/mQ+c3v1zAGypQ52reGUOEbbM nhMXeYsM6vgsUI6T0eFQ3LZ+jC7xWND845oYcP7sQH/TlNiOoQLy089UfJCRompF uB3PKg== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46fdwtv2k4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 May 2025 09:56:36 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 5479uaAP018854 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 May 2025 09:56:36 GMT Received: from [10.239.29.178] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 7 May 2025 02:56:28 -0700 Message-ID: Date: Wed, 7 May 2025 17:56:12 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/6] dt-bindings: PCI: qcom,pcie-sa8775p: document qcs8300 To: Krzysztof Kozlowski , Ziyue Zhang CC: , , , , , , , , , , , , , , , , , , , , References: <20250507031019.4080541-1-quic_ziyuzhan@quicinc.com> <20250507031019.4080541-3-quic_ziyuzhan@quicinc.com> <20250507-quixotic-handsome-wallaby-4560e3@kuoka> <8fef4573-0527-44d8-a481-f3271d9ffa33@quicinc.com> <01b06e36-823c-4f28-8db5-dc0ee0b4c063@kernel.org> Content-Language: en-US From: Qiang Yu In-Reply-To: <01b06e36-823c-4f28-8db5-dc0ee0b4c063@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Authority-Analysis: v=2.4 cv=VPPdn8PX c=1 sm=1 tr=0 ts=681b2e54 cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=dLDUmFIFFNY9evZcgTYA:9 a=QEXdDO2ut3YA:10 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: SVOMAAcLwkbfVUfj6PlgHnCuWn07ExSi X-Proofpoint-ORIG-GUID: SVOMAAcLwkbfVUfj6PlgHnCuWn07ExSi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA3MDA5MiBTYWx0ZWRfX6c1iUg6TOczc fkYFtN9r5Ec7tWrDVYsgmT4sPG/QUC3BaDEK0u3D3KRy7QjzXZQHFSwaJ4Ht6ozHiEGCUOkGhNG uwNyO9kgdzZNivNepBNY14MZn8qV4zq0RS7+4USXV2HIYREtAgfrLAbZbQUgbjVUNVR3bJFi1t4 3IF449tvQURByGxxeVGrU+Be8umFC+jIUHf6QMAFgaSeKl9avP2PmQLrAI3rhemvSb3YWPPxbDh GwyOxL2pzTLy036OsDOykgJPzLXKdhJSQUuyslSuHmDntuWb2WwLgvka8/PfKzBCusP9FCssKa0 noY9EUuiKprTdpB2Cy1n0wPWnl0zK8nE5ZeVOe3jmp+8Fi/TjT2NtH7wUFJCQtKTSTbjIlAqzIs pm9fhNMAXpmT2eWbSkmgDxKTNKo0qlCcdqF7MtwJkB0zVjkH8XySFQCYkkPwUufrUjNCFLIN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-07_03,2025-05-06_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 adultscore=0 mlxscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 malwarescore=0 mlxlogscore=995 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505070092 On 5/7/2025 4:25 PM, Krzysztof Kozlowski wrote: > On 07/05/2025 10:19, Ziyue Zhang wrote: >> On 5/7/2025 1:10 PM, Krzysztof Kozlowski wrote: >>> On Wed, May 07, 2025 at 11:10:15AM GMT, Ziyue Zhang wrote: >>>> Add compatible for qcs8300 platform, with sa8775p as the fallback. >>>> >>>> Signed-off-by: Ziyue Zhang >>>> --- >>>> .../bindings/pci/qcom,pcie-sa8775p.yaml | 26 ++++++++++++++----- >>>> 1 file changed, 19 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml >>>> index efde49d1bef8..154bb60be402 100644 >>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml >>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml >>>> @@ -16,7 +16,12 @@ description: >>>> >>>> properties: >>>> compatible: >>>> - const: qcom,pcie-sa8775p >>>> + oneOf: >>>> + - const: qcom,pcie-sa8775p >>>> + - items: >>>> + - enum: >>>> + - qcom,pcie-qcs8300 >>>> + - const: qcom,pcie-sa8775p >>>> >>>> reg: >>>> minItems: 6 >>>> @@ -45,7 +50,7 @@ properties: >>>> >>>> interrupts: >>>> minItems: 8 >>>> - maxItems: 8 >>>> + maxItems: 9 >>> I don't understand why this is flexible for sa8775p. I assume this >>> wasn't tested or finished, just like your previous patch suggested. >>> >>> Please send complete bindings once you finish them or explain what >>> exactly changed in the meantime. >>> >>> Best regards, >>> Krzysztof >> Hi Krzysztof >> Global interrupt is optional in the PCIe driver. It is not present in >> the SA8775p PCIe device tree node, but it is required for the QCS8300 > And hardware? The PCIe controller on the SA8775p is also capable of generating a global interrupt. >> I did the DTBs and yaml checks before pushing this patch. This is how >> I became aware that `maxItem` needed to be changed to 9. > If it is required for QCS8300, then you are supposed to make it required > in the binding for this device. Look at other bindings. The global interrupt is not mandatory. The PCIe driver can still function without this interrupt, but it will offer a better user experience when the device is plugged in or removed. On other platforms, the global interrupt is also optional, and `minItems` and `maxItems` are set to 8 and 9 respectively. Please refer to `qcom,pcie - sm8550.yaml`, `qcom,pcie - sm8450.yaml`, and `qcom,pcie - x1e80100.yaml`. > > Best regards, > Krzysztof -- With best wishes Qiang Yu