Devicetree
 help / color / mirror / Atom feed
From: Sumit Gupta <sumitg@nvidia.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: treding@nvidia.com, jonathanh@nvidia.com, robh@kernel.org,
	conor+dt@kernel.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
	bbasu@nvidia.com
Subject: Re: [PATCH] memory: tegra264: Add full set of MC clients
Date: Mon, 18 May 2026 16:44:52 +0530	[thread overview]
Message-ID: <c932ab10-a53d-4e95-81c8-dace918e6a01@nvidia.com> (raw)
In-Reply-To: <20260516-cautious-smart-ferret-230db8@quoll>


On 16/05/26 15:39, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, May 15, 2026 at 10:49:11PM +0530, Sumit Gupta wrote:
>> Extend the Tegra264 MC dt-bindings header and tegra264_mc_clients
>> table to cover the full set of memory clients exposed by the SoC.
>> Client name is used for MC fault reporting. Clients managed by the
>> bandwidth manager in BPMP additionally carry their bpmp_id and type.
>>
>> Entries in tegra264_mc_clients[] are sorted in increasing order of
>> their client IDs, which matches the order of the override and
>> security register offsets used in previous SoCs.
>>
>> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
>> ---
>>   drivers/memory/tegra/tegra264.c              | 564 +++++++++++++++++--
>>   include/dt-bindings/memory/nvidia,tegra264.h | 287 ++++++++++
>>   2 files changed, 819 insertions(+), 32 deletions(-)
>>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
>
> Best regards,
> Krzysztof
>

checkpatch.pl --strict reports one warning:
   WARNING: DT binding docs and includes should be a separate patch.

Will split the nvidia,tegra264.h changes into a separate patch in v2.

Thank you,
Sumit Gupta



      reply	other threads:[~2026-05-18 11:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 17:19 [PATCH] memory: tegra264: Add full set of MC clients Sumit Gupta
2026-05-15 17:46 ` sashiko-bot
2026-05-18 10:44   ` Sumit Gupta
2026-05-16 10:09 ` Krzysztof Kozlowski
2026-05-18 11:14   ` Sumit Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c932ab10-a53d-4e95-81c8-dace918e6a01@nvidia.com \
    --to=sumitg@nvidia.com \
    --cc=bbasu@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox