From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 742FFC433EF for ; Tue, 5 Jul 2022 09:46:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230470AbiGEJqy (ORCPT ); Tue, 5 Jul 2022 05:46:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230463AbiGEJqx (ORCPT ); Tue, 5 Jul 2022 05:46:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1DC4D6C; Tue, 5 Jul 2022 02:46:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7DAB66190D; Tue, 5 Jul 2022 09:46:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D51D3C341CD; Tue, 5 Jul 2022 09:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014411; bh=I3JxnK9mzNlfq3QSj73KfJmk+72j39RkmG1N22D+EEc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=svQLVRPiYTDWaDFlSeRSHAGkGSTlwdZ+RsJv8UOSSXAfcZWlnm2CgvYEplI1c+ULs 3abx6Rp+/Xs6TcwU72t2Pr+I5uqzF0GlAwCOYf9QddM0Z4PPaICLFgXExMj17T1Fax anO3CU9s4PG7vcjthtJI26goDO2F18I4MAage4E6+9UbkES0xxJoLDMKhGLKwmAU4L onViqlGL8k+yBIQ0unMeqmhMZcObPv5cMmQSKQBjK3W959v6TE5M7SPdbJhpG45Pbv T61CFKM8fN213scnSncczoFOjk3XaJJ/oInMCuDkOKLRCe04NrlyQ3LDBNTieZZUW4 15hPCIgR+Q6Ww== Message-ID: Date: Tue, 5 Jul 2022 11:46:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5 06/15] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip Content-Language: en-US To: Brad Larson , Krzysztof Kozlowski Cc: Linux ARM , Linux Kernel Mailing List , linux-mmc , Adrian Hunter , Al Cooper , Andy Shevchenko , Arnd Bergmann , blarson@amd.com, Catalin Marinas , Gabriel Somlo , gerg@linux-m68k.org, Krzysztof Kozlowski , Lee Jones , Mark Brown , Masahiro Yamada , Philipp Zabel , Pratyush Yadav , Randy Dunlap , Rob Herring , samuel@sholland.org, Serge Semin , suravee.suthikulpanit@amd.com, Tom Lendacky , Ulf Hansson , Will Deacon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20220613195658.5607-1-brad@pensando.io> <20220613195658.5607-7-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/07/2022 01:41, Brad Larson wrote: > Hi Krzysztof, > > On Mon, Jun 20, 2022 at 5:56 AM Krzysztof Kozlowski > wrote: >> >> On 13/06/2022 21:56, Brad Larson wrote: >>> From: Brad Larson >>> >>> Add support for the AMD Pensando Elba SoC System Resource chip >>> using the SPI interface. The Elba SR is a Multi-function Device >>> supporting device register access using CS0, smbus interface for >>> FRU and board peripherals using CS1, dual Lattice I2C masters for >>> transceiver management using CS2, and CS3 for flash access. >>> >>> Signed-off-by: Brad Larson >>> --- >>> .../bindings/mfd/amd,pensando-elbasr.yaml | 93 +++++++++++++++++++ >>> 1 file changed, 93 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml >> ... >>> + >>> +examples: >>> + - | >>> + #include >>> + #include >>> + >>> + spi0 { >> >> Just "spi" > > Changed to spi > >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + num-cs = <4>; >>> + >>> + spi@0 { >> >> "spi" is for SPI controllers. Use generic name matching the device. >> Usually this is "system-controller", however Rob pointed out your >> inaccurate bindings and example. > > Proposed the below change node in the reply to Rob. The model I > followed for this was the Altera mfd/altera-a10sr.c You pointed driver, so how is it related to bindings? Do not mix Linux implementation with the bindings. > > spi@0 { > sr_regs@0 { > rstc: reset-controller@0 { No underscores in node names. sr_regs is not generic name. > > dw_i2c@1 { Again, not a generic name. If it is i2c controller, should be i2c. If it is i2c device/client, should be something generic matching class of the device. > > lattice_i2c@2 { > > flash@3 { This looks ok, depending on compatible. > > Regards, > Brad Best regards, Krzysztof