From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Claudiu.Beznea@microchip.com, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, Conor.Dooley@microchip.com,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/5] dt-bindings: clocks: atmel,at91rm9200-pmc: convert to yaml
Date: Thu, 18 May 2023 09:05:19 +0200 [thread overview]
Message-ID: <c969276f-9e29-9337-44f5-aac445e061eb@linaro.org> (raw)
In-Reply-To: <d115cd4d-2a4f-552c-692c-c69ae49fe21e@microchip.com>
On 18/05/2023 08:03, Claudiu.Beznea@microchip.com wrote:
> On 17.05.2023 17:21, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 17/05/2023 11:41, Claudiu Beznea wrote:
>>> Convert Atmel PMC documentation to yaml. Along with it clock names
>>> were adapted according to the current available device trees as
>>> different controller versions accept different clock (some of them
>>> have 3 clocks as input, some has 2 clocks as inputs and some with 2
>>> input clocks uses different clock names).
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>
>>> +
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - atmel,at91rm9200-pmc
>>> + - atmel,at91sam9260-pmc
>>> + - atmel,at91sam9g20-pmc
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 2
>>> + maxItems: 2
>>> + clock-names:
>>> + items:
>>> + - const: slow_xtal
>>> + - const: main_xtal
>>> +
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - atmel,sama5d2-pmc
>>> + - atmel,sama5d3-pmc
>>> + - atmel,sama5d4-pmc
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 2
>>> + maxItems: 2
>>> + clock-names:
>>> + items:
>>> + - const: slow_clk
>>> + - const: main_xtal
>>
>> This and previous if, should be squashed. You have exactly the same then:.
>
> Clock names are different. Or do you propose to have a if for
> clocks:
> minItems: 2
> maxItems: 2
>
> and 2 ifs for clock names?
Ah, I see, they have different names - xtal -> clk.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-18 7:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 9:41 [PATCH v5 0/5] dt-bindings: clocks: at91: convert to yaml Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 1/5] ARM: dts: at91: use clock-controller name for PMC nodes Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 2/5] dt-bindings: clocks: atmel,at91rm9200-pmc: convert to yaml Claudiu Beznea
2023-05-17 12:42 ` Conor Dooley
2023-05-17 14:21 ` Krzysztof Kozlowski
2023-05-18 6:03 ` Claudiu.Beznea
2023-05-18 7:05 ` Krzysztof Kozlowski [this message]
2023-05-17 9:41 ` [PATCH v5 3/5] ARM: dts: at91: at91sam9n12: witch sckc to new clock bindings Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 4/5] ARM: dts: at91: use clock-controller name for sckc nodes Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 5/5] dt-bindings: clocks: at91sam9x5-sckc: convert to yaml Claudiu Beznea
2023-05-17 14:15 ` Krzysztof Kozlowski
2023-05-18 8:31 ` Claudiu.Beznea
2023-05-18 12:11 ` Krzysztof Kozlowski
2023-05-22 13:04 ` [PATCH v5 0/5] dt-bindings: clocks: at91: " Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c969276f-9e29-9337-44f5-aac445e061eb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).