From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Conor Dooley <conor@kernel.org>, Fabio Estevam <festevam@denx.de>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: trivial-devices: Remove the OV5642 entry
Date: Sun, 20 Aug 2023 10:14:20 +0200 [thread overview]
Message-ID: <c9758ac5-489e-3fda-9ad2-020a9cc15a04@linaro.org> (raw)
In-Reply-To: <20230801-reconcile-preamble-8713b6b09ef5@spud>
On 01/08/2023 23:57, Conor Dooley wrote:
> On Tue, Aug 01, 2023 at 06:43:58PM -0300, Fabio Estevam wrote:
>> Hi Conor,
>>
>> On 01/08/2023 18:28, Conor Dooley wrote:
>>
>>> I never said it was chief. Please re-read the quoted text.
>>
>> trivial-devices.yaml throws the following warning:
>>
>> imx6q-sabrelite.dtb: camera@42: 'clock-names', 'clocks', 'gp-gpios', 'port',
>> 'powerdown-gpios', 'reset-gpios' do not match any of the regexes:
>> 'pinctrl-[0-9]+'
>> from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
>>
>> Would it make sense to remove ovti,ov5642 from the trivial-devices bindings
>> as well as from the
>> following devicetrees?
>
> I would rather that you documented it, rather than removed it, please.
Removal from DTS is rather discouraged, because DTS and these nodes
could be used in other systems. The best is to fully document the
device, regardless whether Linux supports it or not.
Dropping from trivial-devices could work, because it does not change
much for our schema - one warning goes to other warning...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-20 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 17:00 [PATCH] dt-bindings: trivial-devices: Remove the OV5642 entry Fabio Estevam
2023-08-01 20:47 ` Conor Dooley
2023-08-01 21:10 ` Fabio Estevam
2023-08-01 21:13 ` Conor Dooley
2023-08-01 21:18 ` Fabio Estevam
2023-08-01 21:28 ` Conor Dooley
2023-08-01 21:43 ` Fabio Estevam
2023-08-01 21:57 ` Conor Dooley
2023-08-20 8:14 ` Krzysztof Kozlowski [this message]
2023-08-20 13:45 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9758ac5-489e-3fda-9ad2-020a9cc15a04@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).