From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF6DC4332F for ; Wed, 5 Oct 2022 11:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229725AbiJELAs (ORCPT ); Wed, 5 Oct 2022 07:00:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbiJELAr (ORCPT ); Wed, 5 Oct 2022 07:00:47 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDAB128E35 for ; Wed, 5 Oct 2022 04:00:45 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id j4so58476lfk.0 for ; Wed, 05 Oct 2022 04:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=SMc5GrDsQK2uk8JYuYCym6ox4vrnZK3Nab0TKqEx9uo=; b=NE+CHxHJyZm4Jmpe4nAr2MpnE8Pqtx/2we77tsoSncE4zm5laueg2i8fn/MlKMb7bV 7ch9DC1nWmhfcScP52AH6cVF7u3ebYJrVABAyJiSzQ6Zxgcv7Z78ux0GcxoRmp/hhybx qtd04M/5MOPgaBOWlJnBkf2MGcf3XXawKCvqH32lLDl76qTnQEoiHQcrOucLhP41+EfX h0/9BBhVbPOO67XxHyIEPPgfJRBvd2RTSh70bKY4+Eu7VikTcob8ySO0D3CBmmMeL7m0 magvg+2X51kF7/FLy81NEQF2DHlkHBQ7lIkiOqTYTXnQXss4kh0IrtcN6artmfeJsuRZ U/fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=SMc5GrDsQK2uk8JYuYCym6ox4vrnZK3Nab0TKqEx9uo=; b=1b/LLDfxr7CAtT7o+HjGmBTaMigXMDnZqDuZLEFT8F6nDyM8JWsZwhakCXJg2ghU8C f+dyk4q9o8kbTbApDdtM5Mo7QRGVO4Tw5HsdYVzLMZSz+KqOA/jx7ZaxYm+fsGIWgm8U VvQ+1rgnrbcnxYMxfKvB3OrgnQp+dkH1ueeNNukN6kpY5xgE0Jee6DNkfU1FC+vD+fMT d8EDqMRVIWOZ5GT0yKqxK6mow0yvt6FLNzVD/bM8JaDeLvyID00N8DznyIwsZpvk6RZU pZZiQAAydP+pLu1y/DMsc1NLyk53qGZickWkIKbEsJRpuyHnH+JrnPxFLMgmeRe6Z5De pIdw== X-Gm-Message-State: ACrzQf36CUHU/Jfmy90rEEDpkZlcR/TSS2uOdVel5mi02QTI8UmExHCa s8tDfjGK/cQMJ1KZHkOXX89yPQ== X-Google-Smtp-Source: AMsMyM7vfd2AANDdBbZLQtAL4pt6fMGDNpa4Hl2WnhysNIpRsdjVzcttIZMduNtQBrpMAx14pfYLWA== X-Received: by 2002:ac2:5f84:0:b0:4a2:2b61:289b with SMTP id r4-20020ac25f84000000b004a22b61289bmr6145634lfe.225.1664967644094; Wed, 05 Oct 2022 04:00:44 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id y1-20020ac24461000000b0048fdb3efa20sm2304701lfl.185.2022.10.05.04.00.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Oct 2022 04:00:43 -0700 (PDT) Message-ID: Date: Wed, 5 Oct 2022 13:00:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v6 2/2] dt-bindings: memory-controllers: gpmc-child: add wait-pin polarity To: "Niedermayr, BENEDIKT" , "robh@kernel.org" Cc: "rogerq@kernel.org" , "tony@atomide.com" , "devicetree@vger.kernel.org" , "linux-omap@vger.kernel.org" References: <20220929125639.143953-1-benedikt.niedermayr@siemens.com> <20220929125639.143953-3-benedikt.niedermayr@siemens.com> <20220930194257.GA756240-robh@kernel.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/10/2022 12:13, Niedermayr, BENEDIKT wrote: >>> diff --git a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc- >>> child.yaml >>> index 6e3995bb1630..477189973334 100644 >>> --- a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml >>> +++ b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml >>> @@ -230,6 +230,13 @@ properties: >>> Wait-pin used by client. Must be less than "gpmc,num-waitpins". >>> $ref: /schemas/types.yaml#/definitions/uint32 >>> >>> + gpmc,wait-pin-polarity: >> >> 'gpmc' is not a vendor. Don't continue this bad pattern, use 'ti'. > > You are right. But nevertheless I can't agree with that in this patch series. > I don't want to break consistency, since all bindings currently use 'gpmc'. At least this applies > to the "ti,gpmc-child.yaml". > > I think it makes more sense to create a complete new patch series for that specific change? This change > wouldn't fit thematically the current patch series. > So you want to add new property incorrectly named and immediately new patch which fixes the name? No, please squash this new patch into this. Best regards, Krzysztof