From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
rfoss@kernel.org, todor.too@gmail.com,
bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, akapatra@quicinc.com,
hariramp@quicinc.com, andersson@kernel.org,
konradybcio@kernel.org, hverkuil-cisco@xs4all.nl,
cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com,
will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@quicinc.com
Subject: Re: [PATCH v1 1/2] media: dt-bindings: update clocks for sc7280-camss
Date: Tue, 21 Jan 2025 13:55:02 +0100 [thread overview]
Message-ID: <c985b741-35db-4e3b-8fe4-8d2085371033@kernel.org> (raw)
In-Reply-To: <20250121120901.1841142-2-quic_vikramsa@quicinc.com>
On 21/01/2025 13:09, Vikram Sharma wrote:
> This patch change clock names to make it consistent with
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> existing platforms as gcc_cam_hf_axi -> gcc_axi_hf.
Which ones? sm8250 uses different.
> This also adds gcc_axi_sf and remove gcc_camera_ahb.
Why?
>
> This change will not break ABI because the ABI hasn't
> been cemented yet as the dtsi changes are not merged
> yet and there are no users for this driver as of now.
So why did you wait till it gets to this merge window? Or is there some
sort of history here which you hid? The user was merged to media tree
and it is going to be merged for RC1.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-21 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 12:08 [PATCH v1 0/2] Update clocks for sc7280-camss Vikram Sharma
2025-01-21 12:09 ` [PATCH v1 1/2] media: dt-bindings: update " Vikram Sharma
2025-01-21 12:55 ` Krzysztof Kozlowski [this message]
[not found] ` <1f509ab0-dd4a-4a93-90df-292bd4e6989e@quicinc.com>
2025-01-21 16:05 ` Krzysztof Kozlowski
2025-01-21 12:09 ` [PATCH v1 2/2] media: qcom: camss: update clock names for sc7280 Vikram Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c985b741-35db-4e3b-8fe4-8d2085371033@kernel.org \
--to=krzk@kernel.org \
--cc=akapatra@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hariramp@quicinc.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vikramsa@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).