From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Subject: Re: [PATCH 3/4] ARM: dts: rockchip: use pin constants to describe IO in pinctrl Date: Wed, 10 May 2017 09:25:25 +0800 Message-ID: References: <1491981044-24635-1-git-send-email-kever.yang@rock-chips.com> <1491981044-24635-3-git-send-email-kever.yang@rock-chips.com> <3966386.YQGqDXjHSp@phil> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3966386.YQGqDXjHSp@phil> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Heiko Stuebner Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Shawn Lin , Huibin Hong , Elaine Zhang , Catalin Marinas , David Wu , Brian Norris , Jaehoon Chung , Douglas Anderson , Will Deacon , Matthias Brugger , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jianqun Xu , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andy Yan , Caesar Wang , Mark Rutland , Roge List-Id: devicetree@vger.kernel.org Heiko, On 05/10/2017 05:43 AM, Heiko Stuebner wrote: > Am Mittwoch, 12. April 2017, 15:10:43 CEST schrieb Kever Yang: >> Use command below to replace the IO naming in pinctrl: >> sed -i -e 's/ 31 RK_FUNC_/ RK_PD7 RK_FUNC_/' arch/arm/boot/dts/rk* >> sed -i -e 's/ 0 RK_FUNC_/ RK_PA0 RK_FUNC_/' >> arch/arm64/boot/dts/rockchip/* >> >> Signed-off-by: Kever Yang > I'm not sure, if we really want to mass-convert each and every pin. > All pins in use right now seem to be working and it hides other > history/blame for these entries. Do you mean you want to leave the code already there as is, and new code using MACRO define for IO? This sounds reasonable, I can agree on this. I send this patch because I see there is a patch from Andy using MACRO for many IOs, but not complete enough and my patch suppose to make all Rockchip IO has update. Thanks, - Kever > > In any case though, this needs to be split into separate arm32/arm64 > patches. > > > Heiko > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html