From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B181C6FD1C for ; Thu, 23 Mar 2023 13:39:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229600AbjCWNjP (ORCPT ); Thu, 23 Mar 2023 09:39:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230335AbjCWNjM (ORCPT ); Thu, 23 Mar 2023 09:39:12 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81BF286B6 for ; Thu, 23 Mar 2023 06:39:11 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id i9so20518169wrp.3 for ; Thu, 23 Mar 2023 06:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679578750; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RM9q1gOg+w9P+KOTUpQhHbIwGykNjShMOZzaKSyx1iQ=; b=NjzgvKXkqc+RIM278bPTQrn1t9cI+t/3VL9jRA2piujrcHHZ+PmJYVyLOfbeDm++yz aravUM37bMWMsTk9Eqd1dtSbnmxOO3Rl0Aee0YED+OYRFKvZzqu3mp+ghJtcyrBQRIYQ G+a9645T+oNymG0ZQQL2XHM9Q4CGE25xaY3McGajW4mOtZxVtnf297M4fCR4gmIkbLqT 0xIy4WYFxf1a1cJnFbQqDPUCQ1ygCt1drUyTo9SjdM+8A3eYUUf1wWQkLM+Hkfx9KB/E e+hBQ1D9fca3Uu+TnF/CAg+ICgiZ9bggFsu3gkKdmCzaSlw6MR0z2r+J7JfRVqvarPsQ Akjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679578750; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RM9q1gOg+w9P+KOTUpQhHbIwGykNjShMOZzaKSyx1iQ=; b=q5dkAIP4Fyn/PSKd3ugp57FKSuOalbqO1pN1BkqQZDTvtnhsXQ5dV8xDZUAq1EV74n ZUmhZl12mtHjEJO4KhX9Ar8YoU0BBVBxqOMgHxX+L+UBt73cSMSHFjmOVvWioJXpAGGl ezOunYUPOJvZDMfPNgDgKMDMKaTuHQ5lvJufh/nYMmzD+I1uuWEK2iggveus16UbyxXS lSkUhTXV4//kWpTxKfmVhA1EQnmAoQmQPbLDwugQqIRfNF2WNfxcgqAlA2F415NQsjiC Gi4bbrCkFSPfdnvobfxkW2AupQOBce++eky3w+4oe9pNib8hN5Tu60jLV9h2yL37BCId ENeQ== X-Gm-Message-State: AAQBX9eg0E1kBWd92ZuZ0Vz79p//JFr2Xr/A/q1OQhcX4L3MgI3/TMwZ FtUyQ724AzD7g//9zgGkOois0g== X-Google-Smtp-Source: AKy350ZH1FY7ePGhbwHzMl9bczzeia8SxVlSH9MAGINKEBJLiMhxMDk0jveY4X+zupWp9je4Jini9g== X-Received: by 2002:adf:f38d:0:b0:2cf:e023:5915 with SMTP id m13-20020adff38d000000b002cfe0235915mr2774593wro.61.1679578749981; Thu, 23 Mar 2023 06:39:09 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id p5-20020adfce05000000b002d64fcb362dsm10922099wrn.111.2023.03.23.06.39.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 06:39:09 -0700 (PDT) Message-ID: Date: Thu, 23 Mar 2023 13:39:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 04/18] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add port as an optional Content-Language: en-US To: Rob Herring , Krzysztof Kozlowski Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, wcheng@codeaurora.org, caleb.connolly@linaro.org, konrad.dybcio@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com References: <20230318121828.739424-1-bryan.odonoghue@linaro.org> <20230318121828.739424-5-bryan.odonoghue@linaro.org> <3f5efb36-f9be-0816-b9cc-dc87966552cc@linaro.org> <20230321204935.GA1506038-robh@kernel.org> From: Bryan O'Donoghue In-Reply-To: <20230321204935.GA1506038-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/03/2023 20:49, Rob Herring wrote: > On Sun, Mar 19, 2023 at 12:45:13PM +0100, Krzysztof Kozlowski wrote: >> On 18/03/2023 13:18, Bryan O'Donoghue wrote: >>> port is required to instantiate a remote-endpoint which can receive >>> orientation-switch messages from a Type-C mux. >>> >>> Signed-off-by: Bryan O'Donoghue >>> --- >>> .../bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml >>> index 52886cdb0e506..1c887e34b1223 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml >>> @@ -65,6 +65,12 @@ properties: >>> description: Flag the port as possible handler of orientation switching >>> type: boolean >>> >>> + port: >>> + $ref: /schemas/graph.yaml#/properties/port >>> + description: >>> + A port node to link the PHY to a TypeC controller for the purpose of >>> + handling altmode muxing and orientation switching. >> >> Please extend the example as well. >> >> Don't you have there two ports? USB and DP? > > Or 3: USB, DP, and connector. > > Please make sure this all aligns with what Bjorn and I discussed > recently. It was for glink specifically. > > Rob This is a PHY though, the DP, USB endpoints will go into the connector or into the typec node itself. --- bod