[PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

[PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

[Timothy Pearson]

The Sony Cronos Platform Controller CPLD is a multi-purpose platform
controller that provides both a watchdog timer and an LED controller for
the Sony Interactive Entertainment Cronos x86 server platform. As both
functions are provided by the same CPLD, a multi-function device is
exposed as the parent of both functions.

Add a DT binding for this device.

Signed-off-by: Shawn Anastasio <sanastasio@raptorengineering.com>
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
---
 .../bindings/mfd/sony,cronos-cpld.yaml        | 121 ++++++++++++++++++
 1 file changed, 121 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml

diff --git a/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml b/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
new file mode 100644
index 000000000000..3cebf6c0153d
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
@@ -0,0 +1,121 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2025 Raptor Engineering, LLC
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/sony,cronos-cpld.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony Cronos Platform Controller CPLD multi-function device
+
+maintainers:
+  - Georgy Yakovlev <Georgy.Yakovlev@sony.com>
+
+description: |
+  The Sony Cronos Platform Controller CPLD is a multi-purpose platform
+  controller that provides both a watchdog timer and an LED controller for the
+  Sony Interactive Entertainment Cronos x86 server platform. As both functions
+  are provided by the same CPLD, a multi-function device is exposed as the
+  parent of both functions.
+
+properties:
+  compatible:
+    const: sony,cronos-cpld
+
+  reg:
+    maxItems: 1
+
+  leds:
+    type: object
+    additionalProperties: false
+    description: |
+      The Cronos LED controller is a subfunction of the Cronos platform
+      controller, which is a multi-function device.
+
+      Each led is represented as a child node of sony,cronos-led. Fifteen RGB
+      LEDs are supported by the platform.
+
+    properties:
+      compatible:
+        const: sony,cronos-led
+
+      reg:
+        maxItems: 1
+
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 0
+
+    patternProperties:
+      "^multi-led@[0-15]$":
+        type: object
+        $ref: leds-class-multicolor.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          reg:
+            description:
+              LED channel number (0..15)
+            minimum: 0
+            maximum: 15
+
+        required:
+          - reg
+
+    required:
+      - compatible
+      - "#address-cells"
+      - "#size-cells"
+
+  watchdog:
+    type: object
+    description: Cronos Platform Watchdog Timer
+
+    allOf:
+      - $ref: watchdog.yaml#
+
+    properties:
+      compatible:
+        const: sony,cronos-watchdog
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      cpld@3f {
+        compatible = "sony,cronos-cpld";
+        reg = <0x3f>;
+
+        watchdog {
+          compatible = "sony,cronos-watchdog";
+          timeout-sec = <20>;
+        };
+
+        leds {
+            compatible = "sony,cronos-led";
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            multi-led@0 {
+                /*
+                 * No subnodes are needed, this controller only supports RGB
+                 * LEDs.
+                 */
+                reg = <0>;
+                color = <LED_COLOR_ID_MULTI>;
+                function = LED_FUNCTION_STATUS;
+            };
+        };
+      };
+    };
-- 
2.39.5

Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

[Rob Herring (Arm)]

On Thu, 25 Sep 2025 13:17:33 -0500, Timothy Pearson wrote:
> The Sony Cronos Platform Controller CPLD is a multi-purpose platform
> controller that provides both a watchdog timer and an LED controller for
> the Sony Interactive Entertainment Cronos x86 server platform. As both
> functions are provided by the same CPLD, a multi-function device is
> exposed as the parent of both functions.
> 
> Add a DT binding for this device.
> 
> Signed-off-by: Shawn Anastasio <sanastasio@raptorengineering.com>
> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
> ---
>  .../bindings/mfd/sony,cronos-cpld.yaml        | 121 ++++++++++++++++++
>  1 file changed, 121 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml:
	Error in referenced schema matching $id: http://devicetree.org/schemas/mfd/leds-class-multicolor.yaml
	Tried these paths (check schema $id if path is wrong):
	/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/leds-class-multicolor.yaml
	/usr/local/lib/python3.13/dist-packages/dtschema/schemas/mfd/leds-class-multicolor.yaml

Lexical error: Documentation/devicetree/bindings/mfd/sony,cronos-cpld.example.dts:42.30-48 Unexpected 'LED_COLOR_ID_MULTI'
Lexical error: Documentation/devicetree/bindings/mfd/sony,cronos-cpld.example.dts:43.32-51 Unexpected 'LED_FUNCTION_STATUS'
Error: Documentation/devicetree/bindings/mfd/sony,cronos-cpld.example.dts:43.32-51 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:132: Documentation/devicetree/bindings/mfd/sony,cronos-cpld.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1525: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/948400747.1748562.1758824253627.JavaMail.zimbra@raptorengineeringinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

[Rob Herring]

On Thu, Sep 25, 2025 at 01:17:33PM -0500, Timothy Pearson wrote:
> The Sony Cronos Platform Controller CPLD is a multi-purpose platform
> controller that provides both a watchdog timer and an LED controller for
> the Sony Interactive Entertainment Cronos x86 server platform. As both
> functions are provided by the same CPLD, a multi-function device is
> exposed as the parent of both functions.
> 
> Add a DT binding for this device.
> 
> Signed-off-by: Shawn Anastasio <sanastasio@raptorengineering.com>
> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
> ---
>  .../bindings/mfd/sony,cronos-cpld.yaml        | 121 ++++++++++++++++++
>  1 file changed, 121 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml b/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
> new file mode 100644
> index 000000000000..3cebf6c0153d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
> @@ -0,0 +1,121 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2025 Raptor Engineering, LLC
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/sony,cronos-cpld.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony Cronos Platform Controller CPLD multi-function device
> +
> +maintainers:
> +  - Georgy Yakovlev <Georgy.Yakovlev@sony.com>
> +
> +description: |

Don't need '|' if no formatting or paragraphs to preserve.

> +  The Sony Cronos Platform Controller CPLD is a multi-purpose platform
> +  controller that provides both a watchdog timer and an LED controller for the
> +  Sony Interactive Entertainment Cronos x86 server platform. As both functions
> +  are provided by the same CPLD, a multi-function device is exposed as the
> +  parent of both functions.
> +
> +properties:
> +  compatible:
> +    const: sony,cronos-cpld
> +
> +  reg:
> +    maxItems: 1
> +
> +  leds:
> +    type: object
> +    additionalProperties: false
> +    description: |
> +      The Cronos LED controller is a subfunction of the Cronos platform
> +      controller, which is a multi-function device.
> +
> +      Each led is represented as a child node of sony,cronos-led. Fifteen RGB
> +      LEDs are supported by the platform.
> +
> +    properties:
> +      compatible:
> +        const: sony,cronos-led
> +
> +      reg:
> +        maxItems: 1
> +
> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 0
> +
> +    patternProperties:
> +      "^multi-led@[0-15]$":
> +        type: object
> +        $ref: leds-class-multicolor.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          reg:
> +            description:
> +              LED channel number (0..15)
> +            minimum: 0
> +            maximum: 15
> +
> +        required:
> +          - reg
> +
> +    required:
> +      - compatible
> +      - "#address-cells"
> +      - "#size-cells"
> +
> +  watchdog:
> +    type: object
> +    description: Cronos Platform Watchdog Timer
> +
> +    allOf:
> +      - $ref: watchdog.yaml#
> +
> +    properties:
> +      compatible:
> +        const: sony,cronos-watchdog

There's no need for a child node here. 'timeout-sec' can just go in the 
parent node.

Rob

Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

[Timothy Pearson]

----- Original Message -----
> From: "robh" <robh@kernel.org>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "devicetree" <devicetree@vger.kernel.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "Conor Dooley"
> <conor+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Lee Jones" <lee@kernel.org>, "Georgy
> Yakovlev" <Georgy.Yakovlev@sony.com>, "Shawn Anastasio" <sanastasio@raptorengineering.com>
> Sent: Monday, September 29, 2025 9:11:13 AM
> Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

> On Thu, Sep 25, 2025 at 01:17:33PM -0500, Timothy Pearson wrote:
>> The Sony Cronos Platform Controller CPLD is a multi-purpose platform
>> controller that provides both a watchdog timer and an LED controller for
>> the Sony Interactive Entertainment Cronos x86 server platform. As both
>> functions are provided by the same CPLD, a multi-function device is
>> exposed as the parent of both functions.
>> 
>> Add a DT binding for this device.
>> 
>> Signed-off-by: Shawn Anastasio <sanastasio@raptorengineering.com>
>> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
>> ---
>>  .../bindings/mfd/sony,cronos-cpld.yaml        | 121 ++++++++++++++++++
>>  1 file changed, 121 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
>> 
>> diff --git a/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
>> b/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
>> new file mode 100644
>> index 000000000000..3cebf6c0153d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
>> @@ -0,0 +1,121 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +# Copyright 2025 Raptor Engineering, LLC
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/sony,cronos-cpld.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Sony Cronos Platform Controller CPLD multi-function device
>> +
>> +maintainers:
>> +  - Georgy Yakovlev <Georgy.Yakovlev@sony.com>
>> +
>> +description: |
> 
> Don't need '|' if no formatting or paragraphs to preserve.
> 
>> +  The Sony Cronos Platform Controller CPLD is a multi-purpose platform
>> +  controller that provides both a watchdog timer and an LED controller for the
>> +  Sony Interactive Entertainment Cronos x86 server platform. As both functions
>> +  are provided by the same CPLD, a multi-function device is exposed as the
>> +  parent of both functions.
>> +
>> +properties:
>> +  compatible:
>> +    const: sony,cronos-cpld
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  leds:
>> +    type: object
>> +    additionalProperties: false
>> +    description: |
>> +      The Cronos LED controller is a subfunction of the Cronos platform
>> +      controller, which is a multi-function device.
>> +
>> +      Each led is represented as a child node of sony,cronos-led. Fifteen RGB
>> +      LEDs are supported by the platform.
>> +
>> +    properties:
>> +      compatible:
>> +        const: sony,cronos-led
>> +
>> +      reg:
>> +        maxItems: 1
>> +
>> +      "#address-cells":
>> +        const: 1
>> +
>> +      "#size-cells":
>> +        const: 0
>> +
>> +    patternProperties:
>> +      "^multi-led@[0-15]$":
>> +        type: object
>> +        $ref: leds-class-multicolor.yaml#
>> +        unevaluatedProperties: false
>> +
>> +        properties:
>> +          reg:
>> +            description:
>> +              LED channel number (0..15)
>> +            minimum: 0
>> +            maximum: 15
>> +
>> +        required:
>> +          - reg
>> +
>> +    required:
>> +      - compatible
>> +      - "#address-cells"
>> +      - "#size-cells"
>> +
>> +  watchdog:
>> +    type: object
>> +    description: Cronos Platform Watchdog Timer
>> +
>> +    allOf:
>> +      - $ref: watchdog.yaml#
>> +
>> +    properties:
>> +      compatible:
>> +        const: sony,cronos-watchdog
> 
> There's no need for a child node here. 'timeout-sec' can just go in the
> parent node.

Could you elaborate on this please?  As far as I can tell we ref watchdog.yaml and need some kind of compatible string, so why would I break out timeout-sec directly here?

Thanks!

Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

[Krzysztof Kozlowski]

On 20/10/2025 17:34, Timothy Pearson wrote:
>>> +  watchdog:
>>> +    type: object
>>> +    description: Cronos Platform Watchdog Timer
>>> +
>>> +    allOf:
>>> +      - $ref: watchdog.yaml#
>>> +
>>> +    properties:
>>> +      compatible:
>>> +        const: sony,cronos-watchdog
>>
>> There's no need for a child node here. 'timeout-sec' can just go in the
>> parent node.
> 
> Could you elaborate on this please?  As far as I can tell we ref watchdog.yaml and need some kind of compatible string, so why would I break out timeout-sec directly here?


Please look where the comment was placed. Under $ref? No. Under this
compatible. $ref goes to the parent, obviously.

You do not need kind of compatible string. Parent already has one. You
do not need compatible strings at all to instantiate Linux drivers.
That's pretty common pattern for most of MFD-like devices, plenty of
examples in the kernel.


Best regards,
Krzysztof

Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

[Timothy Pearson]

----- Original Message -----
> From: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "robh" <robh@kernel.org>
> Cc: "devicetree" <devicetree@vger.kernel.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "Conor Dooley"
> <conor+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Lee Jones" <lee@kernel.org>, "Georgy
> Yakovlev" <Georgy.Yakovlev@sony.com>, "Shawn Anastasio" <sanastasio@raptorengineering.com>
> Sent: Monday, October 20, 2025 10:58:40 AM
> Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

> On 20/10/2025 17:34, Timothy Pearson wrote:
>>>> +  watchdog:
>>>> +    type: object
>>>> +    description: Cronos Platform Watchdog Timer
>>>> +
>>>> +    allOf:
>>>> +      - $ref: watchdog.yaml#
>>>> +
>>>> +    properties:
>>>> +      compatible:
>>>> +        const: sony,cronos-watchdog
>>>
>>> There's no need for a child node here. 'timeout-sec' can just go in the
>>> parent node.
>> 
>> Could you elaborate on this please?  As far as I can tell we ref watchdog.yaml
>> and need some kind of compatible string, so why would I break out timeout-sec
>> directly here?
> 
> 
> Please look where the comment was placed. Under $ref? No. Under this
> compatible. $ref goes to the parent, obviously.

This is not an area of the kernel I'm normally changing, so I appreciate the insight.  None of this yaml syntax is particularly obvious the first time it's encountered, at least not to me.

> You do not need kind of compatible string. Parent already has one. You
> do not need compatible strings at all to instantiate Linux drivers.
> That's pretty common pattern for most of MFD-like devices, plenty of
> examples in the kernel.

Understood.

Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

[Krzysztof Kozlowski]

On 20/10/2025 18:01, Timothy Pearson wrote:
> 
> 
> ----- Original Message -----
>> From: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "robh" <robh@kernel.org>
>> Cc: "devicetree" <devicetree@vger.kernel.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "Conor Dooley"
>> <conor+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Lee Jones" <lee@kernel.org>, "Georgy
>> Yakovlev" <Georgy.Yakovlev@sony.com>, "Shawn Anastasio" <sanastasio@raptorengineering.com>
>> Sent: Monday, October 20, 2025 10:58:40 AM
>> Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld
> 
>> On 20/10/2025 17:34, Timothy Pearson wrote:
>>>>> +  watchdog:
>>>>> +    type: object
>>>>> +    description: Cronos Platform Watchdog Timer
>>>>> +
>>>>> +    allOf:
>>>>> +      - $ref: watchdog.yaml#
>>>>> +
>>>>> +    properties:
>>>>> +      compatible:
>>>>> +        const: sony,cronos-watchdog
>>>>
>>>> There's no need for a child node here. 'timeout-sec' can just go in the
>>>> parent node.
>>>
>>> Could you elaborate on this please?  As far as I can tell we ref watchdog.yaml
>>> and need some kind of compatible string, so why would I break out timeout-sec
>>> directly here?
>>
>>
>> Please look where the comment was placed. Under $ref? No. Under this
>> compatible. $ref goes to the parent, obviously.
> 
> This is not an area of the kernel I'm normally changing, so I appreciate the insight.  None of this yaml syntax is particularly obvious the first time it's encountered, at least not to me.

Sure, apologies for sounding harsh.

> 
>> You do not need kind of compatible string. Parent already has one. You
>> do not need compatible strings at all to instantiate Linux drivers.
>> That's pretty common pattern for most of MFD-like devices, plenty of
>> examples in the kernel.
> 

Maybe this will be useful - bd96801_wdt.c is example driver which
follows correct design and takes timeout from the parent (wd->dev is
parent of watchdog platform device), although parent's bindings lack
$ref to watchdog. I'll fix that.


> Understood.


Best regards,
Krzysztof