From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1572B357D08 for ; Tue, 12 May 2026 07:05:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778569537; cv=none; b=NM3ozSt0oATYbFe4qqn+qdyK7SmSjfRm0qnxZVAcOM9qvqIiAPm8wc4mZSkfyc9VR2asYnrGUcfjOzXpiv0eRgwdLAqqWnkTw8x0kkR17sszZ4KsZBXloZmGCSZUgFYw844yz45P3olvuZo6cHdpDOcYFl5aaXgWLLyPbcVeT+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778569537; c=relaxed/simple; bh=S1y/611h5F1yDCLY2MwHHiifJrIn907EP4/nio92UgI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pCWX/szQ8b0LOAGWHBBeEZzu+c188pfdFFPqvBTEuxIUDB1Xg/ONA2OA65/HZqRR6M+sqWdU+FyX93dy8pBD9CPeQWur0R0VLm37lL5k1CXKAF0Z/vdQ6t8/jEZgd+buFgPDB2S7MGn8TzyLzONRV5nmK8X3z0p0QfpsZxuXqYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BK0C75Yv; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BK0C75Yv" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b9d9971d059so758045866b.2 for ; Tue, 12 May 2026 00:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778569530; x=1779174330; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+au2wZMjR4hSPfSatgV6boyFWtlvztIAKTjtpXaCIFs=; b=BK0C75YvBPrANr+ri1CVo6P8WvyLhqIh/Y8/a0IL6DEoVektjOYyfz7oy7+8++me+/ wbTTyApThqtCx2Cmgo/qca4BBMIWVbILm9OTbHkQtnoV5zKbe1c2mSpbAQhNLJSb3+UZ t48MvJb/QbnP0pTt0MVfCq2bYMDsOtOwcwZpWENRVtAhCpyDKp0qviirwqWltOh/c9Ld F7wyLcNcyThyVFqc8QiUQJjWShddmJLDMbdi3e2ZIp+GREcuT5WXkHoCjXqULz1zr4Qy VziaOY5j8TvaMu/nAQtf/9+T2DYkrsgIJEYDk/jNo/4MwEgT9Tcbn6EORGPS/N6UNYpY 4pRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778569530; x=1779174330; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+au2wZMjR4hSPfSatgV6boyFWtlvztIAKTjtpXaCIFs=; b=DavkqIbL7pD0FqDqWbG/R6uF3KWx95M0VINQX08FtZWizANk8sA+WOZG6UC8avpiNJ lp6EXeBrzwMQDk08I1gtRvoRmT8nQDFVDdmgPb9f+6XFFQHs5tuJ6bg0sLyGxF4OW+Tw BxEqlMtASoRLlrdmePGkUNvzz8keaw3+wyxmwA4X90WA4JDTJtrzVJs79FawEd6fYSjx 634Lc+G77HJfprX4Svsi1aBieV6cKxNJPcz4+jtKU5vktio0DCk2qxxwmbe7lujXd+eJ igetmBJHvt9oCru8aE9CtmLGaR4QTLYB+aE4BwfOU6CkwKfOryUkVt55ZG5SsZLY1r2w 1H3w== X-Forwarded-Encrypted: i=1; AFNElJ8nsd/chDm3zCj9+K/Ucpzo+xsDL1Az5lr1jEOI8MKGc2x6puu0Ikv4onx7f4gEvJtp4YMti81hsFtJ@vger.kernel.org X-Gm-Message-State: AOJu0Yy2KUhXMDeYPwrSaZ89GkdIGu/5HLRK3XQUCOj5YwWB5TFN9NXP Jl9ssELXLx7szlK4Z4XGQPM9cnFEvB+KNm5okcYDTJiQjYEa23mhK5PK X-Gm-Gg: Acq92OEh/dHq88v5R8ZZtKxLqmkD7oFVRDdE4x2DVmKLgt+kPhheDRcM3NQndn/LH/r Vo0D9sMDe7G7mvRYqK1LcDaB8AQhAcgBtVuYI2Utlu1hYY4d7MTZOWR49H2rRSc15ATQAX0oB9R 7wUtsoqi9iBvR4nvS1AFVAcSiBCaw/pSxOxrDavp+F+d+U72MhltJHGT3mY/sj2Mpbc4taFFm7R 9y1m6UL7tU6dX4T+R3eHvQ9gI9u1U7xwTBkKbE8FHg3/9Y4HBVQPU7XEiM6YSiiHncl6s4234ke qkF62fIoEJqwoRCIZoHJBLTtCAXIUw++bl468wDNrtbE8JhS9X9xABt0+Deku9FDncKk5V+wCJw MlW6dXj31lwpITCqoippO7VOw5fX7VvGgXMzjw9lzbqLJrn0ec8TDbPusxeDtDVJveg9NHoLG0H EEGpkYgDxGGhqf7Pu382WnNjz4eVTiu2Q88R5pSy6RRXKzGuAr73S4/x+pZQyK+rw+jzD2 X-Received: by 2002:a17:907:e113:b0:bd2:27c4:f453 with SMTP id a640c23a62f3a-bd227c4f500mr115768566b.9.1778569529638; Tue, 12 May 2026 00:05:29 -0700 (PDT) Received: from ?IPV6:2a00:f502:160:4e2:a099:cad9:2ecd:93de? ([2a00:f502:160:4e2:a099:cad9:2ecd:93de]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67ef0e2c317sm4646281a12.31.2026.05.12.00.05.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 00:05:29 -0700 (PDT) Message-ID: Date: Tue, 12 May 2026 10:05:26 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/9] media: qcom: venus: Add msm8939 resource struct To: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Brian Masney Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Dmitry Baryshkov References: <20260506-msm8939-venus-rfc-v4-0-994f5eb22acb@gmail.com> <0TaxINYCitQd2DsGsbhRviwmrQkaaVMaE9vABS3gSsSPNfrgS3JPTIo_kvTzyEhGOAZuMVq-k-5T8mqDM7dnIw==@protonmail.internalid> <20260506-msm8939-venus-rfc-v4-3-994f5eb22acb@gmail.com> <108401cb-040a-441c-b463-b69df195378e@kernel.org> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: <108401cb-040a-441c-b463-b69df195378e@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/6/26 2:33 AM, Bryan O'Donoghue wrote: > On 05/05/2026 22:44, Erikas Bitovtas wrote: >> +    .vcodec_clks = { "core0", "core1" }, >> +    .vcodec_clks_num = 2, > > This smells a bit dodgy to me. > > You already have > > struct clk *vcodec0_clks[VIDC_VCODEC_CLKS_NUM_MAX]; > struct clk *vcodec1_clks[VIDC_VCODEC_CLKS_NUM_MAX]; > > so why add vcodec_clks and put core0 and core1 into a new array. > vcodec0_clks and vcodec1_clks seem like a very natural place for core0 > and core1 clocks to live ? > Sashiko found some power management issues in my code, so I'm coming back to this. The idea is to call vcodec_clks_get only once for inline cores, thus avoiding duplicate clock assignment. Attaching to vcodec{0,1}_clks instead would mean we're adding the same clocks twice. I dropped it in later revisions, but now I want to re-introduce this, then add them in core_get_v1 instead of {vdec,venc}_get_v1.> --- > bod