From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019A4C433FE for ; Thu, 7 Apr 2022 06:22:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241046AbiDGGYj (ORCPT ); Thu, 7 Apr 2022 02:24:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241000AbiDGGYd (ORCPT ); Thu, 7 Apr 2022 02:24:33 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6625CCB037; Wed, 6 Apr 2022 23:22:28 -0700 (PDT) X-UUID: 634795d8d3e34ebd85765f82cca8dd7e-20220407 X-UUID: 634795d8d3e34ebd85765f82cca8dd7e-20220407 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1335707426; Thu, 07 Apr 2022 14:22:24 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 7 Apr 2022 14:22:22 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 7 Apr 2022 14:22:22 +0800 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8183 From: Rex-BC Chen To: Krzysztof Kozlowski , , , CC: , , , , , , , , , , , , Date: Thu, 7 Apr 2022 14:22:22 +0800 In-Reply-To: <397e30c2-18c3-93d6-16f5-b113be77f51a@linaro.org> References: <20220406094654.29722-1-rex-bc.chen@mediatek.com> <20220406094654.29722-2-rex-bc.chen@mediatek.com> <397e30c2-18c3-93d6-16f5-b113be77f51a@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 2022-04-06 at 16:44 +0200, Krzysztof Kozlowski wrote: > On 06/04/2022 11:46, Rex-BC Chen wrote: > > The driver data of MT8183 and MT8173 are different. > > The value of has_gamma for MT8173 is true while the value of MT8183 > > is > > false. Therefore, the compatible of disp_aal for MT8183 is not > > suitable > > for the compatible for MT8173. > > Just because one feature is not supported, it does not mean they are > incompatible, which you claim in the patch below. Are you sure they > are > really incompatible and MT8173 fallback cannot be used? > > > Best regards, > Krzysztof Hello Krzysztof, Thanks for your review. The difference of disp_aal for each MediaTek SoCs is "has_gamma". And we only control this variable for different MediaTek SoCs. The value of has_gamma for MT8173 is true. The value of has_gamma for MT8183 is false. (Moreover, the driver data is null for MT8183) >From this situation, I think it's not compatible between MT8173 and MT8183. reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mediatek/mtk_disp_aal.c?h=v5.18-rc1#n153 BRs, Rex