From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA000C433FE for ; Tue, 15 Nov 2022 13:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238283AbiKONIF (ORCPT ); Tue, 15 Nov 2022 08:08:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238137AbiKONH5 (ORCPT ); Tue, 15 Nov 2022 08:07:57 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40B462A411 for ; Tue, 15 Nov 2022 05:07:56 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id j4so24385409lfk.0 for ; Tue, 15 Nov 2022 05:07:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UBJBQbBMlMmd7V0JpeZBtsA3DhYWso8sxLsDK2tqGUs=; b=ZJq/7J3mBFpZpKRcyciB8c3k9If8s4TJ9Fs/6Gdk/OSb6dj9ULeJBxvRGZxYZAL3SS btx+DG0MOtdXsRe3PXjzE6HcsK5pW+yEOprjXjTV2r8jMf4Ueiqh8gIz0FatRiE9ZNO1 VsKaV8wQLgRt8Z14GBjhG9aUsZW7bqi3WJsND8dlpH9BlzfWIelDkLo74WE3Nr1kyPGB 8ZRAF/FCAWqt15DJAzJpF/KaPSbAUybsLNW1vbJ1PKRlzLO6k5eX3zz2HCprQpLnMefV 9HvmntHWFXavknrll/SHKAk17FQSrH/m2wWyybn8HgAxF7X9y+eeh45AvY2XxbGUZxb4 4K/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UBJBQbBMlMmd7V0JpeZBtsA3DhYWso8sxLsDK2tqGUs=; b=tYQyNaozr9WwrXRUihWd0407F5vh8Ox89p1AvGpid3Zv0/LjCppR5k7hqN//p6UG1W asf319EHlLcvhg5nFVZSskoMU4CNP3j9a0Gz97/7GVk2JbcqH0JLZSNXhPcldS/1UVSC nrdomgoRyLW5k2uBLtvNh4F/rJg9+wP4tQtDamGlheqHW6gv0R5h8M68sg+CdnAUMqnP uTZAqMsy1PVro8n/P53Y7K/SAiDArqxPd61IVng72iTpnNZSF3lqu7f5TD/15Rj4HzPn 9uPfWssXdJBbS0J/rflnMDdnxNeyvSwTNgTPvmPn9X5jfEp3100C6esL9PEwe+WHfYpE /NkQ== X-Gm-Message-State: ANoB5pnlvvouA6I+lJBt4XAbv9U0VqJDY3y8EBc1R2oOkbqflBoi1Lz2 indcAXpSjbjR5HtXRYBU5E7Jmg== X-Google-Smtp-Source: AA0mqf4gbD4DD6OxXBHy5q68FOYR9L+0Cf+XWUOqhm+ul9x3BuzZfPL1VH2lsviiirfkCFxML6tXtA== X-Received: by 2002:a05:6512:3f2:b0:4a2:3e6c:a32b with SMTP id n18-20020a05651203f200b004a23e6ca32bmr5413822lfq.54.1668517674600; Tue, 15 Nov 2022 05:07:54 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id t23-20020a2e8e77000000b0026c2d2a9b92sm2426054ljk.101.2022.11.15.05.07.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 05:07:53 -0800 (PST) Message-ID: Date: Tue, 15 Nov 2022 14:07:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 2/7] dt-bindings: clock: renesas,r9a06g032-sysctrl: Add h2mode property Content-Language: en-US From: Krzysztof Kozlowski To: Herve Codina , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Greg Kroah-Hartman , Magnus Damm , Gareth Williams Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Thomas Petazzoni , Miquel Raynal References: <20221114111513.1436165-1-herve.codina@bootlin.com> <20221114111513.1436165-3-herve.codina@bootlin.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/11/2022 14:05, Krzysztof Kozlowski wrote: > On 14/11/2022 12:15, Herve Codina wrote: >> Add the h2mode property to force the USBs mode ie: >> - 2 hosts >> or >> - 1 host and 1 device >> >> Signed-off-by: Herve Codina >> --- >> .../bindings/clock/renesas,r9a06g032-sysctrl.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml b/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml >> index 95bf485c6cec..f9e0a58aa4fb 100644 >> --- a/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml >> +++ b/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml >> @@ -39,6 +39,16 @@ properties: >> '#power-domain-cells': >> const: 0 >> >> + renesas,h2mode: >> + description: | >> + Configure the USBs mode. >> + - <0> : the USBs are in 1 host and 1 device mode. >> + - <1> : the USBs are in 2 host mode. >> + If the property is not present, the value used is the one already present >> + in the CFG_USB register (from reset or set by the bootloader). >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + enum: [0, 1] > > 0/1 are quite cryptic. Why not making it a string which is easy to read > and understand? Can be something like "two-hosts" and "one-host". Or > anything you find more readable... ...but actually you should rather make it a property of your USB controller, not clock controller. You have two controllers and we have a generic property for them - dr_mode. Best regards, Krzysztof