devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Walker Chen <walker.chen@starfivetech.com>
To: Xingyu Wu <xingyu.wu@starfivetech.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Claudiu Beznea <Claudiu.Beznea@microchip.com>,
	Jaroslav Kysela <perex@perex.cz>, "Takashi Iwai" <tiwai@suse.com>,
	Maxim Kochetkov <fido_max@inbox.ru>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: Jose Abreu <joabreu@synopsys.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
	<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v2 4/5] riscv: dts: starfive: pinfunc: Fix the pins name of I2STX1
Date: Wed, 23 Aug 2023 10:45:16 +0800	[thread overview]
Message-ID: <c9ac528a-e1c2-0f64-c50e-30fc1eb6e9ac@starfivetech.com> (raw)
In-Reply-To: <20230821144151.207339-5-xingyu.wu@starfivetech.com>



On 2023/8/21 22:41, Xingyu Wu wrote:
> These pins are actually I2STX1 clock input, not I2STX0,
> so their names should be changed.
> 
> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
> ---
>  arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
> index fb0139b56723..256de17f5261 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
> +++ b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h
> @@ -240,8 +240,8 @@
>  #define GPI_SYS_MCLK_EXT			30
>  #define GPI_SYS_I2SRX_BCLK			31
>  #define GPI_SYS_I2SRX_LRCK			32
> -#define GPI_SYS_I2STX0_BCLK			33
> -#define GPI_SYS_I2STX0_LRCK			34
> +#define GPI_SYS_I2STX1_BCLK			33
> +#define GPI_SYS_I2STX1_LRCK			34
>  #define GPI_SYS_TDM_CLK				35
>  #define GPI_SYS_TDM_RXD				36
>  #define GPI_SYS_TDM_SYNC			37

Reviewed-by: Walker Chen <walker.chen@starfivetech.com>
Thanks!

  reply	other threads:[~2023-08-23  2:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21 14:41 [PATCH v2 0/5] Add I2S support for the StarFive JH7110 SoC Xingyu Wu
2023-08-21 14:41 ` [PATCH v2 1/5] ASoC: dt-bindings: snps,designware-i2s: Add StarFive JH7110 SoC support Xingyu Wu
2023-08-22 19:34   ` Krzysztof Kozlowski
2023-08-21 14:41 ` [PATCH v2 2/5] ASoC: dwc: Use ops to get platform data Xingyu Wu
2023-08-21 14:41 ` [PATCH v2 3/5] ASoC: dwc: i2s: Add StarFive JH7110 SoC support Xingyu Wu
2023-08-21 14:41 ` [PATCH v2 4/5] riscv: dts: starfive: pinfunc: Fix the pins name of I2STX1 Xingyu Wu
2023-08-23  2:45   ` Walker Chen [this message]
2023-08-23 13:19   ` Rob Herring
2023-08-21 14:41 ` [PATCH v2 5/5] riscv: dts: starfive: Add the nodes and pins of I2Srx/I2Stx0/I2Stx1 Xingyu Wu
2023-08-23  2:42   ` Walker Chen
2023-08-23 19:54 ` (subset) [PATCH v2 0/5] Add I2S support for the StarFive JH7110 SoC Mark Brown
2023-09-13 13:42 ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9ac528a-e1c2-0f64-c50e-30fc1eb6e9ac@starfivetech.com \
    --to=walker.chen@starfivetech.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=broonie@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.renner.berthing@canonical.com \
    --cc=fido_max@inbox.ru \
    --cc=joabreu@synopsys.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    --cc=xingyu.wu@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).