From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B0BAC54EE9 for ; Thu, 8 Sep 2022 11:54:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbiIHLyP (ORCPT ); Thu, 8 Sep 2022 07:54:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231314AbiIHLyE (ORCPT ); Thu, 8 Sep 2022 07:54:04 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40A6111C7E3 for ; Thu, 8 Sep 2022 04:54:02 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id bt10so27314364lfb.1 for ; Thu, 08 Sep 2022 04:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=VQGJlHRUp9nhyc0mzEwq4F9INwDBtUr5VdutZE2f0C0=; b=rpOWzDfsWc/FX3v+6r9PYQh7U5C1YOoTSXb4txAsmoBQGG3ORBVLbBqvRIDdYVpFPY t115kYTzdwfuixU/4HZIsr5zkGaN68n2B0DoEP1z5MM9pKZKuP4NIJmNfhvCw9X+Sc7z PDI+/+OhZucTNjh6kzCSGVKicS0be6JqB0iMm7ALH8KKSZW5sPfSMOGznKBiHBSxvk5C xjJIC9J3jw9cWTaHgS2O8bbAROKO7fYmZXCLPSEsElj7SMMte8pY6XU5UH8zD4dRe3RY XCCKmdAtnSxG6PpMuZP/D8DVBoMYxRPkik02ETeOtYTfbhKn8J+ebinCesIW28MgpZEf xW6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=VQGJlHRUp9nhyc0mzEwq4F9INwDBtUr5VdutZE2f0C0=; b=HvqE/x2M0J6lctFqJIwBi0rd+4Ts6wWcsDUAQFyc3cPQNVNA/brfTp4RnXQQnBeTNi uUiY/+ETi4OUyZXYQNLBcs7SYNCm/b/1wIMKHfqSv8EPDTt9jw3QsrOUKOymugJrCOmc BHPsciQjoxmFoH/UOM1mjgcNUmLG1ZUMDQaFC5ILTNhjOxs1ws5qDjm/d3Ide2zt6zVI TyNCktazYFjwaf87fvfI/aem29Bq+KUh3hASbjUEOFvqhE7/UfD3G3SlmGkPG6AedscX H4kSMP+9g6jSZ8fjeCSJNA+NdKVzSprr5GO9sbAmNPrvQBP0gcPsD0UQ10ALxYoCW+90 M6LQ== X-Gm-Message-State: ACgBeo1fFo/xjlwHVX+Vf5H8SetCzV2hRHXzp4586FigDLnbOgXSdQ/4 QELGiaGJODU4UtnZs1PFVu7LHw== X-Google-Smtp-Source: AA6agR55o8YlOLOcDDvDdE3Ln5Z6r6dux+o/bKmvUpIRktp1YWOKL8JyrdpmTvZvgjal7Wn8hbwa3Q== X-Received: by 2002:a05:6512:1581:b0:492:8c61:5bef with SMTP id bp1-20020a056512158100b004928c615befmr2732713lfb.518.1662638040100; Thu, 08 Sep 2022 04:54:00 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u9-20020a056512094900b0048b143c09c2sm3001480lft.259.2022.09.08.04.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 04:53:59 -0700 (PDT) Message-ID: Date: Thu, 8 Sep 2022 13:53:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 4/8] arm64: dts: rockchip: add the internal audio codec Content-Language: en-US To: luca.ceresoli@bootlin.com, alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Jaroslav Kysela , Takashi Iwai , Nicolas Frattaroli , Philipp Zabel , Johan Jonker , Chris Morgan References: <20220907142124.2532620-1-luca.ceresoli@bootlin.com> <20220907142124.2532620-5-luca.ceresoli@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20220907142124.2532620-5-luca.ceresoli@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote: > From: Luca Ceresoli > > The RK3308 has a built-in audio codec that connects internally to i2s_8ch_2 > or i2s_8ch_3. > > Signed-off-by: Luca Ceresoli > --- > arch/arm64/boot/dts/rockchip/rk3308.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3308.dtsi b/arch/arm64/boot/dts/rockchip/rk3308.dtsi > index 093b70563b23..221cde49dc98 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3308.dtsi > @@ -808,6 +808,20 @@ cru: clock-controller@ff500000 { > assigned-clock-rates = <32768>; > }; > > + acodec: acodec@ff560000 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof