From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEFCE3B42F2 for ; Fri, 18 Sep 2026 09:50:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789725026; cv=none; b=FVfnFAYHVN4IRjXQbrrMRU9xHO8rAW+oiRqfrm38A9gb76o31udMAvJdedFgZCObMuXsiibvArDYbhmxhxdePwvl9nUV7FuoXkExP1oC95Wnq7x2ON7ZzbPRuY8lcDfFEgESK1o32BjA7TPEeRmjv0WVs6E8MXZ9hbbONt0SH1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789725026; c=relaxed/simple; bh=G1HMwfljY4tDGdeins5kPBg3mM7ZJ/xqQQwjAIb5wh4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uAr1iOcBL9giH4lisDokfxTdV87SBCmDUxtRpy/5W/mi9Ud5Io/r+4AywW6eDiW1gFOD2I1ez9uIlRTGvAHque0d7F8Oinjr7Ed8bvdIWFUJqiWbNIsCocQA4dN/WVtcARfGcI0KzgkQvhD9qRn/1dEBNBUOJ+TwGZDFP73T+pU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k1QeVg6E; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JOpUZYtD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k1QeVg6E"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JOpUZYtD" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I9dZKF385301 for ; Fri, 18 Sep 2026 09:50:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ts2ohB7kaU7wSXWdRJOkbNTM3yTrx79Rg8Aw727zObA=; b=k1QeVg6EJTJx+Vq6 7NgS+LiufPMN2PcdRpV/LTgZw2vpxy4Ex8AbkoYrXIk96h+EJxR/IQENX1S+N8zl A0pjZu7CPXg0B6PT0r7HRetreNVuW9IuehDdDTYZ5myuEs4V9rATmxfo7BtfIzac YmPmkzOaWo6zq6xqtdq94fK5SKDeHxSIK7I04NHF20I7L0TvGwCXejj7Q2UAo8en YJESoBOjxQx2wWl8YKMx9X2Wo/4iVbeykYlMtwkWQx5c+OTwtsv0xlZYGQUFnqCn X7nLHNdFNckjbvrRnsuhGgipMtQXY/CFB8e+3Lj9z7/aAUEdnLD8gUKayu+G7Z7O OzoFAA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4grwxrsagu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 18 Sep 2026 09:50:23 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-939f8e7ff71so14809485a.3 for ; Fri, 18 Sep 2026 02:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789725018; x=1790329818; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ts2ohB7kaU7wSXWdRJOkbNTM3yTrx79Rg8Aw727zObA=; b=JOpUZYtDzh1CVYIBUrM1IsswXEfW2HNJOJJyre1IPCrNCXx/JjczDy/0E1niy0t7xL +CBXb5NLZC7RRwbL7xtzsrcNHJu98KudeQn5hYq8hD4hhq29qMrA7Xw9VYgXdE5SUn5H TTWhVFQt/k740FlbJXm8rj/VbKgfCoCQQl/WlRNaEFWLuJA11OevzaDeUHuF6qDJxT4A DcOWjkfPe8TtUvGNT/UZ2uW2qlNa4wSxJmShvtfM6EANesKfHxjzHn8ysix32NoAuAbz i3CHFGysfC6JU6YDnb90nt7GfcR08uUIaY4Xr/h/E2bLBV75Ee8F+Y13ZzojQNV5UOAw vPUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789725018; x=1790329818; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ts2ohB7kaU7wSXWdRJOkbNTM3yTrx79Rg8Aw727zObA=; b=v2dporQJIusBpzK2VHCa4xGZXAzO9F7SJzU7i7Sa+9t9HXTaOQhQBgHACYUztg7FAI HqwWcYg1QLE6srP7k3l3bNA37I64q7gtX7yjin7lS67TKfELRxvzdAYkfSzcuFxcYw9I EzLGCuCysqDDkrS6rP6Ryo9ugVWCoOTG59EkyBW6H3MTvTsXwbyQb90Q4yAqWdY93rbi 0POD5UGlJ5aB1NpzPvgGZZ7nVFBaYCfvjEaFvC1CRmR8DQLe6xGHiT06E4vjdyY08bY+ LiLb1GtEaQdyWRH3oA/2lDfkZ3dYz0GdnGWpjfsh378LoRhN7iAA4lj+CN9P/ar/biY/ UEhw== X-Forwarded-Encrypted: i=1; AKwUvByvGZMnwveI+ya5XSyN5Ilsw4b/gJH+Ak7VMsF5W3tg7/slP6rtrF+FOKLh1FuSzzstOutDjpZ3t3TC@vger.kernel.org X-Gm-Message-State: AFuF++mBKfnmnuC9PChZc1DJaX2mJk+fcR5ER/2rnJ1ZJswmRfXpZGZl ZiYIQN90d4LaC2sPARj9huAGV+0a0TppDqSRd/BuCDrQiOVx/esXZfK4wMVoCB9N/oRR35a8Dc0 L4C5kx4GTVQrttg6e5ZwbttTltYCMkfRDPRJ0f9M5V11+byD5mHFdLPxsd3xgQkHG X-Gm-Gg: AYBFou0io1bwevI7xkI5EwEvn2DM1vyf+1uTQiJ43aLatPTr+NNUX3qIpKaiqw/5rXr RAninODYDSSUcZV8MYzvOhPabVhpYWZUDFzG/Zrvxesh5UH6J29w1nn4dWzO4bMfODxF8kP984E PcN4rRCRESdKWBSoohTUXlkFYNU9kfa6zNue1SBE1Jt0VUgatCvVy17t2dPudA4xQBlINFBJq39 OBagoozKkEJqh7R/h5aKXT8eWBRVN83niq1aGKZBQHEjb8gwMbfcsfjzsw/wycKgl3SsDxnIqCq 9rJsqHesGPUg15hDYqH0I5fJNbaKZJofQUlNKs4EooCaZx/saKxYfbIxVkm7G7LjNQtC8Jhvxca eoh4HSwohagyM88lIWaMEMQ== X-Received: by 2002:a05:620a:4408:b0:934:95d9:85fe with SMTP id af79cd13be357-93be055f2fbmr179072885a.3.1789725018039; Fri, 18 Sep 2026 02:50:18 -0700 (PDT) X-Received: by 2002:a05:620a:4408:b0:934:95d9:85fe with SMTP id af79cd13be357-93be055f2fbmr179069585a.3.1789725017588; Fri, 18 Sep 2026 02:50:17 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6aa5975d070sm644748a12.23.2026.09.18.02.50.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2026 02:50:16 -0700 (PDT) Message-ID: Date: Fri, 18 Sep 2026 11:50:14 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/2] clk: qcom: Add LPASS VA CSR heartbeat pulse clock To: sarath.ganapathiraju@oss.qualcomm.com, andersson@kernel.org, abelvesa@kernel.org, sboyd@kernel.org, bmasney+clk@redhat.com, jbrunet+clk@baylibre.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, srinivas.kandagatla@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, prasad.kumpatla@oss.qualcomm.com References: <20260917-master-v8-0-823d2c5d090a@oss.qualcomm.com> <20260917-master-v8-2-823d2c5d090a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260917-master-v8-2-823d2c5d090a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=EMWTQFZC c=1 sm=1 tr=0 ts=6aad0960 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=Y4doX2lIe-IihnvZzhwA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDEzNiBTYWx0ZWRfX/nB15shSyrMQ UWBj49g5BGJvRcTHR3+eYxA56vzBrdWiWbw92Lt/P42PxKxQxaTvd2AYh0nChyqvM4nVJa/nIrr vuESBIwsqSW7Sz41lQCN4as0P9OMsUEcgZ5Jot7It/2r9b8xTFtpQCie+nKOr4IcNBXg+x6LCfL mFBeAlNu5IByMQ71qkj5LoP/8q7CnugLFNUQju/wkLUfOjb0Ls8Xt+5L8HuZ3jKKnRnVAFjfJ7M vmJa9krydatJcPV51T/+v2c8xzJSwrSWMvSoYgmeatIawyRpPhq+zRZQvR+nL/HnrZrxVLW5AaW RuQQR2vhisIdY2ejNOEcOw8dFNSbwrX1Bi3u6zP3lMrzxDZ1J1NWCpw8fEeZvQnUWKcZjeiU0dD p6a1LGMNRKDp4cJ/tWxjNF9T/qmRtDKvhsu5LbwdZWAqzZBQkZhQZaBUzd1YqUup07zfCOQ8j+y 1C8qpTMjpfXtBgxUSVQ== X-Proofpoint-GUID: eTr5oFIlvydcKqtHchoEiMNmJVcdvopM X-Proofpoint-ORIG-GUID: eTr5oFIlvydcKqtHchoEiMNmJVcdvopM X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDEzNiBTYWx0ZWRfXwoQISwDJDmA/ 5MC5Cnf9g0IAH6llqHCCu0FPW64/89QYT2/qML9F5xiclkg2nCWTgPaV7vOX6kb4xtXHTA21m89 if246d00ucY3MwKfsGDLDTMwO7I6v+w= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180136 On 9/17/26 3:57 PM, Sarath Ganapathiraju via B4 Relay wrote: > From: Sarath Ganapathiraju > > The HeartBeat Pulse, also known as RateGen Pulse, synchronizes the > start of DMAs and Codec Interfaces for the audio usecases and can > serve as a periodic wakeup source for the DSP. > > Add the LPASS VA CSR driver that models the rate generator as a clock > provider so it is enabled and disabled automatically alongside the > other clocks during runtime PM resume and suspend. [...] > + ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, &csr->hb.hw); > + if (ret) > + goto err_pm_runtime_put; > + > + pm_runtime_put(dev); > + > + return 0; > + > +err_pm_runtime_put: > + pm_runtime_put(dev); > + > + return ret; You could do return ret above to remove the separate error path Or better yet, you can use the cleanup macros from linux/pm_runtime.h, like PM_RUNTIME_ACQUIRE_IF_ENABLED() to get rid of the gotos altogether Konrad