From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B6CC77B7A for ; Tue, 30 May 2023 19:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233003AbjE3Thz (ORCPT ); Tue, 30 May 2023 15:37:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232977AbjE3Thw (ORCPT ); Tue, 30 May 2023 15:37:52 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 446EB115 for ; Tue, 30 May 2023 12:37:50 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2af316b4515so50833471fa.1 for ; Tue, 30 May 2023 12:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685475468; x=1688067468; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s4TpePdBcmf3Xw/fPvZUtcZlrHBAqUXKquGcCNg+8W4=; b=dwqIw6MQH1tUrPDRdlGNfOTTTS4X4TGXQBY6HjdV5Kg/WHQzZi2rk7Z0ZKBU4R88To 87Gq0HTgwpKhiHITsrTyshd5kxb7AYHjQsTvJCVi4So0J1/KZ+WEV72qAqLGwkIf9tcA j1BBmL89W2jhfWoI6aYtO4BDyJcFk8uOWSWT/CkDscbcr6PFBhwJHjTwvr1nQa25nrRM SVg+N5WOIlmJwPm481pMcfUyC5hjhedozkJhHP7W4lIza4JckFXy+ZYyVrKPedcOJvyO q1608se3L2Em3vQcjSv7Bw3clbM48BtRCN4MTtrYM8E8Xs5f3A5OF6Q6UIwX5Ud7Ey2A 4UxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685475468; x=1688067468; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s4TpePdBcmf3Xw/fPvZUtcZlrHBAqUXKquGcCNg+8W4=; b=VXamcM471UqoviLDJSRKmX82N9f0zwYBZe0JQJvvHbTBUwtD141MNoDA8TcSU4n4NI NqyiO2T/XS20cXJ0B7QXVO1kgw4oufzZE514nCqJww6vZGDQseef6HZoWkmGe4Y8v5dv vWjr4jvxEoMvniN7GNlTcVg+2jgNb2izVaEq/oAgC/OBACF/C+cWGzEE1HgcSsNGBW7f asE1jnqko/6NoPkNsQrC2TuWnviAiwKV6xf+n6kWyi4dCKA5auryufD2hiuBdfzrZJtG czfm6ZXYYaQIub3JkGsNaCRCsxhCxQFxQnGBZ1C5a7pM0kfJvRG++FukIWI3wQfQg/26 F+PQ== X-Gm-Message-State: AC+VfDwteiTwmj4nEbhTmdpbRiL6A/gCPgXM7RAqbKYGFENy4sO3XvEj MQ4NFTCQhNorsP2j4uziiuaJpQ== X-Google-Smtp-Source: ACHHUZ7pnAUM8bkHrV3d/NxVG64VyEJxxguXYTf7NQ+tfO8xq5mMB6Rk9GYLhNJX7tDJe9D0x1Tf0w== X-Received: by 2002:a2e:a212:0:b0:2aa:40dd:7a55 with SMTP id h18-20020a2ea212000000b002aa40dd7a55mr1376227ljm.8.1685475468466; Tue, 30 May 2023 12:37:48 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id t10-20020a2e780a000000b002adb566dc10sm2962863ljc.129.2023.05.30.12.37.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 12:37:48 -0700 (PDT) Message-ID: Date: Tue, 30 May 2023 21:37:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 1/2] dt-bindings: reserved-memory: rmtfs: Allow dynamic allocation Content-Language: en-US To: Bjorn Andersson , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230530193436.3833889-1-quic_bjorande@quicinc.com> <20230530193436.3833889-2-quic_bjorande@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230530193436.3833889-2-quic_bjorande@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30.05.2023 21:34, Bjorn Andersson wrote: > Allow instances of the qcom,rmtfs-mem either be defined as a > reserved-memory regoin, or just standalone given just a size. > > This relieve the DeviceTree source author the need to come up with a > static memory region for the region. > > Signed-off-by: Bjorn Andersson > --- > .../reserved-memory/qcom,rmtfs-mem.yaml | 23 ++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml b/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml > index bab982f00485..8b5de033f9ac 100644 > --- a/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml > +++ b/Documentation/devicetree/bindings/reserved-memory/qcom,rmtfs-mem.yaml > @@ -14,13 +14,16 @@ description: | > maintainers: > - Bjorn Andersson > > -allOf: > - - $ref: reserved-memory.yaml > - > properties: > compatible: > const: qcom,rmtfs-mem > > + qcom,alloc-size: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Requested size of the rmtfs memory allocation, when not defined as a > + reserved-memory region. > + > qcom,client-id: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > > @@ -36,6 +39,11 @@ properties: > required: > - qcom,client-id > > +oneOf: > + - $ref: reserved-memory.yaml > + - required: > + - qcom,alloc-size > + > unevaluatedProperties: false > > examples: > @@ -53,3 +61,12 @@ examples: > qcom,client-id = <1>; > }; > }; > + - | > + rmtfs { > + compatible = "qcom,rmtfs-mem"; > + > + qcom,alloc-size = <(2*1024*1024)>; 2 nitty nits: - Most uses of DT arithmetic put spaces between the operands - You could add a comment explaining what this example brings to the table Konrad > + qcom,client-id = <1>; > + qcom,vmid = <15>; > + }; > +...