Re: [PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds

[Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]

Hi Geert,

Thank you for the review.

On 01.09.2016 10:52, Geert Uytterhoeven wrote:
> On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
>> This supports GPIO leds on H3ULCB board
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
>
>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> @@ -31,6 +31,19 @@
>>                  /* first 128MB is reserved for secure area. */
>>                  reg = <0x0 0x48000000 0x0 0x38000000>;
>>          };
>> +
>> +       leds {
>> +               compatible = "gpio-leds";
>> +               led4 {
>> +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
>> +               };
>> +               led5 {
>> +                       gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
>> +               };
>> +               led6 {
>> +                       gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
>> +               };
>> +       };
> The LEDs share GPIOs with the switches. Unfortunately you cannot use both
> at the same time.
> Perhaps we want to configure one of them for the switch, to be used as a
> wakeup-source?
This is a good point.

I will respin this patch accordingly to your suggestion.

Regards,
Vladimir
>
> The same applies to Salvator-X, where we haven't wired up the LEDs nor
> switches (yet).
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html