From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C7F7194AEB for ; Thu, 5 Sep 2024 14:54:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725548090; cv=none; b=Cn7H/mx4J+J4cYwQ/oWUp+6MnCoHXfnVnfSjhTv0uz0//cDAkvAe7QQPLalHRZ/U0/s/i7IzPDEEGh30kTKTRcIhDU1WqalyGeX2konZUyx/rdQplUtYpxz0tNHS1L+LAS7+AkOGipXtXkoteyo6S+/IT9f5y5G8KgayN1b53vA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725548090; c=relaxed/simple; bh=tOnyJWreV7XtwFVhcFtNxD7Tqs1oW5u/vVn7bF4Xiic=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=Z9NsnzN2wEyVQn23gje4hbgbVlwl5LKsAaZEnlXFksYAsfCwxoOwHf08/uZPaAfqdHX3Cc9rUqJehv08xJBeJjW4REEEe2S/mtqEMPBG+/W5kXsp8U32fAPTpKBDS3JG1YClUcsCblMjakbAIE4vSKzAToj4ASRXw4a26VQhdJ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dgN8GSJQ; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dgN8GSJQ" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2f3fcdfa099so1070311fa.2 for ; Thu, 05 Sep 2024 07:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725548087; x=1726152887; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zElmk3sfGwQ+m2XSD0HQH0KyA41c/pIdozqVm+yLhAo=; b=dgN8GSJQa9vTodxKnRqt6vzR6qVQm/ZM72M51t2nzLFrkm56ceM9XDCWJstSn0Lfv/ bQ4W4qZ9fHUzgUzsLg519pnMkxYLZuIBvHse2W9cNTO05e930Ta09uHC4uNfq+iu1r18 fguKsJ29/iLCg1b8MNDl8hz9N1pl0he13iyU62rIGSwHa24jAhzNtLA5UrjxtJcDuGul DfR1nd6KV7vCoGXEhRf5MYY3LVr/XxNa3TJlue7u6d0d3JMkgDM+3a5SAlyxnOXfdxY5 fD8L1061NxFU9u8sbmDX6/4+qSFHvHrbMdI4PL1iVjig5qXUngQp76N/ZgJc5cAkD3xD Zogw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725548087; x=1726152887; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zElmk3sfGwQ+m2XSD0HQH0KyA41c/pIdozqVm+yLhAo=; b=CbVnJonOG4HaQ66W5LZEqiwuYC96nlhbuOcvC/JOdMkrBDp50SAD2KGYtSLc+04s53 KOJhEN1AIeGI6t7m2gkTEFpfBV420QWduocE7lS1aKT2zkoSta5J8/huHjinpEDsAsQK YBal2oEd6IOm9ktzsjVMm4tNlWfU2PRp+2DV+AZUpl+9r8C/pqdHi+d2DxSPH/XK1LxP IQxvwPQdgq+V1VqPw7gkDCqRg3nfULJncaQnViX3ZOLZDQ5Thlsn9Z1Sq308YelCB2Hs liAN6qllo/qToyDLR06yMsfTM922AKacDbgP+NwfiVozhMaGIJIEE21z6RFPVRjtbflx xx+Q== X-Forwarded-Encrypted: i=1; AJvYcCVZL7YwiA1Erk7uVnFg1csbEpbB6U6DgPUAjgrOAXdb14RenfOSnPTAbyHkO6feVeTfsOcLz57q+mWo@vger.kernel.org X-Gm-Message-State: AOJu0YyAAXEBysNCORoui4EdNhGhqio0c5Frn7Zv4JqGnPNBlzT5xA/v 817dFMT537b2MBjcXm0rA0tqzU3Vn8sfEvET8hqF5h/jfDs7uyEoWJfSFnr30cE= X-Google-Smtp-Source: AGHT+IE9ZOX27DWxEVj62bPqXJGKaQ29pm3tZgytTzwuMo7b4S7gCbQ5DtOrO5L9VMNnFFtkYI2SoA== X-Received: by 2002:a2e:b8d6:0:b0:2ef:23af:f1f2 with SMTP id 38308e7fff4ca-2f61e0c72e8mr84626971fa.9.1725548086403; Thu, 05 Sep 2024 07:54:46 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f615171d51sm28554161fa.82.2024.09.05.07.54.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 07:54:46 -0700 (PDT) Message-ID: Date: Thu, 5 Sep 2024 17:54:45 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/7] dt-bindings: media: camss: Add qcom,sdm670-camss Content-Language: en-US To: Richard Acayan , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Loic Poulain , Robert Foss , Andi Shyti , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org References: <20240904020448.52035-9-mailingradian@gmail.com> <20240904020448.52035-13-mailingradian@gmail.com> From: Vladimir Zapolskiy In-Reply-To: <20240904020448.52035-13-mailingradian@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Richard. On 9/4/24 05:04, Richard Acayan wrote: > As found in the Pixel 3a, the Snapdragon 670 has a camera subsystem with > 3 CSIDs and 3 VFEs (including 1 VFE lite). Add this camera subsystem to > the bindings. > > Adapted from SC8280XP camera subsystem. > > Signed-off-by: Richard Acayan > Reviewed-by: Krzysztof Kozlowski > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + ; I suppose it should be IRQ_TYPE_EDGE_RISING type for all interrupts, please correct it here and in the dts change. Here I rely on the interrupt type requested in the camss driver. > + interrupt-names = "csid0", > + "csid1", > + "csid2", > + "csiphy0", > + "csiphy1", > + "csiphy2", > + "vfe0", > + "vfe1", > + "vfe_lite"; -- Best wishes, Vladimir