From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAEC8C433DF for ; Fri, 21 Aug 2020 14:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A1FD2075E for ; Fri, 21 Aug 2020 14:54:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="sZqB5TML" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726324AbgHUOyD (ORCPT ); Fri, 21 Aug 2020 10:54:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727084AbgHUOx7 (ORCPT ); Fri, 21 Aug 2020 10:53:59 -0400 Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F18A8C061575 for ; Fri, 21 Aug 2020 07:53:58 -0700 (PDT) Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 17DAB5C0103; Fri, 21 Aug 2020 16:53:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1598021637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QWqdY2lvxfq65gGGv4mB38boJwAXuNffHkbspWayYC8=; b=sZqB5TMLvvpdwJ0SN6w9cpy9l+3MXqiNGCTLgf8jAGIXhFGnUho+OmfA7aAnMqIBCNEv5E j5dVBjGGAvZNP+M5r5EQmY7piZEiUKA5zyl44AF+N7WuH0DUYPMsMym4/GEsaeyKtYLa1U 6m3EBY/N2VTdO6Bueewd/tBCzi0224o= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Fri, 21 Aug 2020 16:53:56 +0200 From: Stefan Agner To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Marek Vasut , Rob Herring , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Guido_G=C3=BCnther?= Subject: Re: [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings In-Reply-To: <20200813012910.13576-3-laurent.pinchart@ideasonboard.com> References: <20200813012910.13576-1-laurent.pinchart@ideasonboard.com> <20200813012910.13576-3-laurent.pinchart@ideasonboard.com> User-Agent: Roundcube Webmail/1.4.1 Message-ID: X-Sender: stefan@agner.ch Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020-08-13 03:29, Laurent Pinchart wrote: > Additional compatible strings have been added in DT source for the > i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings. > Most of the upstream DT sources use the fsl,imx28-lcdif compatible > string, which mostly predates the realization that the LCDIF in the > i.MX6 and newer SoCs have extra features compared to the i.MX28. Agreed, we should add fsl,imx6sx-lcdif for those devices. But shouldn't we also keep fsl,imx28-lcdif? From what I can tell, the devices can be driven by a driver only supporting fsl,imx28-lcdif semantics, right? -- Stefan > > Update the bindings to add the missing compatible strings, with the > correct fallback values. This fails to validate some of the upstream DT > sources. Instead of adding the incorrect compatible fallback to the > binding, the sources should be updated separately. > > Signed-off-by: Laurent Pinchart > --- > .../devicetree/bindings/display/mxsfb.yaml | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mxsfb.yaml > b/Documentation/devicetree/bindings/display/mxsfb.yaml > index 202381ec5bb7..ec6533b1d4a3 100644 > --- a/Documentation/devicetree/bindings/display/mxsfb.yaml > +++ b/Documentation/devicetree/bindings/display/mxsfb.yaml > @@ -15,11 +15,19 @@ description: | > > properties: > compatible: > - enum: > - - fsl,imx23-lcdif > - - fsl,imx28-lcdif > - - fsl,imx6sx-lcdif > - - fsl,imx8mq-lcdif > + oneOf: > + - enum: > + - fsl,imx23-lcdif > + - fsl,imx28-lcdif > + - fsl,imx6sx-lcdif > + - items: > + - enum: > + - fsl,imx6sl-lcdif > + - fsl,imx6sll-lcdif > + - fsl,imx6ul-lcdif > + - fsl,imx7d-lcdif > + - fsl,imx8mq-lcdif > + - const: fsl,imx6sx-lcdif > > reg: > maxItems: 1