public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Jagan Sridharan" <badhri@google.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Sam Protsenko <semen.protsenko@linaro.org>,
	Will McVicker <willmcvicker@google.com>,
	Roy Luo <royluo@google.com>,
	kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 6/6] arm64: dts: exynos: gs101-oriole: add pd-disable and typec-power-opmode
Date: Thu, 28 Nov 2024 09:34:54 +0100	[thread overview]
Message-ID: <c9f8ae74-5d25-4d26-82f3-6a6c8331df2a@kernel.org> (raw)
In-Reply-To: <4a5c27922a9852c06e1832dcc63b4a448e8955e5.camel@linaro.org>

On 28/11/2024 09:34, André Draszik wrote:
> On Thu, 2024-11-28 at 09:21 +0100, Krzysztof Kozlowski wrote:
>> On 27/11/2024 12:01, André Draszik wrote:
>>> When the serial console is enabled, we need to disable power delivery
>>> since serial uses the SBU1/2 pins and appears to confuse the TCPCI,
>>> resulting in endless interrupts.
>>>
>>> For now, change the DT such that the serial console continues working.
>>>
>>> Note1: We can not have both typec-power-opmode and
>>> new-source-frs-typec-current active at the same time, as otherwise DT
>>> binding checks complain.
>>>
>>> Note2: When using a downstream DT, the Pixel boot-loader will modify
>>> the DT accordingly before boot, but for this upstream DT it doesn't
>>> know where to find the TCPCI node. The intention is for this commit to
>>> be reverted once an updated Pixel boot-loader becomes available.
>>>
>>> Signed-off-by: André Draszik <andre.draszik@linaro.org>
>>
>> This should be squashed to the previous patch, including also combining
>> commit messages.
> 
> I contemplated that, but I didn't in the end so that it's easy to just
> revert this specific patch once the boot loader is updated.
> 
> I would prefer to keep them as separate patches for that reason, but will
> squash if you still think that's better.
> 

OK, can be separate.

Best regards,
Krzysztof

      reply	other threads:[~2024-11-28  8:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-27 11:01 [PATCH 0/6] Google Pixel 6 (oriole): TCPCI enablement & USB updates André Draszik
2024-11-27 11:01 ` [PATCH 1/6] arm64: defconfig: enable Maxim TCPCI driver André Draszik
2024-11-28 10:49   ` Peter Griffin
2024-11-27 11:01 ` [PATCH 2/6] dt-bindings: usb: max33359: add max77759 flavor André Draszik
2024-11-27 15:57   ` Conor Dooley
2024-11-28  8:17   ` Krzysztof Kozlowski
2024-11-28  8:40     ` André Draszik
2024-11-27 11:01 ` [PATCH 3/6] arm64: dts: exynos: gs101: phy region for exynos5-usbdrd is larger André Draszik
2024-11-27 11:01 ` [PATCH 4/6] arm64: dts: exynos: gs101: enable snps,dis_rxdet_inp3_quirk for DWC3 André Draszik
2024-11-29 11:24   ` André Draszik
2024-11-27 11:01 ` [PATCH 5/6] arm64: dts: exynos: gs101-oriole: enable Maxim max77759 TCPCi André Draszik
2024-11-28  8:19   ` Krzysztof Kozlowski
2024-11-28  8:28     ` André Draszik
2024-11-28  8:34       ` Krzysztof Kozlowski
2024-11-27 11:01 ` [PATCH 6/6] arm64: dts: exynos: gs101-oriole: add pd-disable and typec-power-opmode André Draszik
2024-11-28  8:21   ` Krzysztof Kozlowski
2024-11-28  8:34     ` André Draszik
2024-11-28  8:34       ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9f8ae74-5d25-4d26-82f3-6a6c8331df2a@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=badhri@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=royluo@google.com \
    --cc=semen.protsenko@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=will@kernel.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox